From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Tony Luck <tony.luck@intel.com>,
EDAC Mailing List <linux-edac@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mauro Carvalho Chehab <m.chehab@huawei.com>,
Shengwei Luo <luoshengwei@huawei.com>,
Daniel Ferguson <danielf@os.amperecomputing.com>,
Jose <shiju.jose@huawei.com>,
Jason Tian <jason@os.amperecomputing.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Roberto Sassu <roberto.sassu@huawei.com>
Subject: [GIT PULL for v6.10-rc6] edac fixes for kernel 6.11
Date: Wed, 26 Jun 2024 11:33:41 +0200 [thread overview]
Message-ID: <20240626113322.5e263aa0@coco.lan> (raw)
Hi Borislav,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac tags/edac/v6.10-1
For two patches that fix UEFI 2.6+ implementation of the ARM trace event,
as the original implementation was incomplete.
The patches on this series was sent at:
https://lore.kernel.org/all/20240321-b4-arm-ras-error-vendor-info-v5-rc3-v5-0-850f9bfb97a8@os.amperecomputing.com/
I did a couple of changes at the first patch addressing some coding style
issues. At the second patch, I replaced the original description to a proper
one identifying precisely why the patch is needed and what it does.
In summary:
changeset e9279e83ad1f ("trace, ras: add ARM processor error trace event")
was incomplete: it added a trace event that was reporting only some fields
of the CPER record generated for ARM processor from UEFI 2.6 spec.
Those are not enough to actually parse such events on userspace, nor to
take any actions like isolating problematic CPU cores.
The patch was validated with the help of an ARM EINJ code for QEMU:
https://github.com/mchehab/rasdaemon/wiki/error-injection
I tested the ghes and cper reports both with and without this change,
using different versions of rasdaemon, with and without support for
the extended trace event. Those are a summary of the test results:
- adding more fields to the trace events didn't break userspace API:
both versions of rasdaemon handled it;
- the rasdaemon patches to handle the new trace report was missing
a backward-compatibility logic. I fixed already. With that, rasdaemon
can handle both old and new trace events.
Btw, rasdaemon has gained support for the extended trace since its
version 0.5.8 (released in 2021). I didn't saw any issues there
complain about troubles on it, so either distros used on ARM servers
are using an old version of rasdaemon, or they're carrying on the trace
event changes as well.
Regards,
Mauro
---
The following changes since commit 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0:
Thanks,
Mauro
next reply other threads:[~2024-06-26 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 9:33 Mauro Carvalho Chehab [this message]
2024-06-26 10:02 ` [GIT PULL for v6.10-rc6] edac fixes for kernel 6.11 Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626113322.5e263aa0@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=bp@alien8.de \
--cc=danielf@os.amperecomputing.com \
--cc=jason@os.amperecomputing.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luoshengwei@huawei.com \
--cc=m.chehab@huawei.com \
--cc=roberto.sassu@huawei.com \
--cc=shiju.jose@huawei.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.