From: Jason Gunthorpe <jgg@nvidia.com>
To: Michael Margolin <mrgolin@amazon.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org, sleybo@amazon.com,
matua@amazon.com, gal.pressman@linux.dev,
Firas Jahjah <firasj@amazon.com>,
Yonatan Nachum <ynachum@amazon.com>
Subject: Re: [PATCH for-next 5/5] RDMA/efa: Align private func names to a single convention
Date: Wed, 26 Jun 2024 12:38:34 -0300 [thread overview]
Message-ID: <20240626153834.GA3233164@nvidia.com> (raw)
In-Reply-To: <20240624160918.27060-6-mrgolin@amazon.com>
On Mon, Jun 24, 2024 at 04:09:18PM +0000, Michael Margolin wrote:
> Name functions that aren't exposed outside of a file with '_' prefix and
> make sure that all verbs ops' implementations are named according to the
> op name with an additional 'efa_' prefix.
That isn't the kernel convention, please don't use _ like this
Jason
next prev parent reply other threads:[~2024-06-26 15:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 16:09 [PATCH for-next 0/5] RDMA/efa: Cleanups and minor improvements Michael Margolin
2024-06-24 16:09 ` [PATCH for-next 1/5] RDMA/efa: Use offset_in_page() function Michael Margolin
2024-06-25 6:32 ` Gal Pressman
2024-06-24 16:09 ` [PATCH for-next 2/5] RDMA/efa: Remove duplicate aenq enable macro Michael Margolin
2024-06-25 6:32 ` Gal Pressman
2024-06-24 16:09 ` [PATCH for-next 3/5] RDMA/efa: Validate EQ array out of bounds reach Michael Margolin
2024-06-25 6:33 ` Gal Pressman
2024-06-25 11:28 ` Margolin, Michael
2024-06-25 14:16 ` Leon Romanovsky
2024-06-24 16:09 ` [PATCH for-next 4/5] RDMA/efa: Move type conversion helpers to efa.h Michael Margolin
2024-06-25 6:33 ` Gal Pressman
2024-06-25 11:21 ` Margolin, Michael
2024-06-25 14:19 ` Leon Romanovsky
2024-06-24 16:09 ` [PATCH for-next 5/5] RDMA/efa: Align private func names to a single convention Michael Margolin
2024-06-26 15:38 ` Jason Gunthorpe [this message]
2024-06-27 16:57 ` Margolin, Michael
2024-06-27 18:43 ` Leon Romanovsky
2024-06-28 14:27 ` Jason Gunthorpe
2024-06-26 17:55 ` [PATCH for-next 0/5] RDMA/efa: Cleanups and minor improvements Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626153834.GA3233164@nvidia.com \
--to=jgg@nvidia.com \
--cc=firasj@amazon.com \
--cc=gal.pressman@linux.dev \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.