From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Sam Kappen <skappen@mvista.com>
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
tom.zanussi@linux.intel.com, zanussi@kernel.org,
sam.gsk@gmail.com
Subject: Re: [PATCH RT v4.19] tcp: md5: Add a serialization in tcp MD5 hash functions.
Date: Thu, 27 Jun 2024 08:53:09 +0200 [thread overview]
Message-ID: <20240627065309.e_MPmlKm@linutronix.de> (raw)
In-Reply-To: <1718966972-17507-1-git-send-email-skappen@mvista.com>
On 2024-06-21 12:49:32 [+0200], Sam Kappen wrote:
…
> --- a/net/ipv4/tcp_ipv4.c
> +++ b/net/ipv4/tcp_ipv4.c
> @@ -93,6 +93,7 @@ static int tcp_v4_md5_hash_hdr(char *md5_hash, const struct tcp_md5sig_key *key,
> __be32 daddr, __be32 saddr, const struct tcphdr *th);
> #endif
>
> +static DEFINE_LOCAL_IRQ_LOCK(tcp_md5_lock);
> struct inet_hashinfo tcp_hashinfo;
> EXPORT_SYMBOL(tcp_hashinfo);
>
> @@ -1224,6 +1225,7 @@ static int tcp_v4_md5_hash_hdr(char *md5_hash, const struct tcp_md5sig_key *key,
> struct tcp_md5sig_pool *hp;
> struct ahash_request *req;
>
> + local_lock(tcp_md5_lock);
> hp = tcp_get_md5sig_pool();
Instead of this, could you please move the lock to within
tcp_get_md5sig_pool()/ tcp_put_md5sig_pool()? That way it will also fix
ipv6 in the same way.
Sebastian
next prev parent reply other threads:[~2024-06-27 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 10:49 [PATCH RT v4.19] tcp: md5: Add a serialization in tcp MD5 hash functions Sam Kappen
2024-06-27 6:53 ` Sebastian Andrzej Siewior [this message]
2024-06-27 13:11 ` Sam Kappen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627065309.e_MPmlKm@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=sam.gsk@gmail.com \
--cc=skappen@mvista.com \
--cc=tom.zanussi@linux.intel.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.