From: Daniel Wagner <dwagner@suse.de>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Hannes Reinecke <hare@suse.de>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Daniel Wagner <dwagner@suse.de>
Subject: [PATCH blktests v3 2/3] nvme/030: only run against kernel soft target
Date: Thu, 27 Jun 2024 11:10:15 +0200 [thread overview]
Message-ID: <20240627091016.12752-3-dwagner@suse.de> (raw)
In-Reply-To: <20240627091016.12752-1-dwagner@suse.de>
This tests is exercising the target code and not so much the host side.
The problem with nvme/030 is that it depends on interface to interact
with the target which is not covered by the standard. Thus we can't
run it against a real target. Just skip it when we run against a
real target.
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
tests/nvme/030 | 1 +
tests/nvme/rc | 8 ++++++++
2 files changed, 9 insertions(+)
diff --git a/tests/nvme/030 b/tests/nvme/030
index b1ed8bc20908..ae7081d55354 100755
--- a/tests/nvme/030
+++ b/tests/nvme/030
@@ -13,6 +13,7 @@ requires() {
_nvme_requires
_have_loop
_require_nvme_trtype_is_fabrics
+ _require_kernel_nvme_target
}
set_conditions() {
diff --git a/tests/nvme/rc b/tests/nvme/rc
index 4465dea0370b..5e2e440ccd47 100644
--- a/tests/nvme/rc
+++ b/tests/nvme/rc
@@ -225,6 +225,14 @@ _require_kernel_nvme_fabrics_feature() {
return 0
}
+_require_kernel_nvme_target() {
+ if [[ -n "${nvme_target_control}" ]]; then
+ SKIP_REASONS+=("Linux kernel soft target not available")
+ return 1;
+ fi
+ return 0
+}
+
_test_dev_nvme_ctrl() {
echo "/dev/char/$(cat "${TEST_DEV_SYSFS}/device/dev")"
}
--
2.45.2
next prev parent reply other threads:[~2024-06-27 9:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 9:10 [PATCH blktests v3 0/3] Add support to run against real target Daniel Wagner
2024-06-27 9:10 ` [PATCH blktests v3 1/3] nvme/rc: introduce remote target support Daniel Wagner
2024-06-27 9:59 ` Hannes Reinecke
2024-06-27 10:23 ` Daniel Wagner
2024-07-02 8:51 ` Shinichiro Kawasaki
2024-07-02 9:31 ` Shinichiro Kawasaki
2024-06-27 9:10 ` Daniel Wagner [this message]
2024-06-27 9:10 ` [PATCH blktests v3 3/3] contrib: add remote target setup/cleanup script Daniel Wagner
2024-06-27 9:28 ` [PATCH blktests v3 0/3] Add support to run against real target Hannes Reinecke
2024-06-27 12:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627091016.12752-3-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=chaitanyak@nvidia.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.