From: Jakub Kicinski <kuba@kernel.org>
To: Dave Jiang <dave.jiang@intel.com>
Cc: ntb@lists.linux.dev, netdev@vger.kernel.org, jdmason@kudzu.us,
allenbh@gmail.com, davem@davemloft.net, edumazet@google.com,
abeni@redhat.com, Jerry Dai <jerry.dai@intel.com>
Subject: Re: [PATCH] net: ntb_netdev: Move ntb_netdev_rx_handler() to call netif_rx() from __netif_rx()
Date: Thu, 27 Jun 2024 16:54:36 -0700 [thread overview]
Message-ID: <20240627165436.19e82af5@kernel.org> (raw)
In-Reply-To: <20240626180613.3190229-1-dave.jiang@intel.com>
On Wed, 26 Jun 2024 11:06:13 -0700 Dave Jiang wrote:
> Fixes: baebdf48c360 ("net: dev: Makes sure netif_rx() can be invoked in any context.")
Patch LGTM, but I think the Fixes tag needs to go back further.
Sebastian renamed and flipped semantics at the same time, so
what he did for this driver should be a noop.
IOW prior to his change netif_rx() expected to be called with
BH disabled, and the driver should have been using netif_rx_ni()
or netif_rx_any_context().
Maybe add this extra info to the commit message, there's also a way
to point out a dependency via a special tag..
But the Fixes tag should point to where the bug was introduced.
--
pw-bot: cr
prev parent reply other threads:[~2024-06-27 23:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 18:06 [PATCH] net: ntb_netdev: Move ntb_netdev_rx_handler() to call netif_rx() from __netif_rx() Dave Jiang
2024-06-27 23:54 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627165436.19e82af5@kernel.org \
--to=kuba@kernel.org \
--cc=abeni@redhat.com \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdmason@kudzu.us \
--cc=jerry.dai@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ntb@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.