All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Sohil Mehta <sohil.mehta@intel.com>
Cc: Xin Li <xin@zytor.com>, "X86 Kernel" <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	Dave Hansen <dave.hansen@intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	<linux-perf-users@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Andi Kleen <andi.kleen@intel.com>, Xin Li <xin3.li@intel.com>,
	jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v2 1/6] x86/irq: Add enumeration of NMI source reporting CPU feature
Date: Thu, 27 Jun 2024 22:00:40 -0700	[thread overview]
Message-ID: <20240627220040.1897cde7@jacob-builder> (raw)
In-Reply-To: <5c1f24aa-79f0-4142-80b2-f13c41b91d76@intel.com>


On Fri, 21 Jun 2024 16:00:47 -0700, Sohil Mehta <sohil.mehta@intel.com>
wrote:

> >> +config X86_NMI_SOURCE  
> > 
> > Lets reuse X86_FRED instead of adding another hard config option. See
> > below.
> >   
> 
> I mostly agree with the suggestion here but there seems to be a bit of
> confusion regarding feature availability and feature activation.
> 
> Availability and activation of X86_FEATURE_NMI_SOURCE depends on FRED
> but not the other way around.
> 
> In other words, CONFIG_X86_NMI_SOURCE would only be useful if someone
> wants to disable NMI_SOURCE even if both X86_FEATURE_FRED and
> X86_FEATURE_NMI_SOURCE are available on a platform.
> 
> This seems unlikely to me. Reusing CONFIG_X86_FRED seems reasonable.
agreed, will remove CONFIG_X86_NMI_SOURCE


Thanks,

Jacob

  reply	other threads:[~2024-06-28  4:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11 16:54 Jacob Pan
2024-06-11 16:54 ` [PATCH v2 1/6] x86/irq: Add enumeration of NMI source reporting CPU feature Jacob Pan
2024-06-12  2:32   ` Xin Li
2024-06-12  2:50     ` H. Peter Anvin
2024-06-12  3:04       ` Xin Li
2024-06-21 23:00     ` Sohil Mehta
2024-06-28  5:00       ` Jacob Pan [this message]
2024-06-21 22:23   ` Sohil Mehta
2024-06-21 23:46     ` Jacob Pan
2024-06-22  1:08       ` Sohil Mehta
2024-06-27 22:23         ` Jacob Pan
2024-06-27 23:20           ` Sohil Mehta
2024-06-11 16:54 ` [PATCH v2 2/6] x86/irq: Extend NMI handler registration interface to include source Jacob Pan
2024-06-24 23:16   ` Sohil Mehta
2024-06-28  4:56     ` Jacob Pan
2024-06-11 16:54 ` [PATCH v2 3/6] x86/irq: Factor out common NMI handling code Jacob Pan
2024-06-11 16:54 ` [PATCH v2 4/6] x86/irq: Process nmi sources in NMI handler Jacob Pan
2024-06-11 18:41   ` H. Peter Anvin
2024-06-12 21:54     ` Jacob Pan
2024-06-24 23:38       ` Sohil Mehta
2024-06-24 23:53   ` Sohil Mehta
2024-06-11 16:54 ` [PATCH v2 5/6] perf/x86: Enable NMI source reporting for perfmon Jacob Pan
2024-06-11 19:10   ` H. Peter Anvin
2024-06-12 20:27     ` Jacob Pan
2024-06-11 16:54 ` [PATCH v2 6/6] x86/irq: Enable NMI source on IPIs delivered as NMI Jacob Pan
2024-06-12  2:04 ` Sean Christopherson
2024-06-12  2:55   ` Re: Xin Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240627220040.1897cde7@jacob-builder \
    --to=jacob.jun.pan@linux.intel.com \
    --cc=andi.kleen@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sohil.mehta@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xin3.li@intel.com \
    --cc=xin@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.