All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: brauner@kernel.org, jack@suse.cz, huyue2@coolpad.com,
	linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v6.6] erofs: fix NULL dereference of dif->bdev_handle in fscache mode
Date: Thu, 27 Jun 2024 13:16:20 +0200	[thread overview]
Message-ID: <2024062733-cradle-imprecise-002f@gregkh> (raw)
In-Reply-To: <2a427366-0f63-4024-a3b3-759a4f902061@linux.alibaba.com>

On Thu, Jun 27, 2024 at 05:50:26PM +0800, Gao Xiang wrote:
> 
> 
> On 2024/6/27 17:35, Gao Xiang wrote:
> > 
> > 
> > On 2024/6/27 17:11, Hongbo Li wrote:
> 
> ..
> 
> > > 
> > > The reason is the same with 8bd90b6ae7856("erofs: fix NULL dereference of dif->bdev_handle in fscache mode") in mainline. So we should backport this
> > > patch into stable linux-6.6.y to avoid this bug.
> > 
> > Yes, commit 8bd90b6ae785 should be backported to
> > Linux 6.6.y LTS immediately.
> 
> BTW, It seems that
> 
> commit "erofs: Convert to use bdev_open_by_path()" was
> backported as a dependency since v6.6.23 even I
> explicitly commented that this patch is unnecessary
> and I tend to manually backport instead as below:
> 
> https://lore.kernel.org/r/ZgDHG8Ucl3EkY4ZS@debian
> 
> 
> However, my comment was eventually ignored and
> some other related fix like
> "erofs: fix NULL dereference of dif->bdev_handle in fscache mode"
> 
> wasn't backported along with
> "erofs: Convert to use bdev_open_by_path()"

Sorry, I missed that somehow, my fault.

> So the affected 6.6 LTS versions seem to be
> v6.6.23 ~ v6.6.35 (current)

So what specifically should we do here?

thanks,

greg k-h

  reply	other threads:[~2024-06-27 11:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27  9:13 [PATCH v6.6] erofs: fix NULL dereference of dif->bdev_handle in fscache mode Hongbo Li via Linux-erofs
2024-06-27  9:11 ` Hongbo Li via Linux-erofs
2024-06-27  9:35   ` Gao Xiang
2024-06-27  9:50     ` Gao Xiang
2024-06-27 11:16       ` Greg KH [this message]
2024-06-27 12:36         ` Gao Xiang
2024-06-27 12:51           ` Gao Xiang
2024-06-27 13:22             ` Greg KH
2024-06-27 14:03               ` Gao Xiang
2024-07-02  8:46                 ` Greg KH
2024-07-02 11:21                   ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024062733-cradle-imprecise-002f@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=brauner@kernel.org \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=huyue2@coolpad.com \
    --cc=jack@suse.cz \
    --cc=linux-erofs@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.