From: Conor Dooley <conor@kernel.org>
To: iansdannapel@gmail.com
Cc: "Moritz Fischer" <mdf@kernel.org>, "Wu Hao" <hao.wu@intel.com>,
"Xu Yilun" <yilun.xu@intel.com>, "Tom Rix" <trix@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko.stuebner@cherry.de>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Chris Morgan" <macromorgan@hotmail.com>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Andre Przywara" <andre.przywara@arm.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: fpga: Add Efinix serial SPI programming bindings
Date: Fri, 28 Jun 2024 17:07:30 +0100 [thread overview]
Message-ID: <20240628-wind-security-002879d225b5@spud> (raw)
In-Reply-To: <20240628152348.61133-3-iansdannapel@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 328 bytes --]
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + fpga_mgr_spi: fpga-mgr@0 {
nit: the label here isn't used and can be dropped.
Otherwise this looks okay to me,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-06-28 16:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 14:42 [PATCH 1/3] fpga: Add Efinix Trion & Titanium serial SPI programming driver iansdannapel
2024-06-20 18:05 ` Marco Pagani
2024-06-28 15:23 ` [PATCH v2 0/3] Summary of changes iansdannapel
2024-06-28 15:23 ` [PATCH v2 1/3] fpga: Add Efinix Trion & Titanium serial SPI programming driver iansdannapel
2024-07-02 21:27 ` Dan Carpenter
2024-07-12 6:53 ` Xu Yilun
2024-07-25 13:44 ` Ian Dannapel
2024-07-27 15:58 ` Xu Yilun
2024-07-28 11:44 ` Ian Dannapel
2024-07-29 14:50 ` Xu Yilun
2024-08-09 10:38 ` Ian Dannapel
2024-06-28 15:23 ` [PATCH v2 2/3] dt-bindings: fpga: Add Efinix serial SPI programming bindings iansdannapel
2024-06-28 16:07 ` Conor Dooley [this message]
2024-06-28 15:23 ` [PATCH v2 3/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc iansdannapel
2024-06-28 16:00 ` Conor Dooley
2024-07-02 8:57 ` Alexander Dahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240628-wind-security-002879d225b5@spud \
--to=conor@kernel.org \
--cc=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hao.wu@intel.com \
--cc=heiko.stuebner@cherry.de \
--cc=iansdannapel@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macromorgan@hotmail.com \
--cc=mdf@kernel.org \
--cc=michael.riesch@wolfvision.net \
--cc=neil.armstrong@linaro.org \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.