From: Christoph Hellwig <hch@lst.de>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 5/5] block: remove bio_integrity_process
Date: Fri, 28 Jun 2024 08:02:18 +0200 [thread overview]
Message-ID: <20240628060218.GB26206@lst.de> (raw)
In-Reply-To: <d482d9a0-9d9f-1b4b-5511-c787f43a31af@samsung.com>
On Fri, Jun 28, 2024 at 12:03:09AM +0530, Kanchan Joshi wrote:
> In general yes. Maybe I can profile this particular case someday and get
> myself convinced. But regardless, I am unsure what the patch buys.
It avoid a pointless indirection that make the code hard to follow.
next prev parent reply other threads:[~2024-06-28 6:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 4:59 integrity cleanups Christoph Hellwig
2024-06-26 4:59 ` [PATCH 1/5] block: only zero non-PI metadata tuples in bio_integrity_prep Christoph Hellwig
2024-06-27 15:42 ` Kanchan Joshi
2024-06-26 4:59 ` [PATCH 2/5] block: simplify adding the payload " Christoph Hellwig
2024-06-27 15:42 ` Kanchan Joshi
2024-06-26 4:59 ` [PATCH 3/5] block: remove allocation failure warnings " Christoph Hellwig
2024-06-27 15:42 ` Kanchan Joshi
2024-06-26 4:59 ` [PATCH 4/5] block: switch on bio operation " Christoph Hellwig
2024-06-27 15:41 ` Kanchan Joshi
2024-06-26 4:59 ` [PATCH 5/5] block: remove bio_integrity_process Christoph Hellwig
2024-06-27 15:36 ` Kanchan Joshi
2024-06-27 15:47 ` Christoph Hellwig
2024-06-27 18:33 ` Kanchan Joshi
2024-06-28 6:02 ` Christoph Hellwig [this message]
2024-06-27 3:44 ` integrity cleanups Martin K. Petersen
2024-06-28 16:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240628060218.GB26206@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.