From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C633014388F for ; Fri, 28 Jun 2024 07:45:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719560717; cv=none; b=VGFpoJqMVTtWuX16yz2kRttgVBbI6jZ56S+RAxDIYiD8c+ftXzDyDTEZlYquvRdCrUbgmIlWwwWKNxGLN7KPohTpdwff9d1TtrUjIddwuH5ufH8NutZL3OTkTRELt0rp6Vbg0fzktQZ7d1g6MexWLKOJwuJ0WFV+jbOxDbWPl/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719560717; c=relaxed/simple; bh=yK668WcTZLOJw4BVcInFsi2DRk/KSYDVqA7Fig00L98=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=H6pb8kyFV573NvR655pZjY7Q0AgSkT3vALSk1ZSqu23qZFQSVs+sAjog4BJ+zErU+OtKWteNtJLplxSu3FnvxRIk6A6goP2mG+OImeabm7Nsbh2F/5tb39syiB+Zh3dB/C+PRU1clHNus9qIpaFEGCJWYQzOnFJglZYfbE5Lq8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=JL+7kUq1; arc=none smtp.client-ip=217.70.183.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="JL+7kUq1" Received: by mail.gandi.net (Postfix) with ESMTPSA id 9CAD4FF806; Fri, 28 Jun 2024 07:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1719560713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EnuubegvOe+sUBWqClTh59X4+t4oNOFvsmld2Nx+GdI=; b=JL+7kUq13ClciI3OamkaMysFgmgNGEERBYxpXrO2adYuf/gUI3RIrOFzYRPtZwceRkde3m JHmKlgnnbe2cIq7Wcr/Q7mIGRpCvTOh87V74s+zQGTgHnEkqjU76kVAEsydKOV7mZ2mOgh TQJ4lMMJOZJKfOR1aRzqHSY1FfdN2OWuwaMCu2NV5xLO2xlAhpbgn+JqmHpt38v3F69kvW p5AyenYDHk7oEEiwkzeksDztOHaEZ6mq6ZT5L7fSQS7YVR9uJNvs18PFcupXBPauDjWhIo /3c8fw/OhM6b0Z4SXnpXhYR4q4WBb7LbkZW5AD08BKwG3xE4Elvz2yPmoribMg== Date: Fri, 28 Jun 2024 09:45:11 +0200 From: Miquel Raynal To: Jean-Michel Hautbois Cc: Geert Uytterhoeven , Richard Weinberger , Vignesh Raghavendra , Stefan Agner , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2 1/2] arch: m68k: Add definitions for flash NFC support Message-ID: <20240628094511.75cc9c78@xps-13> In-Reply-To: <20240627-upstream-nfc-mcf5441x-v2-1-312929d09ee5@yoseli.org> References: <20240627-upstream-nfc-mcf5441x-v2-0-312929d09ee5@yoseli.org> <20240627-upstream-nfc-mcf5441x-v2-1-312929d09ee5@yoseli.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi Jean-Michel & Geert, jeanmichel.hautbois@yoseli.org wrote on Thu, 27 Jun 2024 18:05:28 +0200: > Add a few definitions, as the base address for the NFC for the M5441x. >=20 > Signed-off-by: Jean-Michel Hautbois > --- > arch/m68k/include/asm/m5441xsim.h | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/arch/m68k/include/asm/m5441xsim.h b/arch/m68k/include/asm/m5= 441xsim.h > index f48cf63bd782..d4ee1eab7c4a 100644 > --- a/arch/m68k/include/asm/m5441xsim.h > +++ b/arch/m68k/include/asm/m5441xsim.h > @@ -99,6 +99,7 @@ > #define MCFINT2_PIT1 14 > #define MCFINT2_PIT2 15 > #define MCFINT2_PIT3 16 > +#define MCFINT2_NFC 25 > #define MCFINT2_RTC 26 > =20 > /* > @@ -333,4 +334,10 @@ > #define MCF_IRQ_BOFF1 (MCFINT1_VECBASE + MCFINT1_FLEXCAN1_BOFF) > #define MCF_IRQ_ERR1 (MCFINT1_VECBASE + MCFINT1_FLEXCAN1_ERR) > =20 > +/* > + * Flash module > + */ > +#define MCF_NFC_BASE 0xfc0fc000 > +#define MCF_NFC_SIZE (0xfc0fff3b - 0xfc0fc000) > +#define MCF_NFC_ISR (MCFINT2_VECBASE + MCFINT2_NFC) I'm sorry but this feels really backwards. Platform data as C structures are already legacy, but defining these information in some arch headers and using them directly from drivers really seems even "wronger" to me. What's the mid/long term plan for this? If the platforms are still in use today and need to be maintained, why not finally enabling device tree support? I know it's harder to do than to say, but I'd like some really good explanation on why we should accept to do this in 2024 because it feels rather inadequate. Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1821C41513 for ; Fri, 28 Jun 2024 07:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IwQK8+bDTgX9Ps+ZjmtwUiPohT2ouSie/pygjA7EwCA=; b=r75709haTpeB5N jB9Dh1kAszVRxrcmNzqrhKd9ysreTfsXEFu9uf6KJYmscShnnmFdS4fG24Lkmn6kWjjlBuJ0ORHOX fJZrzih1JvyqsDDzAn3gGDlyDSkL/mpeBLZ+8X7J45mTI8DQ8i4D6KeqB6jsmsqnARnt5fPWTrlC7 X9W02PFkGZqYD4h0xvBCIcSNCbmfEDK/dQanMErzc2crTCq+5oK6R1RbLa88CIrOGqtVa150Fe+sc lCcYS019u2euM+Baz9Vl2/xtw78fDbLUGyuYC9+3FdrEDyw2U9F6T6vnmTe6f+mvAEuK8ueDv3KnS uuDIjnDAiLb2or2JkVjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN6IO-0000000Cvts-2e3f; Fri, 28 Jun 2024 07:45:24 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN6IL-0000000Cvsn-0Gt9 for linux-mtd@lists.infradead.org; Fri, 28 Jun 2024 07:45:23 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 9CAD4FF806; Fri, 28 Jun 2024 07:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1719560713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EnuubegvOe+sUBWqClTh59X4+t4oNOFvsmld2Nx+GdI=; b=JL+7kUq13ClciI3OamkaMysFgmgNGEERBYxpXrO2adYuf/gUI3RIrOFzYRPtZwceRkde3m JHmKlgnnbe2cIq7Wcr/Q7mIGRpCvTOh87V74s+zQGTgHnEkqjU76kVAEsydKOV7mZ2mOgh TQJ4lMMJOZJKfOR1aRzqHSY1FfdN2OWuwaMCu2NV5xLO2xlAhpbgn+JqmHpt38v3F69kvW p5AyenYDHk7oEEiwkzeksDztOHaEZ6mq6ZT5L7fSQS7YVR9uJNvs18PFcupXBPauDjWhIo /3c8fw/OhM6b0Z4SXnpXhYR4q4WBb7LbkZW5AD08BKwG3xE4Elvz2yPmoribMg== Date: Fri, 28 Jun 2024 09:45:11 +0200 From: Miquel Raynal To: Jean-Michel Hautbois Cc: Geert Uytterhoeven , Richard Weinberger , Vignesh Raghavendra , Stefan Agner , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2 1/2] arch: m68k: Add definitions for flash NFC support Message-ID: <20240628094511.75cc9c78@xps-13> In-Reply-To: <20240627-upstream-nfc-mcf5441x-v2-1-312929d09ee5@yoseli.org> References: <20240627-upstream-nfc-mcf5441x-v2-0-312929d09ee5@yoseli.org> <20240627-upstream-nfc-mcf5441x-v2-1-312929d09ee5@yoseli.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_004521_404637_4C4208D1 X-CRM114-Status: GOOD ( 15.48 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgSmVhbi1NaWNoZWwgJiBHZWVydCwKCmplYW5taWNoZWwuaGF1dGJvaXNAeW9zZWxpLm9yZyB3 cm90ZSBvbiBUaHUsIDI3IEp1biAyMDI0IDE4OjA1OjI4ICswMjAwOgoKPiBBZGQgYSBmZXcgZGVm aW5pdGlvbnMsIGFzIHRoZSBiYXNlIGFkZHJlc3MgZm9yIHRoZSBORkMgZm9yIHRoZSBNNTQ0MXgu Cj4gCj4gU2lnbmVkLW9mZi1ieTogSmVhbi1NaWNoZWwgSGF1dGJvaXMgPGplYW5taWNoZWwuaGF1 dGJvaXNAeW9zZWxpLm9yZz4KPiAtLS0KPiAgYXJjaC9tNjhrL2luY2x1ZGUvYXNtL201NDQxeHNp bS5oIHwgNyArKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKPiAKPiBk aWZmIC0tZ2l0IGEvYXJjaC9tNjhrL2luY2x1ZGUvYXNtL201NDQxeHNpbS5oIGIvYXJjaC9tNjhr L2luY2x1ZGUvYXNtL201NDQxeHNpbS5oCj4gaW5kZXggZjQ4Y2Y2M2JkNzgyLi5kNGVlMWVhYjdj NGEgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9tNjhrL2luY2x1ZGUvYXNtL201NDQxeHNpbS5oCj4gKysr IGIvYXJjaC9tNjhrL2luY2x1ZGUvYXNtL201NDQxeHNpbS5oCj4gQEAgLTk5LDYgKzk5LDcgQEAK PiAgI2RlZmluZSBNQ0ZJTlQyX1BJVDEJCTE0Cj4gICNkZWZpbmUgTUNGSU5UMl9QSVQyCQkxNQo+ ICAjZGVmaW5lIE1DRklOVDJfUElUMwkJMTYKPiArI2RlZmluZSBNQ0ZJTlQyX05GQwkJMjUKPiAg I2RlZmluZSBNQ0ZJTlQyX1JUQwkJMjYKPiAgCj4gIC8qCj4gQEAgLTMzMyw0ICszMzQsMTAgQEAK PiAgI2RlZmluZSBNQ0ZfSVJRX0JPRkYxCQkoTUNGSU5UMV9WRUNCQVNFICsgTUNGSU5UMV9GTEVY Q0FOMV9CT0ZGKQo+ICAjZGVmaW5lIE1DRl9JUlFfRVJSMQkJKE1DRklOVDFfVkVDQkFTRSArIE1D RklOVDFfRkxFWENBTjFfRVJSKQo+ICAKPiArLyoKPiArICogRmxhc2ggbW9kdWxlCj4gKyAqLwo+ ICsjZGVmaW5lIE1DRl9ORkNfQkFTRQkJMHhmYzBmYzAwMAo+ICsjZGVmaW5lIE1DRl9ORkNfU0la RQkJKDB4ZmMwZmZmM2IgLSAweGZjMGZjMDAwKQo+ICsjZGVmaW5lIE1DRl9ORkNfSVNSCQkoTUNG SU5UMl9WRUNCQVNFICsgTUNGSU5UMl9ORkMpCgpJJ20gc29ycnkgYnV0IHRoaXMgZmVlbHMgcmVh bGx5IGJhY2t3YXJkcy4gUGxhdGZvcm0gZGF0YSBhcyBDCnN0cnVjdHVyZXMgYXJlIGFscmVhZHkg bGVnYWN5LCBidXQgZGVmaW5pbmcgdGhlc2UgaW5mb3JtYXRpb24gaW4Kc29tZSBhcmNoIGhlYWRl cnMgYW5kIHVzaW5nIHRoZW0gZGlyZWN0bHkgZnJvbSBkcml2ZXJzIHJlYWxseSBzZWVtcwpldmVu ICJ3cm9uZ2VyIiB0byBtZS4gV2hhdCdzIHRoZSBtaWQvbG9uZyB0ZXJtIHBsYW4gZm9yIHRoaXM/ IElmIHRoZQpwbGF0Zm9ybXMgYXJlIHN0aWxsIGluIHVzZSB0b2RheSBhbmQgbmVlZCB0byBiZSBt YWludGFpbmVkLCB3aHkgbm90CmZpbmFsbHkgZW5hYmxpbmcgZGV2aWNlIHRyZWUgc3VwcG9ydD8g SSBrbm93IGl0J3MgaGFyZGVyIHRvIGRvIHRoYW4gdG8Kc2F5LCBidXQgSSdkIGxpa2Ugc29tZSBy ZWFsbHkgZ29vZCBleHBsYW5hdGlvbiBvbiB3aHkgd2Ugc2hvdWxkIGFjY2VwdAp0byBkbyB0aGlz IGluIDIwMjQgYmVjYXVzZSBpdCBmZWVscyByYXRoZXIgaW5hZGVxdWF0ZS4KClRoYW5rcywKTWlx dcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K