From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B56E9C2BD09 for ; Fri, 28 Jun 2024 12:41:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7DF88417C5; Fri, 28 Jun 2024 12:41:26 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id yjNUaIBDJYF7; Fri, 28 Jun 2024 12:41:25 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B674F41A8A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1719578485; bh=bGI5kI1dZO+9WD+QKVBmyREjDp/LmO9uo4EDXSRNNuI=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=3mYwMl14DuV+F3Zrz2aSSqW23HmPNuGsQ56g/3mswZUPH8SFNxtplR89N9BVLKJkx FqcQX5l6Q8qS/XCBzgQtnUIw2UuUdDZwspHps2eOGkmPz0btam7YOKvpLZN17hKDNd JKzP+Ke/2hAF1ltdr4dc8+Lqb7yAldiYKUuqK4p7BwUt9XbzHjn3Fd3V8ThxRZQ0EV /mq3aw7yN8fFyZyVu8sLhcM3929zhj4ncp5c4TP2enTY2kTEUKLP2oWgI9T7wmGfAd BfjQlo7237VHq8JZtrR96c9I050YS6YAKpQWRWfIAiIFabwmA/GnZYGx91OPXCGltV rONxzWDuNONww== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id B674F41A8A; Fri, 28 Jun 2024 12:41:25 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 6F2EA1BF41C for ; Fri, 28 Jun 2024 12:41:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5949F84537 for ; Fri, 28 Jun 2024 12:41:24 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 5H-H3Q5uu6p9 for ; Fri, 28 Jun 2024 12:41:23 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 80BAD83F1B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 80BAD83F1B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp1.osuosl.org (Postfix) with ESMTPS id 80BAD83F1B for ; Fri, 28 Jun 2024 12:41:23 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 13811CE3C40; Fri, 28 Jun 2024 12:41:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AB53C32781; Fri, 28 Jun 2024 12:41:16 +0000 (UTC) Date: Fri, 28 Jun 2024 13:41:14 +0100 From: Simon Horman To: Marcin Szycik Message-ID: <20240628124114.GB783093@kernel.org> References: <20240618141157.1881093-1-marcin.szycik@linux.intel.com> <20240618141157.1881093-3-marcin.szycik@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240618141157.1881093-3-marcin.szycik@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719578477; bh=a6Qym+vvVigvz9wSCKdjQVjJh+CINPYOgGV9UfvA0zE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uh10G45hZiThZvzPGOU88G5I/B5W8k633WgvCJVczL9PP/6JcPzGbjhNSXxAihSdr lWeiFIkd6Zk8/3IGCI++D864Rv+/EUptutOKoBEjrnf19EA4FxTo5rmG5t+R3N3rR6 6AfhW3xh4PPZi065JQ2tjZbjV76dbkUIJhiczK9OHofuoZ51ZDPd7/aY2IkFHty/ok GjohtU8+yShZ6cAj/rINxeEU7lA80b+H+65m7GsWFHd3bflB9cAbip4mqZsiNNaK3u zcPZ8d0GIbEbmR29cfw6KZhwltc9bAqiaWHjvm2zPnqKeTA/7aQyqXCsTYok3INF+t qlLEQzjc5fbCQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Uh10G45h Subject: Re: [Intel-wired-lan] [PATCH iwl-next 2/6] ice: Remove reading all recipes before adding a new one X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com, michal.swiatkowski@linux.intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Jun 18, 2024 at 04:11:53PM +0200, Marcin Szycik wrote: > From: Michal Swiatkowski > > The content of the first read recipe is used as a template when adding a > recipe. It isn't needed - only prune index is directly set from there. Set > it in the code instead. Also, now there's no need to set rid and lookup > indexes to 0, as the whole recipe buffer is initialized to 0. > > Signed-off-by: Michal Swiatkowski > Reviewed-by: Przemek Kitszel > Signed-off-by: Marcin Szycik Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C539C1586D3 for ; Fri, 28 Jun 2024 12:41:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719578477; cv=none; b=gSDP9fx28bMUA24zCZgMXkk2O0yb/X6G8gTFQceQhep6NqESgIT8+db4iYZb0BtlUm4kIEB5DrwPVweefF/z28qJREGaz1KAxN/mqz0gRRW5rozed9Uo2SUuBmI1utr1S/8rijf16cuUCEX28Jig0WXu4V33i8IhDigMyjc2bxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719578477; c=relaxed/simple; bh=a6Qym+vvVigvz9wSCKdjQVjJh+CINPYOgGV9UfvA0zE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IkGgH+/gFUU5TYHBw6UarVqS3hLJ+FfNQNagtQ3xvkeZH9KWQC3S+o5XAERRLuxCYU1wZKjX7WK4Z0EE0uFs2jgT8tig3RfPw9kUCieGm5cR9mUKtsVqiyIEqB6CVE6cZE1jNLyiFoaFCLaQApzPG+QFoeZ4cJ7Of5/mR1zH/iQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Uh10G45h; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Uh10G45h" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AB53C32781; Fri, 28 Jun 2024 12:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719578477; bh=a6Qym+vvVigvz9wSCKdjQVjJh+CINPYOgGV9UfvA0zE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uh10G45hZiThZvzPGOU88G5I/B5W8k633WgvCJVczL9PP/6JcPzGbjhNSXxAihSdr lWeiFIkd6Zk8/3IGCI++D864Rv+/EUptutOKoBEjrnf19EA4FxTo5rmG5t+R3N3rR6 6AfhW3xh4PPZi065JQ2tjZbjV76dbkUIJhiczK9OHofuoZ51ZDPd7/aY2IkFHty/ok GjohtU8+yShZ6cAj/rINxeEU7lA80b+H+65m7GsWFHd3bflB9cAbip4mqZsiNNaK3u zcPZ8d0GIbEbmR29cfw6KZhwltc9bAqiaWHjvm2zPnqKeTA/7aQyqXCsTYok3INF+t qlLEQzjc5fbCQ== Date: Fri, 28 Jun 2024 13:41:14 +0100 From: Simon Horman To: Marcin Szycik Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, michal.swiatkowski@linux.intel.com, przemyslaw.kitszel@intel.com Subject: Re: [PATCH iwl-next 2/6] ice: Remove reading all recipes before adding a new one Message-ID: <20240628124114.GB783093@kernel.org> References: <20240618141157.1881093-1-marcin.szycik@linux.intel.com> <20240618141157.1881093-3-marcin.szycik@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240618141157.1881093-3-marcin.szycik@linux.intel.com> On Tue, Jun 18, 2024 at 04:11:53PM +0200, Marcin Szycik wrote: > From: Michal Swiatkowski > > The content of the first read recipe is used as a template when adding a > recipe. It isn't needed - only prune index is directly set from there. Set > it in the code instead. Also, now there's no need to set rid and lookup > indexes to 0, as the whole recipe buffer is initialized to 0. > > Signed-off-by: Michal Swiatkowski > Reviewed-by: Przemek Kitszel > Signed-off-by: Marcin Szycik Reviewed-by: Simon Horman