From: kernel test robot <lkp@intel.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-media@vger.kernel.org,
Daniel Ferguson <danielf@os.amperecomputing.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Borislav Petkov <bp@alien8.de>,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
James Morse <james.morse@arm.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Len Brown <lenb@kernel.org>,
Shengwei Luo <luoshengwei@huawei.com>,
Shiju Jose <shiju.jose@huawei.com>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Tony Luck <tony.luck@intel.com>,
linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH 1/2] RAS: ACPI: APEI: add conditional compilation to ARM error report functions
Date: Fri, 28 Jun 2024 14:04:19 +0800 [thread overview]
Message-ID: <202406281337.j4rbN9nr-lkp@intel.com> (raw)
In-Reply-To: <95baa46a5e1c88f08e328dbbfbbd01602e092234.1719471257.git.mchehab+huawei@kernel.org>
Hi Mauro,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge linus/master v6.10-rc5 next-20240627]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mauro-Carvalho-Chehab/RAS-ACPI-APEI-add-conditional-compilation-to-ARM-error-report-functions/20240627-225843
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/95baa46a5e1c88f08e328dbbfbbd01602e092234.1719471257.git.mchehab%2Bhuawei%40kernel.org
patch subject: [PATCH 1/2] RAS: ACPI: APEI: add conditional compilation to ARM error report functions
config: x86_64-randconfig-161-20240628 (https://download.01.org/0day-ci/archive/20240628/202406281337.j4rbN9nr-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240628/202406281337.j4rbN9nr-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406281337.j4rbN9nr-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/acpi/apei/ghes.c:575:9: error: use of undeclared identifier 'queued'
575 | return queued;
| ^
1 error generated.
vim +/queued +575 drivers/acpi/apei/ghes.c
7f17b4a121d0d5 James Morse 2020-05-01 530
a70297d2213253 Shuai Xue 2023-12-18 531 static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata,
a70297d2213253 Shuai Xue 2023-12-18 532 int sev, bool sync)
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 533 {
4a485d7f807462 Daniel Ferguson 2024-06-27 534 #if defined(CONFIG_ARM) || defined (CONFIG_ARM64)
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 535 struct cper_sec_proc_arm *err = acpi_hest_get_payload(gdata);
a70297d2213253 Shuai Xue 2023-12-18 536 int flags = sync ? MF_ACTION_REQUIRED : 0;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 537 bool queued = false;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 538 int sec_sev, i;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 539 char *p;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 540
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 541 log_arm_hw_error(err);
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 542
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 543 sec_sev = ghes_severity(gdata->error_severity);
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 544 if (sev != GHES_SEV_RECOVERABLE || sec_sev != GHES_SEV_RECOVERABLE)
7f17b4a121d0d5 James Morse 2020-05-01 545 return false;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 546
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 547 p = (char *)(err + 1);
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 548 for (i = 0; i < err->err_info_num; i++) {
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 549 struct cper_arm_err_info *err_info = (struct cper_arm_err_info *)p;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 550 bool is_cache = (err_info->type == CPER_ARM_CACHE_ERROR);
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 551 bool has_pa = (err_info->validation_bits & CPER_ARM_INFO_VALID_PHYSICAL_ADDR);
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 552 const char *error_type = "unknown error";
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 553
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 554 /*
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 555 * The field (err_info->error_info & BIT(26)) is fixed to set to
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 556 * 1 in some old firmware of HiSilicon Kunpeng920. We assume that
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 557 * firmware won't mix corrected errors in an uncorrected section,
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 558 * and don't filter out 'corrected' error here.
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 559 */
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 560 if (is_cache && has_pa) {
a70297d2213253 Shuai Xue 2023-12-18 561 queued = ghes_do_memory_failure(err_info->physical_fault_addr, flags);
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 562 p += err_info->length;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 563 continue;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 564 }
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 565
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 566 if (err_info->type < ARRAY_SIZE(cper_proc_error_type_strs))
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 567 error_type = cper_proc_error_type_strs[err_info->type];
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 568
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 569 pr_warn_ratelimited(FW_WARN GHES_PFX
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 570 "Unhandled processor error type: %s\n",
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 571 error_type);
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 572 p += err_info->length;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 573 }
4a485d7f807462 Daniel Ferguson 2024-06-27 574 #endif
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 @575 return queued;
cf870c70a19444 Naveen N. Rao 2013-07-10 576 }
cf870c70a19444 Naveen N. Rao 2013-07-10 577
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-06-28 6:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 7:01 [PATCH 0/2] Add other fields to ARM trace event Mauro Carvalho Chehab
2024-06-27 7:01 ` [PATCH 1/2] RAS: ACPI: APEI: add conditional compilation to ARM error report functions Mauro Carvalho Chehab
2024-06-27 7:50 ` Borislav Petkov
2024-06-27 10:31 ` Mauro Carvalho Chehab
2024-06-28 4:46 ` kernel test robot
2024-06-28 6:04 ` kernel test robot [this message]
2024-06-27 7:01 ` [PATCH 2/2] RAS: Report all ARM processor CPER information to userspace Mauro Carvalho Chehab
2024-06-28 5:41 ` kernel test robot
2024-06-28 9:52 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202406281337.j4rbN9nr-lkp@intel.com \
--to=lkp@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=danielf@os.amperecomputing.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luoshengwei@huawei.com \
--cc=mchehab@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=shiju.jose@huawei.com \
--cc=tony.luck@intel.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.