From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH v2 11/13] ata: libata-core: Reuse available ata_port print_ids
Date: Sat, 29 Jun 2024 02:41:47 +0800 [thread overview]
Message-ID: <202406290221.VULCV6Lt-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240626180031.4050226-26-cassel@kernel.org>
References: <20240626180031.4050226-26-cassel@kernel.org>
TO: Niklas Cassel <cassel@kernel.org>
TO: Damien Le Moal <dlemoal@kernel.org>
TO: Niklas Cassel <cassel@kernel.org>
CC: linux-scsi@vger.kernel.org
CC: John Garry <john.g.garry@oracle.com>
CC: Jason Yan <yanaijie@huawei.com>
CC: "Martin K. Petersen" <martin.petersen@oracle.com>
CC: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
CC: linux-ide@vger.kernel.org
Hi Niklas,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.10-rc5 next-20240627]
[cannot apply to mkp-scsi/for-next jejb-scsi/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Niklas-Cassel/ata-libata-core-Fix-null-pointer-dereference-on-error/20240627-123023
base: linus/master
patch link: https://lore.kernel.org/r/20240626180031.4050226-26-cassel%40kernel.org
patch subject: [PATCH v2 11/13] ata: libata-core: Reuse available ata_port print_ids
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: x86_64-randconfig-101-20240628 (https://download.01.org/0day-ci/archive/20240629/202406290221.VULCV6Lt-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202406290221.VULCV6Lt-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/ata/libata-core.c:5467:5-17: WARNING: Unsigned expression compared with zero: ap -> print_id < 0
vim +5467 drivers/ata/libata-core.c
4fb37a25b976e8 drivers/ata/libata-core.c Tejun Heo 2007-08-06 5443
^1da177e4c3f41 drivers/scsi/libata-core.c Linus Torvalds 2005-04-16 5444 /**
f31871951b38da drivers/ata/libata-core.c Tejun Heo 2007-04-17 5445 * ata_port_alloc - allocate and initialize basic ATA port resources
f31871951b38da drivers/ata/libata-core.c Tejun Heo 2007-04-17 5446 * @host: ATA host this allocated port belongs to
^1da177e4c3f41 drivers/scsi/libata-core.c Linus Torvalds 2005-04-16 5447 *
f31871951b38da drivers/ata/libata-core.c Tejun Heo 2007-04-17 5448 * Allocate and initialize basic ATA port resources.
f31871951b38da drivers/ata/libata-core.c Tejun Heo 2007-04-17 5449 *
f31871951b38da drivers/ata/libata-core.c Tejun Heo 2007-04-17 5450 * RETURNS:
f31871951b38da drivers/ata/libata-core.c Tejun Heo 2007-04-17 5451 * Allocate ATA port on success, NULL on failure.
0cba632b737fc2 drivers/scsi/libata-core.c Jeff Garzik 2005-05-30 5452 *
^1da177e4c3f41 drivers/scsi/libata-core.c Linus Torvalds 2005-04-16 5453 * LOCKING:
f31871951b38da drivers/ata/libata-core.c Tejun Heo 2007-04-17 5454 * Inherited from calling layer (may sleep).
^1da177e4c3f41 drivers/scsi/libata-core.c Linus Torvalds 2005-04-16 5455 */
f31871951b38da drivers/ata/libata-core.c Tejun Heo 2007-04-17 5456 struct ata_port *ata_port_alloc(struct ata_host *host)
^1da177e4c3f41 drivers/scsi/libata-core.c Linus Torvalds 2005-04-16 5457 {
f31871951b38da drivers/ata/libata-core.c Tejun Heo 2007-04-17 5458 struct ata_port *ap;
^1da177e4c3f41 drivers/scsi/libata-core.c Linus Torvalds 2005-04-16 5459
f31871951b38da drivers/ata/libata-core.c Tejun Heo 2007-04-17 5460 ap = kzalloc(sizeof(*ap), GFP_KERNEL);
f31871951b38da drivers/ata/libata-core.c Tejun Heo 2007-04-17 5461 if (!ap)
f31871951b38da drivers/ata/libata-core.c Tejun Heo 2007-04-17 5462 return NULL;
f31871951b38da drivers/ata/libata-core.c Tejun Heo 2007-04-17 5463
7b3a24c57d2eed drivers/ata/libata-core.c Maxime Bizon 2011-03-16 5464 ap->pflags |= ATA_PFLAG_INITIALIZING | ATA_PFLAG_FROZEN;
cca3974e48607c drivers/ata/libata-core.c Jeff Garzik 2006-08-24 5465 ap->lock = &host->lock;
94908a6170de20 drivers/ata/libata-core.c Niklas Cassel 2024-06-26 5466 ap->print_id = ida_alloc_min(&ata_ida, 1, GFP_KERNEL);
94908a6170de20 drivers/ata/libata-core.c Niklas Cassel 2024-06-26 @5467 if (ap->print_id < 0) {
94908a6170de20 drivers/ata/libata-core.c Niklas Cassel 2024-06-26 5468 kfree(ap);
94908a6170de20 drivers/ata/libata-core.c Niklas Cassel 2024-06-26 5469 return NULL;
94908a6170de20 drivers/ata/libata-core.c Niklas Cassel 2024-06-26 5470 }
cca3974e48607c drivers/ata/libata-core.c Jeff Garzik 2006-08-24 5471 ap->host = host;
f31871951b38da drivers/ata/libata-core.c Tejun Heo 2007-04-17 5472 ap->dev = host->dev;
bd5d825c9434b8 drivers/scsi/libata-core.c Borislav Petkov 2006-06-11 5473
ad72cf9885c536 drivers/ata/libata-core.c Tejun Heo 2010-07-02 5474 mutex_init(&ap->scsi_scan_mutex);
65f27f38446e19 drivers/ata/libata-core.c David Howells 2006-11-22 5475 INIT_DELAYED_WORK(&ap->hotplug_task, ata_scsi_hotplug);
6aa0365a3c8512 drivers/ata/libata-core.c Damien Le Moal 2023-06-15 5476 INIT_DELAYED_WORK(&ap->scsi_rescan_task, ata_scsi_dev_rescan);
a72ec4ce6d3ae9 drivers/scsi/libata-core.c Tejun Heo 2006-01-23 5477 INIT_LIST_HEAD(&ap->eh_done_q);
c6cf9e99d1de5c drivers/scsi/libata-core.c Tejun Heo 2006-05-31 5478 init_waitqueue_head(&ap->eh_wait_q);
45fabbb77bd95a drivers/ata/libata-core.c Elias Oltmanns 2008-09-21 5479 init_completion(&ap->park_req_pending);
b93ab338f7f0e3 drivers/ata/libata-core.c Kees Cook 2017-10-16 5480 timer_setup(&ap->fastdrain_timer, ata_eh_fastdrain_timerfn,
b93ab338f7f0e3 drivers/ata/libata-core.c Kees Cook 2017-10-16 5481 TIMER_DEFERRABLE);
^1da177e4c3f41 drivers/scsi/libata-core.c Linus Torvalds 2005-04-16 5482
838df6284c5444 drivers/scsi/libata-core.c Tejun Heo 2006-05-15 5483 ap->cbl = ATA_CBL_NONE;
838df6284c5444 drivers/scsi/libata-core.c Tejun Heo 2006-05-15 5484
8989805d6d176a drivers/ata/libata-core.c Tejun Heo 2007-08-06 5485 ata_link_init(ap, &ap->link, 0);
^1da177e4c3f41 drivers/scsi/libata-core.c Linus Torvalds 2005-04-16 5486
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-06-28 18:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 18:41 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-06-26 18:00 [PATCH v2 00/13] ata,libsas: Assign the unique id used for printing earlier Niklas Cassel
2024-06-26 18:00 ` [PATCH v2 11/13] ata: libata-core: Reuse available ata_port print_ids Niklas Cassel
2024-06-27 1:37 ` Damien Le Moal
2024-07-02 15:43 ` Niklas Cassel
2024-06-27 6:39 ` Hannes Reinecke
2024-06-28 16:31 ` kernel test robot
2024-06-28 18:15 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202406290221.VULCV6Lt-lkp@intel.com \
--to=lkp@intel.com \
--cc=julia.lawall@inria.fr \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.