All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: io_opt fixups
Date: Mon,  1 Jul 2024 07:17:49 +0200	[thread overview]
Message-ID: <20240701051800.1245240-1-hch@lst.de> (raw)

Hi all,

I recently noticed that on my test VMs with the Qemu NVMe emulations I
see a zero max_setors_kb limit in sysfs.  It turns out Qemu advertises
a one-LBA optimal write size, which is a bit silly.

This series handles this odd case properly both in the block layer and
the nvme driver as a sort of defense in depth.

Diffstat:
 block/blk-settings.c     |    5 ++---
 drivers/nvme/host/core.c |    3 ++-
 2 files changed, 4 insertions(+), 4 deletions(-)

             reply	other threads:[~2024-07-01  5:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240701073115epcas5p3e2758375e272cba80281fe0ac37394d0@epcas5p3.samsung.com>
2024-07-01  5:17 ` Christoph Hellwig [this message]
2024-07-01  5:17   ` [PATCH 1/3] block: remove a duplicate io_min check in blk_validate_limits Christoph Hellwig
2024-07-01  6:37     ` Chaitanya Kulkarni
2024-07-01  7:06     ` Sagi Grimberg
2024-07-01  5:17   ` [PATCH 2/3] block: don't reduce max_sectors based on io_opt Christoph Hellwig
2024-07-01  6:42     ` Chaitanya Kulkarni
2024-07-01  7:08     ` Sagi Grimberg
2024-07-01  5:17   ` [PATCH 3/3] nvme: don't set io_opt if NOWS is zero Christoph Hellwig
2024-07-01  7:02     ` Chaitanya Kulkarni
2024-07-01  7:08     ` Sagi Grimberg
2024-07-01 13:55     ` Keith Busch
2024-07-01 15:11       ` Christoph Hellwig
2024-07-01  7:24   ` io_opt fixups Nitesh Shetty
2024-07-01 10:22   ` Johannes Thumshirn
2024-07-01 12:53   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240701051800.1245240-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=martin.petersen@oracle.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.