From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F9F1C30653 for ; Mon, 1 Jul 2024 08:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KB3ioG2gYFQvbftzKh8+ZXBPkhLzEgr6e3G+XTF1aTU=; b=ThmPaLbjhnuuyK1AvOnDLHczwF A8379Jho8gZuI6e7bVOZTkROFwrUPDSFJitvk1iMlBiVzRd+cwfZJA6ifVhLbRKnZtJQwBeC3MSED SujQFCbA7P1GFuJxGnogjqwyVIdT8FJUXXjl5AYnsqofGCxy/2m/I5Vm7Hcyk6O3u4kviOomp7dDf Ul6u6u/0c3VZ7LeHLmGTslReqa2EyQCw5PElsfuKAqdeht+0VI4xLulYDdirbbotBGysbbbKizyBp 2hcyQG3Q7COW2SZYRQyrL5WunuaWkly8ElN352Iy+uu+uzPtDhetveTqACJ/dL4amYjfvT3Neu7Xj SyZ11CZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOCsy-00000002MEy-3rMP; Mon, 01 Jul 2024 08:59:44 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOCsn-00000002M9M-0Yk8 for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2024 08:59:35 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WCKht6xwfz6J9nb; Mon, 1 Jul 2024 16:58:54 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 5DFEF140A30; Mon, 1 Jul 2024 16:59:27 +0800 (CST) Received: from localhost (10.203.174.77) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 1 Jul 2024 09:59:26 +0100 Date: Mon, 1 Jul 2024 09:59:26 +0100 From: Jonathan Cameron To: Gavin Shan CC: , , , , , Subject: Re: [PATCH for-next/vcpu-hotplug] arm64: Kconfig: Fix dependencies to enable ACPI_HOTPLUG_CPU Message-ID: <20240701095926.00003d7a@Huawei.com> In-Reply-To: <20240701001132.1585153-1-gshan@redhat.com> References: <20240701001132.1585153-1-gshan@redhat.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.203.174.77] X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_015933_397729_51A7A692 X-CRM114-Status: GOOD ( 15.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 1 Jul 2024 10:11:32 +1000 Gavin Shan wrote: > Both ACPI_PROCESSOR and HOTPLUG_CPU are needed by ACPI_HOTPLUG_CPU. > Otherwise, we can have compiling error with the following configurations. >=20 > CONFIG_HOTPLUG_CPU=3Dn > CONFIG_ACPI_PROCESSOR=3Dy > CONFIG_ACPI_HOTPLUG_CPU=3Dy >=20 > arch/arm64/kernel/smp.c: In function =E2=80=98arch_unregister_cpu=E2=80= =99: > arch/arm64/kernel/smp.c:563:9: error: implicit declaration of \ > function =E2=80=98unregister_cpu=E2=80=99; did you mean =E2=80=98regist= er_cpu=E2=80=99? \ > [-Werror=3Dimplicit-function-declaration] > 563 | unregister_cpu(c); > | ^~~~~~~~~~~~~~ > | register_cpu >=20 > Fix it by enabling ACPI_HOTPLUG_CPU when both ACPI_PROCESSOR and > HOTPLUG_CPU are enabled, consistent with other architectures like > x86 and loongarch. >=20 > Fixes: 9d0873892f4d ("arm64: Kconfig: Enable hotplug CPU on arm64 if ACPI= _PROCESSOR is enabled.") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202406300437.XnuW0n34-lkp@i= ntel.com/ > Signed-off-by: Gavin Shan Thanks for the quick analysis and patch! Acked-by: Jonathan Cameron > --- > arch/arm64/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index e8f2ef2312db..ff17c5705324 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -5,7 +5,7 @@ config ARM64 > select ACPI_CCA_REQUIRED if ACPI > select ACPI_GENERIC_GSI if ACPI > select ACPI_GTDT if ACPI > - select ACPI_HOTPLUG_CPU if ACPI_PROCESSOR > + select ACPI_HOTPLUG_CPU if ACPI_PROCESSOR && HOTPLUG_CPU > select ACPI_IORT if ACPI > select ACPI_REDUCED_HARDWARE_ONLY if ACPI > select ACPI_MCFG if (ACPI && PCI)