From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: <gupt21@gmail.com>, <jikos@kernel.org>, <bentiss@kernel.org>,
<matt@ranostay.sg>, <linux-i2c@vger.kernel.org>,
<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: mcp2221: Remove unneeded semicolon
Date: Mon, 1 Jul 2024 10:12:04 +0100 [thread overview]
Message-ID: <20240701101204.000065ca@Huawei.com> (raw)
In-Reply-To: <20240701071639.846169-1-nichen@iscas.ac.cn>
On Mon, 1 Jul 2024 15:16:39 +0800
Chen Ni <nichen@iscas.ac.cn> wrote:
> Remove unneeded semicolon.
> This is detected by coccinelle.
>
> Fixes: 960f9df7c620 ("HID: mcp2221: add ADC/DAC support via iio subsystem")
Fixes tag not appropriate for this one as it's not a bug.
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Otherwise looks fine to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/hid/hid-mcp2221.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c
> index da5ea5a23b08..0f93c22a479f 100644
> --- a/drivers/hid/hid-mcp2221.c
> +++ b/drivers/hid/hid-mcp2221.c
> @@ -1048,7 +1048,7 @@ static int mcp_iio_channels(struct mcp2221 *mcp)
> break;
> default:
> continue;
> - };
> + }
>
> chan->type = IIO_VOLTAGE;
> chan->indexed = 1;
next prev parent reply other threads:[~2024-07-08 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 7:16 [PATCH] HID: mcp2221: Remove unneeded semicolon Chen Ni
2024-07-01 9:12 ` Jonathan Cameron [this message]
2024-07-03 21:46 ` Andi Shyti
-- strict thread matches above, loose matches on Subject: below --
2023-06-27 8:34 baomingtong001
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701101204.000065ca@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=bentiss@kernel.org \
--cc=gupt21@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@ranostay.sg \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.