From: "Michael S. Tsirkin" <mst@redhat.com>
To: Roman Kiryanov <rkir@google.com>
Cc: virtio-dev@lists.linux.dev, JP Cottin <jpcottin@google.com>
Subject: Re: VIRTIO_VSOCK_OP_REQUEST with the same src_port from a guest
Date: Mon, 1 Jul 2024 14:44:27 -0400 [thread overview]
Message-ID: <20240701142831-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAOGAQepPkUDF8vmzRiG41xOGhFdDuq8-EHmdTrdVrK6E346G7A@mail.gmail.com>
On Mon, Jul 01, 2024 at 10:35:57AM -0700, Roman Kiryanov wrote:
> Hi virtio-dev,
>
> we (Android Studio Emulator) have our own implementation of
> virtio-vsock and we recently found that the virtio spec does not cover
> the situation if a guest sends a VIRTIO_VSOCK_OP_REQUEST packet with
> the same src_port that is already registered on the device side.
>
> This sounds like an error to me and I don't think I ever saw this
> happening, but it would be nice if the spec explicitly mentioned how
> this situation should be handled on the device side.
>
> The spec does mention "A VIRTIO_VSOCK_OP_RST reply is sent if ... the
> destination has insufficient resources to establish the connection",
> but I am not sure if this includes the duplicate src_port case. I
> think this means the previously established connection will be broken.
>
> Thank you.
>
> Regards,
> Roman.
Another way is just to forbid this from happening.
How does this happen on the driver side?
--
MST
next prev parent reply other threads:[~2024-07-01 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 17:35 VIRTIO_VSOCK_OP_REQUEST with the same src_port from a guest Roman Kiryanov
2024-07-01 18:44 ` Michael S. Tsirkin [this message]
2024-07-01 19:16 ` Roman Kiryanov
2024-07-01 19:40 ` Michael S. Tsirkin
2024-07-01 19:55 ` Roman Kiryanov
2024-07-01 21:01 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701142831-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jpcottin@google.com \
--cc=rkir@google.com \
--cc=virtio-dev@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.