From: Stephen Hemminger <stephen@networkplumber.org>
To: Chaoyong He <chaoyong.he@corigine.com>
Cc: dev@dpdk.org, oss-drivers@corigine.com,
Zerun Fu <zerun.fu@corigine.com>, Long Wu <long.wu@corigine.com>,
Peng Zhang <peng.zhang@corigine.com>
Subject: Re: [PATCH v5 1/3] bus/pci: rename the variable in UIO secondary map logic
Date: Mon, 1 Jul 2024 19:47:58 -0700 [thread overview]
Message-ID: <20240701194758.5f99fceb@hermes.local> (raw)
In-Reply-To: <20240702021946.4194102-2-chaoyong.he@corigine.com>
On Tue, 2 Jul 2024 10:19:44 +0800
Chaoyong He <chaoyong.he@corigine.com> wrote:
> - int fd, i, j;
> + int fd, i, map_idx;
> struct mapped_pci_resource *uio_res;
> struct mapped_pci_res_list *uio_res_list =
> RTE_TAILQ_CAST(rte_uio_tailq.head, mapped_pci_res_list);
> @@ -37,41 +37,41 @@ pci_uio_map_secondary(struct rte_pci_device *dev)
> if (rte_pci_addr_cmp(&uio_res->pci_addr, &dev->addr))
> continue;
>
> - for (i = 0; i != uio_res->nb_maps; i++) {
> + for (map_idx = 0; map_idx != uio_res->nb_maps; map_idx++) {
> /*
> * open devname, to mmap it
Renaming i to map_idx and j to i does not change anything and makes the change
harder to read.
next prev parent reply other threads:[~2024-07-02 2:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 10:45 [PATCH] bus/pci: fix secondary process PCI uio resource map problem Chaoyong He
2024-01-29 9:22 ` [PATCH v2 0/2] fix secondary process PCI UIO resource problem Chaoyong He
2024-01-29 9:22 ` [PATCH v2 1/2] bus/pci: fix secondary process PCI uio resource map problem Chaoyong He
2024-01-30 4:00 ` fengchengwen
2024-03-14 10:55 ` Burakov, Anatoly
2024-01-29 9:22 ` [PATCH v2 2/2] bus/pci: fix secondary process save 'FD' problem Chaoyong He
2024-01-30 6:16 ` fengchengwen
2024-03-14 11:01 ` Burakov, Anatoly
2024-03-11 6:42 ` [PATCH v2 0/2] fix secondary process PCI UIO resource problem Chaoyong He
2024-04-19 3:26 ` Chaoyong He
2024-04-19 3:26 ` [PATCH v3 1/2] bus/pci: fix secondary process PCI uio resource map problem Chaoyong He
2024-06-27 14:00 ` Thomas Monjalon
2024-06-28 1:03 ` Chaoyong He
2024-04-19 3:26 ` [PATCH v3 2/2] bus/pci: fix secondary process save 'FD' problem Chaoyong He
2024-06-28 7:36 ` [PATCH v4 0/3] fix secondary process PCI UIO resource problem Chaoyong He
2024-06-28 7:36 ` [PATCH v4 1/3] bus/pci: rename the variable in UIO secondary map logic Chaoyong He
2024-06-28 7:36 ` [PATCH v4 2/3] bus/pci: fix secondary process PCI uio resource map problem Chaoyong He
2024-06-28 7:36 ` [PATCH v4 3/3] bus/pci: fix secondary process save 'FD' problem Chaoyong He
2024-07-01 14:14 ` David Marchand
2024-07-02 1:53 ` Chaoyong He
2024-07-01 14:12 ` [PATCH v4 0/3] fix secondary process PCI UIO resource problem David Marchand
2024-07-02 2:19 ` [PATCH v5 " Chaoyong He
2024-07-02 2:19 ` [PATCH v5 1/3] bus/pci: rename the variable in UIO secondary map logic Chaoyong He
2024-07-02 2:47 ` Stephen Hemminger [this message]
2024-07-02 2:19 ` [PATCH v5 2/3] bus/pci: fix secondary process PCI uio resource map problem Chaoyong He
2024-07-02 2:19 ` [PATCH v5 3/3] bus/pci: fix secondary process save 'FD' problem Chaoyong He
2024-07-02 7:40 ` [PATCH v6 0/2] fix secondary process PCI UIO resource problem Chaoyong He
2024-07-02 7:40 ` [PATCH v6 1/2] bus/pci: fix secondary process PCI uio resource map problem Chaoyong He
2024-07-04 9:00 ` Chenbo Xia
2024-07-15 5:55 ` huangdengdui
2024-07-02 7:40 ` [PATCH v6 2/2] bus/pci: fix secondary process save 'FD' problem Chaoyong He
2024-07-12 17:30 ` David Marchand
2024-07-15 2:24 ` Chenbo Xia
2024-07-02 9:28 ` [PATCH v6 0/2] fix secondary process PCI UIO resource problem David Marchand
2024-07-23 9:01 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701194758.5f99fceb@hermes.local \
--to=stephen@networkplumber.org \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=zerun.fu@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.