From: Simon Horman <horms@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: netdev@vger.kernel.org, nbd@nbd.name,
lorenzo.bianconi83@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
conor@kernel.org, linux-arm-kernel@lists.infradead.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com,
angelogioacchino.delregno@collabora.com,
benjamin.larsson@genexis.eu, rkannoth@marvell.com,
sgoutham@marvell.com, andrew@lunn.ch, arnd@arndb.de
Subject: Re: [PATCH v4 2/2] net: airoha: Introduce ethernet support for EN7581 SoC
Date: Tue, 2 Jul 2024 08:17:39 +0100 [thread overview]
Message-ID: <20240702071739.GA606788@kernel.org> (raw)
In-Reply-To: <56f57f37b80796e9706555503e5b4cf194f69479.1719672695.git.lorenzo@kernel.org>
On Sat, Jun 29, 2024 at 05:01:38PM +0200, Lorenzo Bianconi wrote:
...
> diff --git a/drivers/net/ethernet/mediatek/airoha_eth.c b/drivers/net/ethernet/mediatek/airoha_eth.c
...
> +#define INT_IDX4_MASK \
> + (TX8_COHERENT_INT_MASK | TX9_COHERENT_INT_MASK | \
> + TX10_COHERENT_INT_MASK | TX11_COHERENT_INT_MASK | \
> + TX12_COHERENT_INT_MASK | TX13_COHERENT_INT_MASK | \
> + TX14_COHERENT_INT_MASK | TX15_COHERENT_INT_MASK | \
> + TX16_COHERENT_INT_MASK | TX17_COHERENT_INT_MASK | \
> + TX18_COHERENT_INT_MASK | TX19_COHERENT_INT_MASK | \
> + TX20_COHERENT_INT_MASK | TX21_COHERENT_INT_MASK | \
> + TX20_COHERENT_INT_MASK | TX21_COHERENT_INT_MASK | \
Hi Lorenzo,
One more thing that I forgot to note yesterday:
the two lines above appear to be duplicates of each other.
Flagged by Coccinelle.
> + TX22_COHERENT_INT_MASK | TX23_COHERENT_INT_MASK | \
> + TX24_COHERENT_INT_MASK | TX25_COHERENT_INT_MASK | \
> + TX26_COHERENT_INT_MASK | TX27_COHERENT_INT_MASK | \
> + TX28_COHERENT_INT_MASK | TX29_COHERENT_INT_MASK | \
> + TX30_COHERENT_INT_MASK | TX31_COHERENT_INT_MASK)
...
next prev parent reply other threads:[~2024-07-02 7:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-29 15:01 [PATCH v4 0/2] Introduce EN7581 ethernet support Lorenzo Bianconi
2024-06-29 15:01 ` [PATCH v4 1/2] dt-bindings: net: airoha: Add EN7581 ethernet controller Lorenzo Bianconi
2024-07-01 18:21 ` Rob Herring
2024-07-02 9:01 ` Lorenzo Bianconi
2024-06-29 15:01 ` [PATCH v4 2/2] net: airoha: Introduce ethernet support for EN7581 SoC Lorenzo Bianconi
2024-07-01 13:53 ` Simon Horman
2024-07-01 14:26 ` Lorenzo Bianconi
2024-07-02 7:17 ` Simon Horman [this message]
2024-07-02 8:38 ` Lorenzo Bianconi
2024-07-03 11:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702071739.GA606788@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=benjamin.larsson@genexis.eu \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sgoutham@marvell.com \
--cc=upstream@airoha.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.