From: "Marek Behún" <kabel@kernel.org>
To: "Andrew Lunn" <andrew@lunn.ch>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org, arm@kernel.org,
"Andy Shevchenko" <andy@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Marek Behún" <kabel@kernel.org>
Subject: [PATCH v2 02/30] irqchip/armada-370-xp: Change register constant suffix from _MSK to _MASK
Date: Tue, 2 Jul 2024 13:42:34 +0200 [thread overview]
Message-ID: <20240702114302.22475-3-kabel@kernel.org> (raw)
In-Reply-To: <20240702114302.22475-1-kabel@kernel.org>
There is one occurrence of suffix _MSK in register constants, others
have _MASK instead. Change the one to _MASK for consistency.
Signed-off-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/irqchip/irq-armada-370-xp.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
index 66d6a2ebc8a5..588a9e2e1887 100644
--- a/drivers/irqchip/irq-armada-370-xp.c
+++ b/drivers/irqchip/irq-armada-370-xp.c
@@ -126,7 +126,7 @@
/* Registers relative to per_cpu_int_base */
#define ARMADA_370_XP_IN_DRBEL_CAUSE (0x08)
-#define ARMADA_370_XP_IN_DRBEL_MSK (0x0c)
+#define ARMADA_370_XP_IN_DRBEL_MASK (0x0c)
#define ARMADA_375_PPI_CAUSE (0x10)
#define ARMADA_370_XP_CPU_INTACK (0x44)
#define ARMADA_370_XP_INT_SET_MASK (0x48)
@@ -324,9 +324,9 @@ static void armada_370_xp_msi_reenable_percpu(void)
u32 reg;
/* Enable MSI doorbell mask and combined cpu local interrupt */
- reg = readl(per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MSK);
+ reg = readl(per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MASK);
reg |= msi_doorbell_mask();
- writel(reg, per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MSK);
+ writel(reg, per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MASK);
/* Unmask local doorbell interrupt */
writel(1, per_cpu_int_base + ARMADA_370_XP_INT_CLEAR_MASK);
@@ -394,17 +394,17 @@ static struct irq_domain *ipi_domain;
static void armada_370_xp_ipi_mask(struct irq_data *d)
{
u32 reg;
- reg = readl(per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MSK);
+ reg = readl(per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MASK);
reg &= ~BIT(d->hwirq);
- writel(reg, per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MSK);
+ writel(reg, per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MASK);
}
static void armada_370_xp_ipi_unmask(struct irq_data *d)
{
u32 reg;
- reg = readl(per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MSK);
+ reg = readl(per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MASK);
reg |= BIT(d->hwirq);
- writel(reg, per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MSK);
+ writel(reg, per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MASK);
}
static void armada_370_xp_ipi_send_mask(struct irq_data *d,
@@ -539,7 +539,7 @@ static void armada_xp_mpic_smp_cpu_init(void)
return;
/* Disable all IPIs */
- writel(0, per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MSK);
+ writel(0, per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MASK);
/* Clear pending IPIs */
writel(0, per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_CAUSE);
@@ -740,7 +740,7 @@ armada_370_xp_handle_irq(struct pt_regs *regs)
static int armada_370_xp_mpic_suspend(void)
{
- doorbell_mask_reg = readl(per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MSK);
+ doorbell_mask_reg = readl(per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MASK);
return 0;
}
@@ -785,7 +785,7 @@ static void armada_370_xp_mpic_resume(void)
/* Reconfigure doorbells for IPIs and MSIs */
writel(doorbell_mask_reg,
- per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MSK);
+ per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_MASK);
if (is_ipi_available()) {
src0 = doorbell_mask_reg & IPI_DOORBELL_MASK;
--
2.44.2
next prev parent reply other threads:[~2024-07-02 11:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 11:42 [PATCH v2 00/30] armada-370-xp irqchip updates round 2 Marek Behún
2024-07-02 11:42 ` [PATCH v2 01/30] irqchip/armada-370-xp: Drop _OFFS suffix from some register constants Marek Behún
2024-07-02 11:42 ` Marek Behún [this message]
2024-07-02 11:42 ` [PATCH v2 03/30] irqchip/armada-370-xp: Change spaces to tabs Marek Behún
2024-07-02 11:42 ` [PATCH v2 04/30] irqchip/armada-370-xp: Use BIT() and GENMASK() macros Marek Behún
2024-07-02 11:42 ` [PATCH v2 05/30] irqchip/armada-370-xp: Cosmetic fix parentheses in register constant definitions Marek Behún
2024-07-06 9:41 ` Ilpo Järvinen
2024-07-02 11:42 ` [PATCH v2 06/30] irqchip/armada-370-xp: Change register constants prefix to MPIC_ Marek Behún
2024-07-02 11:42 ` [PATCH v2 07/30] irqchip/armada-370-xp: Use correct type for cpu variable Marek Behún
2024-07-02 11:42 ` [PATCH v2 08/30] irqchip/armada-370-xp: Simplify is_percpu_irq() code Marek Behún
2024-07-06 9:42 ` Ilpo Järvinen
2024-07-02 11:42 ` [PATCH v2 09/30] irqchip/armada-370-xp: Change to SPDX license identifier Marek Behún
2024-07-02 11:42 ` [PATCH v2 10/30] irqchip/armada-370-xp: Declare iterators in for loop Marek Behún
2024-07-02 11:42 ` [PATCH v2 11/30] irqchip/armada-370-xp: Rename variable for consistency Marek Behún
2024-07-02 11:42 ` [PATCH v2 12/30] irqchip/armada-370-xp: Use unsigned int type for virqs Marek Behún
2024-07-02 11:42 ` [PATCH v2 13/30] irqchip/armada-370-xp: Use !virq instead of virq == 0 in condition Marek Behún
2024-07-02 11:42 ` [PATCH v2 14/30] irqchip/armada-370-xp: Simplify ipi_resume() code Marek Behún
2024-07-02 11:42 ` [PATCH v2 15/30] irqchip/armada-370-xp: Improve indentation Marek Behún
2024-07-02 11:42 ` [PATCH v2 16/30] irqchip/armada-370-xp: Change symbol prefixes to mpic Marek Behún
2024-07-02 11:42 ` [PATCH v2 17/30] irqchip/armada-370-xp: Don't read number of supported interrupts multiple times Marek Behún
2024-07-02 11:42 ` [PATCH v2 18/30] irqchip/armada-370-xp: Use FIELD_GET() and named register constant Marek Behún
2024-07-02 11:42 ` [PATCH v2 19/30] irqchip/armada-370-xp: Refactor mpic_handle_msi_irq() code Marek Behún
2024-07-02 11:42 ` [PATCH v2 20/30] irqchip/armada-370-xp: Refactor handling IPI interrupts Marek Behún
2024-07-02 11:42 ` [PATCH v2 21/30] irqchip/armada-370-xp: Use consistent variable names for hwirqs Marek Behún
2024-07-02 11:42 ` [PATCH v2 22/30] irqchip/armada-370-xp: Use consistent types when iterating interrupts Marek Behún
2024-07-02 11:42 ` [PATCH v2 23/30] irqchip/armada-370-xp: Use consistent name for struct irq_data variables Marek Behún
2024-07-02 11:42 ` [PATCH v2 24/30] irqchip/armada-370-xp: Simplify mpic_reenable_percpu() and mpic_resume() Marek Behún
2024-07-02 11:42 ` [PATCH v2 25/30] irqchip/armada-370-xp: Drop unneeded curly brackets Marek Behún
2024-07-02 11:42 ` [PATCH v2 26/30] irqchip/armada-370-xp: Drop redundant continue Marek Behún
2024-07-02 11:42 ` [PATCH v2 27/30] irqchip/armada-370-xp: Rename variable for consistency Marek Behún
2024-07-02 11:43 ` [PATCH v2 28/30] irqchip/armada-370-xp: Use u32 type instead of unsigned long where possieble Marek Behún
2024-07-02 11:43 ` [PATCH v2 29/30] irqchip/armada-370-xp: Refactor initial memory regions mapping Marek Behún
2024-07-02 11:43 ` [PATCH v2 30/30] irqchip/armada-370-xp: Print error and return error code on initialization failure Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702114302.22475-3-kabel@kernel.org \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=andy@kernel.org \
--cc=arm@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.