From: Kees Cook <kees@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: "GONG, Ruiqi" <gongruiqi@huaweicloud.com>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
jvoisin <julien.voisin@dustri.org>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Xiu Jianfeng <xiujianfeng@huawei.com>,
Suren Baghdasaryan <surenb@google.com>,
Kent Overstreet <kent.overstreet@linux.dev>,
Jann Horn <jannh@google.com>,
Matteo Rizzo <matteorizzo@google.com>,
Thomas Graf <tgraf@suug.ch>,
Herbert Xu <herbert@gondor.apana.org.au>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-hardening@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v6 4/6] mm/slab: Introduce kmem_buckets_create() and family
Date: Tue, 2 Jul 2024 13:11:50 -0700 [thread overview]
Message-ID: <202407021311.A594875FC6@keescook> (raw)
In-Reply-To: <5b8e6ddc-6472-4acd-a506-98bc3586f1f3@suse.cz>
On Tue, Jul 02, 2024 at 11:19:28AM +0200, Vlastimil Babka wrote:
> On 7/1/24 9:13 PM, Kees Cook wrote:
> > #ifdef SLAB_SUPPORTS_SYSFS
> > /*
> > * For a given kmem_cache, kmem_cache_destroy() should only be called
> > @@ -931,6 +1023,10 @@ void __init create_kmalloc_caches(void)
> >
> > /* Kmalloc array is now usable */
> > slab_state = UP;
> > +
> > + kmem_buckets_cache = kmem_cache_create("kmalloc_buckets",
> > + sizeof(kmem_buckets),
> > + 0, SLAB_NO_MERGE, NULL);
>
> Locally adjusted to put this behind "if (IS_ENABLED(CONFIG_SLAB_BUCKETS))"
Oops, yes, good catch. Thank you!
--
Kees Cook
next prev parent reply other threads:[~2024-07-02 20:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 19:12 [PATCH v6 0/6] slab: Introduce dedicated bucket allocator Kees Cook
2024-07-01 19:12 ` [PATCH v6 1/6] mm/slab: Introduce kmem_buckets typedef Kees Cook
2024-07-01 19:12 ` [PATCH v6 2/6] mm/slab: Plumb kmem_buckets into __do_kmalloc_node() Kees Cook
2024-07-01 19:13 ` [PATCH v6 3/6] mm/slab: Introduce kvmalloc_buckets_node() that can take kmem_buckets argument Kees Cook
2024-07-01 19:13 ` [PATCH v6 4/6] mm/slab: Introduce kmem_buckets_create() and family Kees Cook
2024-07-02 9:19 ` Vlastimil Babka
2024-07-02 20:11 ` Kees Cook [this message]
2024-07-01 19:13 ` [PATCH v6 5/6] ipc, msg: Use dedicated slab buckets for alloc_msg() Kees Cook
2024-07-01 19:13 ` [PATCH v6 6/6] mm/util: Use dedicated slab buckets for memdup_user() Kees Cook
2024-07-02 9:24 ` [PATCH v6 0/6] slab: Introduce dedicated bucket allocator Vlastimil Babka
2024-07-02 20:12 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202407021311.A594875FC6@keescook \
--to=kees@kernel.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=corbet@lwn.net \
--cc=gongruiqi@huaweicloud.com \
--cc=gustavoars@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=iamjoonsoo.kim@lge.com \
--cc=jannh@google.com \
--cc=julien.voisin@dustri.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matteorizzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=surenb@google.com \
--cc=tgraf@suug.ch \
--cc=vbabka@suse.cz \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.