All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Kanchan Joshi <joshi.k@samsung.com>,
	axboe@kernel.dk, martin.petersen@oracle.com, sagi@grimberg.me,
	linux-nvme@lists.infradead.org, bvanassche@acm.org,
	javier.gonz@samsung.com, gost.dev@samsung.com,
	Hui Qi <hui81.qi@samsung.com>,
	Nitesh Shetty <nj.shetty@samsung.com>
Subject: Re: [PATCH v3] nvme: enable FDP support
Date: Tue, 2 Jul 2024 17:36:31 +0200	[thread overview]
Message-ID: <20240702153631.GA534@lst.de> (raw)
In-Reply-To: <ZoQZelWxFIiG5u4h@kbusch-mbp>

On Tue, Jul 02, 2024 at 09:15:06AM -0600, Keith Busch wrote:
> My first concern for applying something like this is what kind of
> maintenance burdens does this create, or any potential harm to users who
> don't subscribe to the feature? Nothing here looks alarming to me, and
> there is a clear demand to be able to access these features like this.
> Maybe it works out for some workloads, maybe it doesn't, but I don't see
> a need to block this at this point.

We're just abusing the interface, and giving how badly designed and
intentionally Linux-hostile it was I see no point.

If Samsung and Meta care enough about good Linux I/O temperature hint
support we'll get what we want in the technical working group, please
help working on that!


  reply	other threads:[~2024-07-02 15:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240702103348epcas5p1015eafbddf4795558843cd74b0453b12@epcas5p1.samsung.com>
2024-07-02 10:26 ` [PATCH v3] nvme: enable FDP support Kanchan Joshi
2024-07-02 11:39   ` Christoph Hellwig
2024-07-02 15:15     ` Keith Busch
2024-07-02 15:36       ` Christoph Hellwig [this message]
2024-07-02 15:49         ` Jens Axboe
2024-07-02 15:51           ` Christoph Hellwig
2024-07-03  8:40     ` Kanchan Joshi
2024-07-03 15:08       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240702153631.GA534@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=gost.dev@samsung.com \
    --cc=hui81.qi@samsung.com \
    --cc=javier.gonz@samsung.com \
    --cc=joshi.k@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=martin.petersen@oracle.com \
    --cc=nj.shetty@samsung.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.