From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99277C3064D for ; Tue, 2 Jul 2024 08:47:06 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=I4BbERyB; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WCxNn1v5Kz30YZ for ; Tue, 2 Jul 2024 18:47:05 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=I4BbERyB; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WCxNg405mz2yGk for ; Tue, 2 Jul 2024 18:46:58 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B67566187C; Tue, 2 Jul 2024 08:46:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE1AAC116B1; Tue, 2 Jul 2024 08:46:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1719910015; bh=nfsWoIFE6Pa4xihovTkchnusfEahOB6iLDApDkfPdC0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I4BbERyBxiWcxDdV3nKfRvK35c1SSw18sVKi5DyniGcjnveREI3WH+uFqfo/fc+mc 8HZPeQxaoB6BHC97F9OvtGU7OrMeWKa1BWxZiscsYy4HChN87rcqxUlyZU1Jz8wbvJ 4Ig6mZC/uU53c+JlZrhcab3jrTmHHFxmD6bKpOCI= Date: Tue, 2 Jul 2024 10:46:52 +0200 From: Greg KH To: Gao Xiang Subject: Re: [PATCH v6.6] erofs: fix NULL dereference of dif->bdev_handle in fscache mode Message-ID: <2024070245-bleach-fountain-2018@gregkh> References: <20240627091345.3569167-1-lihongbo22@huawei.com> <9e81761d-e769-4b14-b72c-77b74e707364@linux.alibaba.com> <2a427366-0f63-4024-a3b3-759a4f902061@linux.alibaba.com> <2024062733-cradle-imprecise-002f@gregkh> <2abcf8cf-5cfc-4932-a544-ee0788bb2ed3@linux.alibaba.com> <32dce802-692f-4050-b153-d5c4541fd835@linux.alibaba.com> <2024062757-throwaway-frugality-0637@gregkh> <62f71edc-b89d-4d5c-b51b-4eefb838d7fb@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <62f71edc-b89d-4d5c-b51b-4eefb838d7fb@linux.alibaba.com> X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: brauner@kernel.org, jack@suse.cz, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Thu, Jun 27, 2024 at 10:03:38PM +0800, Gao Xiang wrote: > > > On 2024/6/27 21:22, Greg KH wrote: > > On Thu, Jun 27, 2024 at 08:51:37PM +0800, Gao Xiang wrote: > > > > > > > > > On 2024/6/27 20:36, Gao Xiang wrote: > > > > Hi Greg, > > > > > > > > On 2024/6/27 19:16, Greg KH wrote: > > > > > > ... > > > > > > > > > > > > > So what specifically should we do here? > > > > > > > > Thanks for the reply..  Honestly I'd like to revert > > > > > > > > block: Provide bdev_open_* functions > > > > erofs: Convert to use bdev_open_by_path() > > > > erofs: fix handling kern_mount() failure > > > > > > > > Not quite sure if they can be cleanly reverted, but > > > > since the upstream doen't have 'bdev_handle' anymore, > > > > I will resend a proper backport for > > > > "erofs: fix handling kern_mount() failure". > > > > > > Sigh, I just tried and it seems it causes more > > > conflicts due to my revert. It seems another churn.. > > > > > > Anyway, on 6.6 LTS only the erofs one uses the > > > obsolete `struct bdev_handle`, but I think at least > > > it doesn't cause some serious issue. > > > > > > Hi Greg, > > > > > > Could you just pick up Hongbo's backport to resolve > > > the NULL dereference issue? > > > > Sure, is that the one earlier in this thread? > > Yeah. > > > > > And if so, what is the git commit id of it in Linus's tree? > > commit 8bd90b6ae7856dd5000b75691d905b39b9ea5d6b upstream. Now queued up, thanks. greg k-h