From: alexs@kernel.org
To: Vitaly Wool <vitaly.wool@konsulko.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
minchan@kernel.org, willy@infradead.org,
senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com,
Yosry Ahmed <yosryahmed@google.com>,
nphamcs@gmail.com
Cc: Alex Shi <alexs@kernel.org>
Subject: [PATCH v2 07/20] mm/zsmalloc: convert obj_allocated() and related helpers to use zpdesc
Date: Wed, 3 Jul 2024 12:05:57 +0800 [thread overview]
Message-ID: <20240703040613.681396-8-alexs@kernel.org> (raw)
In-Reply-To: <20240703040613.681396-1-alexs@kernel.org>
From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Convert obj_allocated(), and related helpers to take zpdesc. Also make
its callers to cast (struct page *) to (struct zpdesc *) when calling them.
The users will be converted gradually as there are many.
Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Signed-off-by: Alex Shi <alexs@kernel.org>
---
mm/zsmalloc.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index a8f390beeab8..29b9fa5baa46 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -845,15 +845,15 @@ static unsigned long handle_to_obj(unsigned long handle)
return *(unsigned long *)handle;
}
-static inline bool obj_allocated(struct page *page, void *obj,
+static inline bool obj_allocated(struct zpdesc *zpdesc, void *obj,
unsigned long *phandle)
{
unsigned long handle;
- struct zspage *zspage = get_zspage(page);
+ struct zspage *zspage = get_zspage(zpdesc_page(zpdesc));
if (unlikely(ZsHugePage(zspage))) {
- VM_BUG_ON_PAGE(!is_first_page(page), page);
- handle = page->index;
+ VM_BUG_ON_PAGE(!is_first_zpdesc(zpdesc), zpdesc_page(zpdesc));
+ handle = zpdesc->handle;
} else
handle = *(unsigned long *)obj;
@@ -1603,18 +1603,18 @@ static void zs_object_copy(struct size_class *class, unsigned long dst,
* return handle.
*/
static unsigned long find_alloced_obj(struct size_class *class,
- struct page *page, int *obj_idx)
+ struct zpdesc *zpdesc, int *obj_idx)
{
unsigned int offset;
int index = *obj_idx;
unsigned long handle = 0;
- void *addr = kmap_atomic(page);
+ void *addr = zpdesc_kmap_atomic(zpdesc);
- offset = get_first_obj_offset(page);
+ offset = get_first_obj_offset(zpdesc_page(zpdesc));
offset += class->size * index;
while (offset < PAGE_SIZE) {
- if (obj_allocated(page, addr + offset, &handle))
+ if (obj_allocated(zpdesc, addr + offset, &handle))
break;
offset += class->size;
@@ -1638,7 +1638,7 @@ static void migrate_zspage(struct zs_pool *pool, struct zspage *src_zspage,
struct size_class *class = pool->size_class[src_zspage->class];
while (1) {
- handle = find_alloced_obj(class, s_page, &obj_idx);
+ handle = find_alloced_obj(class, page_zpdesc(s_page), &obj_idx);
if (!handle) {
s_page = get_next_page(s_page);
if (!s_page)
@@ -1871,7 +1871,7 @@ static int zs_page_migrate(struct page *newpage, struct page *page,
for (addr = s_addr + offset; addr < s_addr + PAGE_SIZE;
addr += class->size) {
- if (obj_allocated(page, addr, &handle)) {
+ if (obj_allocated(page_zpdesc(page), addr, &handle)) {
old_obj = handle_to_obj(handle);
obj_to_location(old_obj, &dummy, &obj_idx);
--
2.43.0
next prev parent reply other threads:[~2024-07-03 4:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 4:05 [PATCH v2 00/20] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool alexs
2024-07-03 4:05 ` [PATCH v2 01/20] " alexs
2024-07-05 13:41 ` kernel test robot
2024-07-05 14:02 ` kernel test robot
2024-07-03 4:05 ` [PATCH v2 02/20] mm/zsmalloc: use zpdesc in trylock_zspage/lock_zspage alexs
2024-07-03 4:05 ` [PATCH v2 03/20] mm/zsmalloc: convert __zs_map_object/__zs_unmap_object to use zpdesc alexs
2024-07-03 4:05 ` [PATCH v2 04/20] mm/zsmalloc: add and use pfn/zpdesc seeking funcs alexs
2024-07-03 4:05 ` [PATCH v2 05/20] mm/zsmalloc: convert obj_malloc() to use zpdesc alexs
2024-07-03 4:05 ` [PATCH v2 06/20] mm/zsmalloc: convert create_page_chain() and its users " alexs
2024-07-03 4:05 ` alexs [this message]
2024-07-03 4:05 ` [PATCH v2 08/20] mm/zsmalloc: convert init_zspage() " alexs
2024-07-03 4:05 ` [PATCH v2 09/20] mm/zsmalloc: convert obj_to_page() and zs_free() " alexs
2024-07-03 4:06 ` [PATCH v2 10/20] mm/zsmalloc: add zpdesc_is_isolated/zpdesc_zone helper for zs_page_migrate alexs
2024-07-03 4:06 ` [PATCH v2 11/20] mm/zsmalloc: rename reset_page to reset_zpdesc and use zpdesc in it alexs
2024-07-03 4:06 ` [PATCH v2 12/20] mm/zsmalloc: convert __free_zspage() to use zdsesc alexs
2024-07-03 4:06 ` [PATCH v2 13/20] mm/zsmalloc: convert location_to_obj() to take zpdesc alexs
2024-07-03 4:06 ` [PATCH v2 14/20] mm/zsmalloc: convert migrate_zspage() to use zpdesc alexs
2024-07-03 4:06 ` [PATCH v2 15/20] mm/zsmalloc: convert get_zspage() to take zpdesc alexs
2024-07-03 4:06 ` [PATCH v2 16/20] mm/zsmalloc: convert SetZsPageMovable and remove unused funcs alexs
2024-07-03 4:06 ` [PATCH v2 17/20] mm/zsmalloc: convert get/set_first_obj_offset() to take zpdesc alexs
2024-07-05 14:43 ` kernel test robot
2024-07-05 17:15 ` Nathan Chancellor
2024-07-03 4:06 ` [PATCH v2 18/20] mm/zsmalloc: introduce __zpdesc_clear_movable alexs
2024-07-03 4:06 ` [PATCH v2 19/20] mm/zsmalloc: introduce __zpdesc_clear_zsmalloc alexs
2024-07-03 4:06 ` [PATCH v2 20/20] mm/zsmalloc: introduce __zpdesc_set_zsmalloc() alexs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703040613.681396-8-alexs@kernel.org \
--to=alexs@kernel.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=vitaly.wool@konsulko.com \
--cc=willy@infradead.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.