From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 499CFC2BD09 for ; Wed, 3 Jul 2024 06:47:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d8Q2v/1BDgF7UHwOnqClViUx+kKa7mAEVTtqxAFL2Jg=; b=2l9Kk/qtTuNF6n mpXNqF545aioGtZpHgxHl2320ncryPZ/VnLy/9zRvdvi8wZgU1/trkzHrt+eSyTc4nmLN9+fLP4ol 267JGb/kmrz3cmXrhGxbb3jT2+2ZW2Zql8IPh/eSQZyJtnVOTQzNM90/BSYS+vc0szHN0VMYSWqWp EUYWRY1yq9Btl9Tbnifbjhr4VC5MYdQ5QxURNFM+ETyM1VxksRSSOcahKQHCBwR5zZfnBwKdGJzWl hk/LPFX5u3Kz1Z9g5aCSIDWNF5/IG8wuMYUtICVM5SsOBCgtxrKnXuuFrJvv4/psE5MqvlFRDXKxB Dp0NYtO1szjRSdMGYAkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOtlu-00000009Fec-1YvV; Wed, 03 Jul 2024 06:47:18 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOtlg-00000009FcY-2DAo; Wed, 03 Jul 2024 06:47:06 +0000 Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AAB1B4CA; Wed, 3 Jul 2024 08:46:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1719989192; bh=sRH4XX/SpITUzgyYllUEYXThKOpItqyK7CjS72POQzg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XNN9UU8usnqMY4/3ZXVWKp3aiBDKyQiPE8/EamYRk1ELogAERnOVeQrnMasGaUN4k lXjMKq2mM63KP6uMwB80FbEDMMpDreKwjVuGoP8hPvG8muYKgbplq2K/8Yff2Ncl+V fXa+1D1gEK3/RQta7EPj0VxLg4yJWqEQ2lluwu7M= Date: Wed, 3 Jul 2024 09:46:39 +0300 From: Laurent Pinchart To: =?utf-8?Q?Ond=C5=99ej?= Jirman Cc: linux-kernel@vger.kernel.org, paul.elder@ideasonboard.com, Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner , "open list:ROCKCHIP ISP V1 DRIVER" , "open list:ROCKCHIP ISP V1 DRIVER" , "moderated list:ARM/Rockchip SoC support" Subject: Re: [PATCH v2] media: rkisp1: Adapt to different SoCs having different size limits Message-ID: <20240703064639.GA19586@pendragon.ideasonboard.com> References: <20240315230245.1385902-1-megi@xff.cz> <5jbzvsoxtm7er6dwjcbswyu7xuaeqnlkbes3sue2hfrsps3ea3@znr2vugn52sq> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5jbzvsoxtm7er6dwjcbswyu7xuaeqnlkbes3sue2hfrsps3ea3@znr2vugn52sq> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240702_234704_738100_E58A1948 X-CRM114-Status: GOOD ( 25.57 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgT25kxZllaiwKCk9uIFdlZCwgSnVuIDEyLCAyMDI0IGF0IDAyOjU4OjAyUE0gKzAyMDAsIE9u ZMWZZWogSmlybWFuIHdyb3RlOgo+IE9uIFNhdCwgTWFyIDE2LCAyMDI0IGF0IDEyOjAyOjQxQU0g R01ULCBtZWdpIHhmZiB3cm90ZToKPiA+IEZyb206IE9uZHJlaiBKaXJtYW4gPG1lZ2lAeGZmLmN6 Pgo+ID4gCj4gPiAtIFJLMzM5OSBoYXMgaW5wdXQvb3V0cHV0IGxpbWl0IG9mIG1haW4gcGF0aCA0 NDE2IHggMzMxMgo+ID4gLSBQWDMwIGhhcyBpbnB1dC9vdXRwdXQgbGltaXQgb2YgbWFpbiBwYXRo IDMyNjQgeCAyNDQ4Cj4gPiAtIGkuTVg4TVAgaGFzIGlucHV0L291dHB1dCBsaW1pdCBvZiBtYWlu IHBhdGggNDA5NiB4IDMwNzIKPiA+IAo+ID4gVXNlIHJraXNwMV9pbmZvIHN0cnVjdCB0byBlbmNv ZGUgdGhlIGxpbWl0cy4KPiAKPiBJdCB3b3VsZCBiZSBuaWNlIHRvIGdldCB0aGlzIG1lcmdlZC4g SXQncyByZXZpZXdlZCBhbmQgcmVhZHkuCgpBbGwgbXkgYXBvbG9naWVzIGZvciB0aGUgZGVsYXku IEknbSBjYXRjaGluZyB1cCB3aXRoIG15IHBhdGNoIHF1ZXVlLgpUaGFua3MgZm9yIHRoZSBwaW5n LCBhbmQgdGhhbmtzIGZvciB1cHN0cmVhbWluZyB0aGlzIGNoYW5nZS4KCj4gPiBTaWduZWQtb2Zm LWJ5OiBPbmRyZWogSmlybWFuIDxtZWdpQHhmZi5jej4KPiA+IC0tLQo+ID4gdjI6Cj4gPiAtIGFk YXB0IHRvIGkuTVg4TVAgbWVyZ2VkIGZvciB2Ni45Cj4gPiAKPiA+ICBkcml2ZXJzL21lZGlhL3Bs YXRmb3JtL3JvY2tjaGlwL3JraXNwMS9ya2lzcDEtY29tbW9uLmggIHwgNiArKysrLS0KPiA+ICBk cml2ZXJzL21lZGlhL3BsYXRmb3JtL3JvY2tjaGlwL3JraXNwMS9ya2lzcDEtY3NpLmMgICAgIHwg NSArKystLQo+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNw MS1kZXYuYyAgICAgfCA2ICsrKysrKwo+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2No aXAvcmtpc3AxL3JraXNwMS1pc3AuYyAgICAgfCA5ICsrKysrLS0tLQo+ID4gIGRyaXZlcnMvbWVk aWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1yZXNpemVyLmMgfCA0ICsrLS0KPiA+ ICA1IGZpbGVzIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+ID4g Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hpcC9ya2lzcDEv cmtpc3AxLWNvbW1vbi5oIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hpcC9ya2lzcDEv cmtpc3AxLWNvbW1vbi5oCj4gPiBpbmRleCAyNjU3M2Y2YWU1NzUuLmI0Yzk1OGI5MzYyOSAxMDA2 NDQKPiA+IC0tLSBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNw MS1jb21tb24uaAo+ID4gKysrIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hpcC9ya2lz cDEvcmtpc3AxLWNvbW1vbi5oCj4gPiBAQCAtMzQsOCArMzQsNiBAQCBzdHJ1Y3QgcmVnbWFwOwo+ ID4gICNkZWZpbmUgUktJU1AxX0lTUF9TRF9TSU5LCQkJQklUKDEpCj4gPiAgCj4gPiAgLyogbWlu IGFuZCBtYXggdmFsdWVzIGZvciB0aGUgd2lkdGhzIGFuZCBoZWlnaHRzIG9mIHRoZSBlbnRpdGll cyAqLwoKSXQncyB0aGUgbWluIG9ubHkgbm93LiBJJ2xsIHVwZGF0ZSB0aGlzIGNvbW1lbnQgaW4g bXkgdHJlZSB0bwoKLyoKICogTWluaW11bSB2YWx1ZXMgZm9yIHRoZSB3aWR0aCBhbmQgaGVpZ2h0 IG9mIGVudGl0aWVzLiBUaGUgbWF4aW11bSB2YWx1ZXMgYXJlCiAqIG1vZGVsLXNwZWNpZmljIGFu ZCBzdG9yZWQgaW4gdGhlIHJraXNwMV9pbmZvIHN0cnVjdHVyZS4KICovCgpSZXZpZXdlZC1ieTog TGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoKYW5k IHF1ZXVlZC4KCj4gPiAtI2RlZmluZSBSS0lTUDFfSVNQX01BWF9XSURUSAkJCTQwMzIKPiA+IC0j ZGVmaW5lIFJLSVNQMV9JU1BfTUFYX0hFSUdIVAkJCTMwMjQKPiA+ICAjZGVmaW5lIFJLSVNQMV9J U1BfTUlOX1dJRFRICQkJMzIKPiA+ICAjZGVmaW5lIFJLSVNQMV9JU1BfTUlOX0hFSUdIVAkJCTMy Cj4gPiAgCj4gPiBAQCAtMTQwLDYgKzEzOCw4IEBAIGVudW0gcmtpc3AxX2ZlYXR1cmUgewo+ID4g ICAqIEBpc3Jfc2l6ZTogbnVtYmVyIG9mIGVudHJpZXMgaW4gdGhlIEBpc3JzIGFycmF5Cj4gPiAg ICogQGlzcF92ZXI6IElTUCB2ZXJzaW9uCj4gPiAgICogQGZlYXR1cmVzOiBiaXRtYXNrIG9mIHJr aXNwMV9mZWF0dXJlIGZlYXR1cmVzIGltcGxlbWVudGVkIGJ5IHRoZSBJU1AKPiA+ICsgKiBAbWF4 X3dpZHRoOiBtYXhpbXVtIGlucHV0IGZyYW1lIHdpZHRoCj4gPiArICogQG1heF9oZWlnaHQ6IG1h eGltdW0gaW5wdXQgZnJhbWUgaGVpZ2h0Cj4gPiAgICoKPiA+ICAgKiBUaGlzIHN0cnVjdHVyZSBj b250YWlucyBpbmZvcm1hdGlvbiBhYm91dCB0aGUgSVNQIHNwZWNpZmljIHRvIGEgcGFydGljdWxh cgo+ID4gICAqIElTUCBtb2RlbCwgdmVyc2lvbiwgb3IgaW50ZWdyYXRpb24gaW4gYSBwYXJ0aWN1 bGFyIFNvQy4KPiA+IEBAIC0xNTEsNiArMTUxLDggQEAgc3RydWN0IHJraXNwMV9pbmZvIHsKPiA+ ICAJdW5zaWduZWQgaW50IGlzcl9zaXplOwo+ID4gIAllbnVtIHJraXNwMV9jaWZfaXNwX3ZlcnNp b24gaXNwX3ZlcjsKPiA+ICAJdW5zaWduZWQgaW50IGZlYXR1cmVzOwo+ID4gKwl1bnNpZ25lZCBp bnQgbWF4X3dpZHRoOwo+ID4gKwl1bnNpZ25lZCBpbnQgbWF4X2hlaWdodDsKPiA+ICB9Owo+ID4g IAo+ID4gIC8qCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hp cC9ya2lzcDEvcmtpc3AxLWNzaS5jIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hpcC9y a2lzcDEvcmtpc3AxLWNzaS5jCj4gPiBpbmRleCA0MjAyNjQyZTA1MjMuLjg0MWU1OGMyMGY3ZiAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3Jr aXNwMS1jc2kuYwo+ID4gKysrIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hpcC9ya2lz cDEvcmtpc3AxLWNzaS5jCj4gPiBAQCAtMzA3LDYgKzMwNyw3IEBAIHN0YXRpYyBpbnQgcmtpc3Ax X2NzaV9zZXRfZm10KHN0cnVjdCB2NGwyX3N1YmRldiAqc2QsCj4gPiAgCQkJICAgICAgc3RydWN0 IHY0bDJfc3ViZGV2X3N0YXRlICpzZF9zdGF0ZSwKPiA+ICAJCQkgICAgICBzdHJ1Y3QgdjRsMl9z dWJkZXZfZm9ybWF0ICpmbXQpCj4gPiAgewo+ID4gKwlzdHJ1Y3Qgcmtpc3AxX2NzaSAqY3NpID0g dG9fcmtpc3AxX2NzaShzZCk7Cj4gPiAgCWNvbnN0IHN0cnVjdCBya2lzcDFfbWJ1c19pbmZvICpt YnVzX2luZm87Cj4gPiAgCXN0cnVjdCB2NGwyX21idXNfZnJhbWVmbXQgKnNpbmtfZm10LCAqc3Jj X2ZtdDsKPiA+ICAKPiA+IEBAIC0zMjYsMTAgKzMyNywxMCBAQCBzdGF0aWMgaW50IHJraXNwMV9j c2lfc2V0X2ZtdChzdHJ1Y3QgdjRsMl9zdWJkZXYgKnNkLAo+ID4gIAo+ID4gIAlzaW5rX2ZtdC0+ d2lkdGggPSBjbGFtcF90KHUzMiwgZm10LT5mb3JtYXQud2lkdGgsCj4gPiAgCQkJCSAgUktJU1Ax X0lTUF9NSU5fV0lEVEgsCj4gPiAtCQkJCSAgUktJU1AxX0lTUF9NQVhfV0lEVEgpOwo+ID4gKwkJ CQkgIGNzaS0+cmtpc3AxLT5pbmZvLT5tYXhfd2lkdGgpOwo+ID4gIAlzaW5rX2ZtdC0+aGVpZ2h0 ID0gY2xhbXBfdCh1MzIsIGZtdC0+Zm9ybWF0LmhlaWdodCwKPiA+ICAJCQkJICAgUktJU1AxX0lT UF9NSU5fSEVJR0hULAo+ID4gLQkJCQkgICBSS0lTUDFfSVNQX01BWF9IRUlHSFQpOwo+ID4gKwkJ CQkgICBjc2ktPnJraXNwMS0+aW5mby0+bWF4X2hlaWdodCk7Cj4gPiAgCj4gPiAgCWZtdC0+Zm9y bWF0ID0gKnNpbmtfZm10Owo+ID4gIAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxh dGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1kZXYuYyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZv cm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1kZXYuYwo+ID4gaW5kZXggYmIwMjAyMzg2YzcwLi4w NTM1Y2U1N2U4NjIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3JvY2tj aGlwL3JraXNwMS9ya2lzcDEtZGV2LmMKPiA+ICsrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0v cm9ja2NoaXAvcmtpc3AxL3JraXNwMS1kZXYuYwo+ID4gQEAgLTUxMCw2ICs1MTAsOCBAQCBzdGF0 aWMgY29uc3Qgc3RydWN0IHJraXNwMV9pbmZvIHB4MzBfaXNwX2luZm8gPSB7Cj4gPiAgCS5mZWF0 dXJlcyA9IFJLSVNQMV9GRUFUVVJFX01JUElfQ1NJMgo+ID4gIAkJICB8IFJLSVNQMV9GRUFUVVJF X1NFTEZfUEFUSAo+ID4gIAkJICB8IFJLSVNQMV9GRUFUVVJFX0RVQUxfQ1JPUCwKPiA+ICsJLm1h eF93aWR0aCA9IDMyNjQsCj4gPiArCS5tYXhfaGVpZ2h0ID0gMjQ0OCwKPiA+ICB9Owo+ID4gIAo+ ID4gIHN0YXRpYyBjb25zdCBjaGFyICogY29uc3QgcmszMzk5X2lzcF9jbGtzW10gPSB7Cj4gPiBA QCAtNTMxLDYgKzUzMyw4IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgcmtpc3AxX2luZm8gcmszMzk5 X2lzcF9pbmZvID0gewo+ID4gIAkuZmVhdHVyZXMgPSBSS0lTUDFfRkVBVFVSRV9NSVBJX0NTSTIK PiA+ICAJCSAgfCBSS0lTUDFfRkVBVFVSRV9TRUxGX1BBVEgKPiA+ICAJCSAgfCBSS0lTUDFfRkVB VFVSRV9EVUFMX0NST1AsCj4gPiArCS5tYXhfd2lkdGggPSA0NDE2LAo+ID4gKwkubWF4X2hlaWdo dCA9IDMzMTIsCj4gPiAgfTsKPiA+ICAKPiA+ICBzdGF0aWMgY29uc3QgY2hhciAqIGNvbnN0IGlt eDhtcF9pc3BfY2xrc1tdID0gewo+ID4gQEAgLTU1MSw2ICs1NTUsOCBAQCBzdGF0aWMgY29uc3Qg c3RydWN0IHJraXNwMV9pbmZvIGlteDhtcF9pc3BfaW5mbyA9IHsKPiA+ICAJLmlzcF92ZXIgPSBS S0lTUDFfVl9JTVg4TVAsCj4gPiAgCS5mZWF0dXJlcyA9IFJLSVNQMV9GRUFUVVJFX01BSU5fU1RS SURFCj4gPiAgCQkgIHwgUktJU1AxX0ZFQVRVUkVfRE1BXzM0QklULAo+ID4gKwkubWF4X3dpZHRo ID0gNDA5NiwKPiA+ICsJLm1heF9oZWlnaHQgPSAzMDcyLAo+ID4gIH07Cj4gPiAgCj4gPiAgc3Rh dGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgcmtpc3AxX29mX21hdGNoW10gPSB7Cj4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hpcC9ya2lzcDEvcmtpc3Ax LWlzcC5jIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hpcC9ya2lzcDEvcmtpc3AxLWlz cC5jCj4gPiBpbmRleCBlNDVhMjEzYmFmNDkuLmY3ODdhN2U5MWUzZSAxMDA2NDQKPiA+IC0tLSBh L2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1pc3AuYwo+ID4g KysrIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hpcC9ya2lzcDEvcmtpc3AxLWlzcC5j Cj4gPiBAQCAtNTE3LDYgKzUxNyw3IEBAIHN0YXRpYyBpbnQgcmtpc3AxX2lzcF9lbnVtX2ZyYW1l X3NpemUoc3RydWN0IHY0bDJfc3ViZGV2ICpzZCwKPiA+ICAJCQkJICAgICAgc3RydWN0IHY0bDJf c3ViZGV2X3N0YXRlICpzZF9zdGF0ZSwKPiA+ICAJCQkJICAgICAgc3RydWN0IHY0bDJfc3ViZGV2 X2ZyYW1lX3NpemVfZW51bSAqZnNlKQo+ID4gIHsKPiA+ICsJc3RydWN0IHJraXNwMV9pc3AgKmlz cCA9IHRvX3JraXNwMV9pc3Aoc2QpOwo+ID4gIAljb25zdCBzdHJ1Y3Qgcmtpc3AxX21idXNfaW5m byAqbWJ1c19pbmZvOwo+ID4gIAo+ID4gIAlpZiAoZnNlLT5wYWQgPT0gUktJU1AxX0lTUF9QQURf U0lOS19QQVJBTVMgfHwKPiA+IEBAIC01MzksOSArNTQwLDkgQEAgc3RhdGljIGludCBya2lzcDFf aXNwX2VudW1fZnJhbWVfc2l6ZShzdHJ1Y3QgdjRsMl9zdWJkZXYgKnNkLAo+ID4gIAkJcmV0dXJu IC1FSU5WQUw7Cj4gPiAgCj4gPiAgCWZzZS0+bWluX3dpZHRoID0gUktJU1AxX0lTUF9NSU5fV0lE VEg7Cj4gPiAtCWZzZS0+bWF4X3dpZHRoID0gUktJU1AxX0lTUF9NQVhfV0lEVEg7Cj4gPiArCWZz ZS0+bWF4X3dpZHRoID0gaXNwLT5ya2lzcDEtPmluZm8tPm1heF93aWR0aDsKPiA+ICAJZnNlLT5t aW5faGVpZ2h0ID0gUktJU1AxX0lTUF9NSU5fSEVJR0hUOwo+ID4gLQlmc2UtPm1heF9oZWlnaHQg PSBSS0lTUDFfSVNQX01BWF9IRUlHSFQ7Cj4gPiArCWZzZS0+bWF4X2hlaWdodCA9IGlzcC0+cmtp c3AxLT5pbmZvLT5tYXhfaGVpZ2h0Owo+ID4gIAo+ID4gIAlyZXR1cm4gMDsKPiA+ICB9Cj4gPiBA QCAtNzcyLDEwICs3NzMsMTAgQEAgc3RhdGljIHZvaWQgcmtpc3AxX2lzcF9zZXRfc2lua19mbXQo c3RydWN0IHJraXNwMV9pc3AgKmlzcCwKPiA+ICAKPiA+ICAJc2lua19mbXQtPndpZHRoID0gY2xh bXBfdCh1MzIsIGZvcm1hdC0+d2lkdGgsCj4gPiAgCQkJCSAgUktJU1AxX0lTUF9NSU5fV0lEVEgs Cj4gPiAtCQkJCSAgUktJU1AxX0lTUF9NQVhfV0lEVEgpOwo+ID4gKwkJCQkgIGlzcC0+cmtpc3Ax LT5pbmZvLT5tYXhfd2lkdGgpOwo+ID4gIAlzaW5rX2ZtdC0+aGVpZ2h0ID0gY2xhbXBfdCh1MzIs IGZvcm1hdC0+aGVpZ2h0LAo+ID4gIAkJCQkgICBSS0lTUDFfSVNQX01JTl9IRUlHSFQsCj4gPiAt CQkJCSAgIFJLSVNQMV9JU1BfTUFYX0hFSUdIVCk7Cj4gPiArCQkJCSAgIGlzcC0+cmtpc3AxLT5p bmZvLT5tYXhfaGVpZ2h0KTsKPiA+ICAKPiA+ICAJLyoKPiA+ICAJICogQWRqdXN0IHRoZSBjb2xv ciBzcGFjZSBmaWVsZHMuIEFjY2VwdCBhbnkgY29sb3IgcHJpbWFyaWVzIGFuZAo+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1yZXNp emVyLmMgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3JvY2tjaGlwL3JraXNwMS9ya2lzcDEtcmVz aXplci5jCj4gPiBpbmRleCA2ZjM5MzFjYTViNTEuLmUyMmNjMmRiMjRjZiAxMDA2NDQKPiA+IC0t LSBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1yZXNpemVy LmMKPiA+ICsrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNw MS1yZXNpemVyLmMKPiA+IEBAIC00OTQsMTAgKzQ5NCwxMCBAQCBzdGF0aWMgdm9pZCBya2lzcDFf cnN6X3NldF9zaW5rX2ZtdChzdHJ1Y3Qgcmtpc3AxX3Jlc2l6ZXIgKnJzeiwKPiA+ICAKPiA+ICAJ c2lua19mbXQtPndpZHRoID0gY2xhbXBfdCh1MzIsIGZvcm1hdC0+d2lkdGgsCj4gPiAgCQkJCSAg UktJU1AxX0lTUF9NSU5fV0lEVEgsCj4gPiAtCQkJCSAgUktJU1AxX0lTUF9NQVhfV0lEVEgpOwo+ ID4gKwkJCQkgIHJzei0+cmtpc3AxLT5pbmZvLT5tYXhfd2lkdGgpOwo+ID4gIAlzaW5rX2ZtdC0+ aGVpZ2h0ID0gY2xhbXBfdCh1MzIsIGZvcm1hdC0+aGVpZ2h0LAo+ID4gIAkJCQkgICBSS0lTUDFf SVNQX01JTl9IRUlHSFQsCj4gPiAtCQkJCSAgIFJLSVNQMV9JU1BfTUFYX0hFSUdIVCk7Cj4gPiAr CQkJCSAgIHJzei0+cmtpc3AxLT5pbmZvLT5tYXhfaGVpZ2h0KTsKPiA+ICAKPiA+ICAJLyoKPiA+ ICAJICogQWRqdXN0IHRoZSBjb2xvciBzcGFjZSBmaWVsZHMuIEFjY2VwdCBhbnkgY29sb3IgcHJp bWFyaWVzIGFuZAoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5n IGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F378C2BD09 for ; Wed, 3 Jul 2024 06:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zmJnQYtOC48JaysB4gJKXlSo9S/fktlpVgD0+VxtU2s=; b=z+Bf+JUv/kKl+mPY7vn4L/yuOY oxUytvLZdTEF6ou9yEQxbVDCb2TE5KHDiS+Mih+dBl9aDijPCUQkikbC6u9m7oq9DJYkU/bscnvI7 mBOFLK3M6d9bISm3thZO5bDkQ2k33pNc/56+Hp0SzOd2HWBW2JijfhNFFKV8wVJgV+/oXy2uSEIui yo9EV20sn0chKYZ7wSfo6eP9M/HNdZhXtsiqB84B5bDQAm6IwoANU+eVKVfX1kfLpwzZiR+jOi4gi wNM6O0pYvDJL0hXBqGvoLcIwxFu1epvwrUwNdyaxT7Auma9QifTPdYBqjtdGTl70vYDqUtZ+ipoU5 nM5OjKBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOtlt-00000009Fe5-0dCw; Wed, 03 Jul 2024 06:47:17 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOtlg-00000009FcY-2DAo; Wed, 03 Jul 2024 06:47:06 +0000 Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AAB1B4CA; Wed, 3 Jul 2024 08:46:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1719989192; bh=sRH4XX/SpITUzgyYllUEYXThKOpItqyK7CjS72POQzg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XNN9UU8usnqMY4/3ZXVWKp3aiBDKyQiPE8/EamYRk1ELogAERnOVeQrnMasGaUN4k lXjMKq2mM63KP6uMwB80FbEDMMpDreKwjVuGoP8hPvG8muYKgbplq2K/8Yff2Ncl+V fXa+1D1gEK3/RQta7EPj0VxLg4yJWqEQ2lluwu7M= Date: Wed, 3 Jul 2024 09:46:39 +0300 From: Laurent Pinchart To: =?utf-8?Q?Ond=C5=99ej?= Jirman Cc: linux-kernel@vger.kernel.org, paul.elder@ideasonboard.com, Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner , "open list:ROCKCHIP ISP V1 DRIVER" , "open list:ROCKCHIP ISP V1 DRIVER" , "moderated list:ARM/Rockchip SoC support" Subject: Re: [PATCH v2] media: rkisp1: Adapt to different SoCs having different size limits Message-ID: <20240703064639.GA19586@pendragon.ideasonboard.com> References: <20240315230245.1385902-1-megi@xff.cz> <5jbzvsoxtm7er6dwjcbswyu7xuaeqnlkbes3sue2hfrsps3ea3@znr2vugn52sq> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5jbzvsoxtm7er6dwjcbswyu7xuaeqnlkbes3sue2hfrsps3ea3@znr2vugn52sq> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240702_234704_738100_E58A1948 X-CRM114-Status: GOOD ( 25.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ondřej, On Wed, Jun 12, 2024 at 02:58:02PM +0200, Ondřej Jirman wrote: > On Sat, Mar 16, 2024 at 12:02:41AM GMT, megi xff wrote: > > From: Ondrej Jirman > > > > - RK3399 has input/output limit of main path 4416 x 3312 > > - PX30 has input/output limit of main path 3264 x 2448 > > - i.MX8MP has input/output limit of main path 4096 x 3072 > > > > Use rkisp1_info struct to encode the limits. > > It would be nice to get this merged. It's reviewed and ready. All my apologies for the delay. I'm catching up with my patch queue. Thanks for the ping, and thanks for upstreaming this change. > > Signed-off-by: Ondrej Jirman > > --- > > v2: > > - adapt to i.MX8MP merged for v6.9 > > > > drivers/media/platform/rockchip/rkisp1/rkisp1-common.h | 6 ++++-- > > drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c | 5 +++-- > > drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 6 ++++++ > > drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 9 +++++---- > > drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c | 4 ++-- > > 5 files changed, 20 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > > index 26573f6ae575..b4c958b93629 100644 > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > > @@ -34,8 +34,6 @@ struct regmap; > > #define RKISP1_ISP_SD_SINK BIT(1) > > > > /* min and max values for the widths and heights of the entities */ It's the min only now. I'll update this comment in my tree to /* * Minimum values for the width and height of entities. The maximum values are * model-specific and stored in the rkisp1_info structure. */ Reviewed-by: Laurent Pinchart and queued. > > -#define RKISP1_ISP_MAX_WIDTH 4032 > > -#define RKISP1_ISP_MAX_HEIGHT 3024 > > #define RKISP1_ISP_MIN_WIDTH 32 > > #define RKISP1_ISP_MIN_HEIGHT 32 > > > > @@ -140,6 +138,8 @@ enum rkisp1_feature { > > * @isr_size: number of entries in the @isrs array > > * @isp_ver: ISP version > > * @features: bitmask of rkisp1_feature features implemented by the ISP > > + * @max_width: maximum input frame width > > + * @max_height: maximum input frame height > > * > > * This structure contains information about the ISP specific to a particular > > * ISP model, version, or integration in a particular SoC. > > @@ -151,6 +151,8 @@ struct rkisp1_info { > > unsigned int isr_size; > > enum rkisp1_cif_isp_version isp_ver; > > unsigned int features; > > + unsigned int max_width; > > + unsigned int max_height; > > }; > > > > /* > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c > > index 4202642e0523..841e58c20f7f 100644 > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c > > @@ -307,6 +307,7 @@ static int rkisp1_csi_set_fmt(struct v4l2_subdev *sd, > > struct v4l2_subdev_state *sd_state, > > struct v4l2_subdev_format *fmt) > > { > > + struct rkisp1_csi *csi = to_rkisp1_csi(sd); > > const struct rkisp1_mbus_info *mbus_info; > > struct v4l2_mbus_framefmt *sink_fmt, *src_fmt; > > > > @@ -326,10 +327,10 @@ static int rkisp1_csi_set_fmt(struct v4l2_subdev *sd, > > > > sink_fmt->width = clamp_t(u32, fmt->format.width, > > RKISP1_ISP_MIN_WIDTH, > > - RKISP1_ISP_MAX_WIDTH); > > + csi->rkisp1->info->max_width); > > sink_fmt->height = clamp_t(u32, fmt->format.height, > > RKISP1_ISP_MIN_HEIGHT, > > - RKISP1_ISP_MAX_HEIGHT); > > + csi->rkisp1->info->max_height); > > > > fmt->format = *sink_fmt; > > > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > > index bb0202386c70..0535ce57e862 100644 > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > > @@ -510,6 +510,8 @@ static const struct rkisp1_info px30_isp_info = { > > .features = RKISP1_FEATURE_MIPI_CSI2 > > | RKISP1_FEATURE_SELF_PATH > > | RKISP1_FEATURE_DUAL_CROP, > > + .max_width = 3264, > > + .max_height = 2448, > > }; > > > > static const char * const rk3399_isp_clks[] = { > > @@ -531,6 +533,8 @@ static const struct rkisp1_info rk3399_isp_info = { > > .features = RKISP1_FEATURE_MIPI_CSI2 > > | RKISP1_FEATURE_SELF_PATH > > | RKISP1_FEATURE_DUAL_CROP, > > + .max_width = 4416, > > + .max_height = 3312, > > }; > > > > static const char * const imx8mp_isp_clks[] = { > > @@ -551,6 +555,8 @@ static const struct rkisp1_info imx8mp_isp_info = { > > .isp_ver = RKISP1_V_IMX8MP, > > .features = RKISP1_FEATURE_MAIN_STRIDE > > | RKISP1_FEATURE_DMA_34BIT, > > + .max_width = 4096, > > + .max_height = 3072, > > }; > > > > static const struct of_device_id rkisp1_of_match[] = { > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c > > index e45a213baf49..f787a7e91e3e 100644 > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c > > @@ -517,6 +517,7 @@ static int rkisp1_isp_enum_frame_size(struct v4l2_subdev *sd, > > struct v4l2_subdev_state *sd_state, > > struct v4l2_subdev_frame_size_enum *fse) > > { > > + struct rkisp1_isp *isp = to_rkisp1_isp(sd); > > const struct rkisp1_mbus_info *mbus_info; > > > > if (fse->pad == RKISP1_ISP_PAD_SINK_PARAMS || > > @@ -539,9 +540,9 @@ static int rkisp1_isp_enum_frame_size(struct v4l2_subdev *sd, > > return -EINVAL; > > > > fse->min_width = RKISP1_ISP_MIN_WIDTH; > > - fse->max_width = RKISP1_ISP_MAX_WIDTH; > > + fse->max_width = isp->rkisp1->info->max_width; > > fse->min_height = RKISP1_ISP_MIN_HEIGHT; > > - fse->max_height = RKISP1_ISP_MAX_HEIGHT; > > + fse->max_height = isp->rkisp1->info->max_height; > > > > return 0; > > } > > @@ -772,10 +773,10 @@ static void rkisp1_isp_set_sink_fmt(struct rkisp1_isp *isp, > > > > sink_fmt->width = clamp_t(u32, format->width, > > RKISP1_ISP_MIN_WIDTH, > > - RKISP1_ISP_MAX_WIDTH); > > + isp->rkisp1->info->max_width); > > sink_fmt->height = clamp_t(u32, format->height, > > RKISP1_ISP_MIN_HEIGHT, > > - RKISP1_ISP_MAX_HEIGHT); > > + isp->rkisp1->info->max_height); > > > > /* > > * Adjust the color space fields. Accept any color primaries and > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c > > index 6f3931ca5b51..e22cc2db24cf 100644 > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c > > @@ -494,10 +494,10 @@ static void rkisp1_rsz_set_sink_fmt(struct rkisp1_resizer *rsz, > > > > sink_fmt->width = clamp_t(u32, format->width, > > RKISP1_ISP_MIN_WIDTH, > > - RKISP1_ISP_MAX_WIDTH); > > + rsz->rkisp1->info->max_width); > > sink_fmt->height = clamp_t(u32, format->height, > > RKISP1_ISP_MIN_HEIGHT, > > - RKISP1_ISP_MAX_HEIGHT); > > + rsz->rkisp1->info->max_height); > > > > /* > > * Adjust the color space fields. Accept any color primaries and -- Regards, Laurent Pinchart