From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3305C2BD09 for ; Wed, 3 Jul 2024 15:10:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id BAE2360EF6; Wed, 3 Jul 2024 15:10:22 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id SvF-h961Wirv; Wed, 3 Jul 2024 15:10:20 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org AD79A60EEE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1720019420; bh=Sp+S9V4camCGEgk40sFdrG2J77GnMTLeZHKZIvKJoN0=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=B9lQuw1An8SaTyR3GmXeu88PBPL3aozh+2zb2/5/t1a2QmrHoaJpDRmXVhlHPQw7f 4Kse/JRtGQ2zcIFEOxh9ogOCjMXzyxpataLONhgZeWBxjGcEnS0jwlLq45P3eCOfeO tBVp1Us6Ho6BXrArI1MpXAphCeRlaOXZlZGS/dcWw83Vixi8oUOuJJsIBCVxgbt/5e QU7ktilvJotSFwXMq2VqJRpOse3b3jm2k4DxLLgmvjRnoznHs0LsOo40L/P+GXmxNI wKtyfxIslvCc5x4pmkTmfpMfljObtL0QHCcKs4zy4skWPg3YHFrW9ighB/LuVfcZ1w kCFX1/FtLzQhQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id AD79A60EEE; Wed, 3 Jul 2024 15:10:20 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 3C0111BF2FC for ; Wed, 3 Jul 2024 15:10:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 27016417FC for ; Wed, 3 Jul 2024 15:10:19 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id dzMiVHljBVtg for ; Wed, 3 Jul 2024 15:10:18 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 3812B417ED DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3812B417ED Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp4.osuosl.org (Postfix) with ESMTPS id 3812B417ED for ; Wed, 3 Jul 2024 15:10:17 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 87496CE2CCC; Wed, 3 Jul 2024 15:10:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D5FAC4AF0C; Wed, 3 Jul 2024 15:10:10 +0000 (UTC) Date: Wed, 3 Jul 2024 16:10:08 +0100 From: Simon Horman To: Faizal Rahim Message-ID: <20240703151008.GP598357@kernel.org> References: <20240702040926.3327530-1-faizal.abdul.rahim@linux.intel.com> <20240702040926.3327530-4-faizal.abdul.rahim@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240702040926.3327530-4-faizal.abdul.rahim@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720019412; bh=8fLf5saJRRvwzPYwzm3t4nhdxaXW8budd0rLUeJYNfU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p58rk8swixnthiPBPiCb3f1y/SBWnQBaZlg9xHhtZ24NfKUZH4XLfIKVUYZOsqhV1 jrEStna4xS/WqMKpQLFvHJB9Nt8SWg9dfcjJ/LKtpESJNJQ5omGCl3s4CeVT3NMtKB GHEoDZdS5SYtpJ4ZUsdpGKw7HBORcVoIUhBT76MmgRrqHjSPL3fkglGeDbXG0wXiJg Z6MP1oAxEuYPnNkbU/kqfoXOJtB7BF8UuD61EhOINs8U3MSoCQu+L24Uoml4LKioO0 HTEKuUdY78TyhVeFJqN5XRGIuUBbd6NaBwXVlpwxOtkU04w8qu5Pm9fF9SoZelJANY 7oMiXSK0rdZWw== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=p58rk8sw Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1 3/4] igc: Remove unused qbv_count X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , Tony Nguyen , netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S . Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Jul 02, 2024 at 12:09:25AM -0400, Faizal Rahim wrote: > Removing qbv_count which is now obsolete after these 2 patches: > "igc: Fix reset adapter logics when tx mode change" > "igc: Fix qbv_config_change_errors logics" > > The variable qbv_count serves to indicate whether Taprio is active or if > the tx mode is in TSN (IGC_TQAVCTRL_TRANSMIT_MODE_TSN). This is due to its > unconditional increment within igc_tsn_enable_offload(), which both runs > Taprio and sets the tx mode to TSN. > > Signed-off-by: Faizal Rahim Hi Faizal, This change looks good to me. However, it seems more appropriate as a clean-up for iwl-next once the previous to patches make it there via iwl-net. That notwithstanding, Reviewed-by: Simon Horman ... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DC3C180A64; Wed, 3 Jul 2024 15:10:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720019413; cv=none; b=jOeEJjWLhgrPKTjboj0quz3BmLaeujneAj9PQT/trillDjRULpGkJ4JZ8auZlpV3YmG7ovOcuPH0k3bi49j1F3lkV2opePNCC7trv0I2XidjcaN8E3TcxsEwpTweSMvoV6CRCwMm7cec/ojIXxBmqW6dloVihXy8HJJqnN1+eWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720019413; c=relaxed/simple; bh=8fLf5saJRRvwzPYwzm3t4nhdxaXW8budd0rLUeJYNfU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HNrLJfTEE0mW27C/9+UcnPHkuf2qjnWRjIzU62z/i8aTn8tZiwyoIelMppz13xTM203qnqaA8FkV5Z2Bh6VlELU5NJgx38aBDsqbOdcto73J1XZWnz8SkrXbx17kivQu6sPITHCxQj1lRzMEap/9s9UZeMvK43D60qr6wz26rFQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p58rk8sw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p58rk8sw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D5FAC4AF0C; Wed, 3 Jul 2024 15:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720019412; bh=8fLf5saJRRvwzPYwzm3t4nhdxaXW8budd0rLUeJYNfU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p58rk8swixnthiPBPiCb3f1y/SBWnQBaZlg9xHhtZ24NfKUZH4XLfIKVUYZOsqhV1 jrEStna4xS/WqMKpQLFvHJB9Nt8SWg9dfcjJ/LKtpESJNJQ5omGCl3s4CeVT3NMtKB GHEoDZdS5SYtpJ4ZUsdpGKw7HBORcVoIUhBT76MmgRrqHjSPL3fkglGeDbXG0wXiJg Z6MP1oAxEuYPnNkbU/kqfoXOJtB7BF8UuD61EhOINs8U3MSoCQu+L24Uoml4LKioO0 HTEKuUdY78TyhVeFJqN5XRGIuUBbd6NaBwXVlpwxOtkU04w8qu5Pm9fF9SoZelJANY 7oMiXSK0rdZWw== Date: Wed, 3 Jul 2024 16:10:08 +0100 From: Simon Horman To: Faizal Rahim Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jesse Brandeburg , Tony Nguyen , Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH iwl-net v1 3/4] igc: Remove unused qbv_count Message-ID: <20240703151008.GP598357@kernel.org> References: <20240702040926.3327530-1-faizal.abdul.rahim@linux.intel.com> <20240702040926.3327530-4-faizal.abdul.rahim@linux.intel.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240702040926.3327530-4-faizal.abdul.rahim@linux.intel.com> On Tue, Jul 02, 2024 at 12:09:25AM -0400, Faizal Rahim wrote: > Removing qbv_count which is now obsolete after these 2 patches: > "igc: Fix reset adapter logics when tx mode change" > "igc: Fix qbv_config_change_errors logics" > > The variable qbv_count serves to indicate whether Taprio is active or if > the tx mode is in TSN (IGC_TQAVCTRL_TRANSMIT_MODE_TSN). This is due to its > unconditional increment within igc_tsn_enable_offload(), which both runs > Taprio and sets the tx mode to TSN. > > Signed-off-by: Faizal Rahim Hi Faizal, This change looks good to me. However, it seems more appropriate as a clean-up for iwl-next once the previous to patches make it there via iwl-net. That notwithstanding, Reviewed-by: Simon Horman ...