From: Jeremy Sowden <jeremy@azazel.net>
To: Phil Sutter <phil@nwl.cc>
Cc: Netfilter Devel <netfilter-devel@vger.kernel.org>,
Michael Biebl <biebl@debian.org>
Subject: iptables: reverting 34f085b16073 ("Revert "xshared: Print protocol numbers if --numeric was given"")
Date: Wed, 3 Jul 2024 17:02:04 +0100 [thread overview]
Message-ID: <20240703160204.GA2296970@azazel.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
Hi, Phil.
At the beginning of the year you committed 34f085b16073 ("Revert
"xshared: Print protocol numbers if --numeric was given""), which
reverts da8ecc62dd76 ("xshared: Print protocol numbers if --numeric was
given").
In response to a Debian bug-report:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067733
I applied the change to the iptables package and uploaded it. However,
this caused test failures in the Debian CI pipeline for firewalld
because its test-suite has been updated to expect the new numeric
protocol output. Michael Biebl, the firewalld Debian maintainer, (cc'ed
so he can correct me if I misquote him) raised a point which I think has
some merit. It is now eighteen months since 1.8.9 was released. One
imagines that the majority of iptables users, who presumably are not
building iptables directly from git, must, therefore, have adjusted to
the new output. Is it, then, worth it to revert this change and force
them to undo that work after what may have been a couple of years by the
time 1.8.11 comes out?
What do you think?
J.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next reply other threads:[~2024-07-03 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 16:02 Jeremy Sowden [this message]
2024-07-03 16:52 ` iptables: reverting 34f085b16073 ("Revert "xshared: Print protocol numbers if --numeric was given"") Phil Sutter
2024-07-03 19:17 ` Eric Garver
2024-07-04 20:19 ` Jeremy Sowden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703160204.GA2296970@azazel.net \
--to=jeremy@azazel.net \
--cc=biebl@debian.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.