From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E307C2BD09 for ; Wed, 3 Jul 2024 15:46:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9829E10E032; Wed, 3 Jul 2024 15:46:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="DQ+TqpKz"; dkim-atps=neutral Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20A7210E032 for ; Wed, 3 Jul 2024 15:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1720021560; bh=rby6cMYX9h9HE3RYZ5fbbMR6VNsM8xy3EgH2Q9E2mew=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DQ+TqpKz2ADxSXkJmHHiavyyDGAw/1wrZEkgaGYnU/O690nfcO1jrMBcEYigXtKF+ R6W1XLXnVow8Rp1LazP3YgKyeOLzpvq/cg3CIamxpTmQpZVfmAWF5AD10vVcA/RMfU 5+/mR5dmmOlwr2xE9J6E2u2XF5lTLGDHY/i0YPPwtWrv+2BUhG9VmMz1NWoeCagq6r +GtJwiCFPw+jzQ0F1w9WWZdpq93j/wyVtAJWOIbh/V82P90rFiG/414/Wy59OHxddH Xlg8Gh8foMSDOq4o8DJAemZADRa99dSPMRBeVgmO/wixFM8faEZ8D+AH4B35Y41RiY +ujL6+KDDqCDA== Received: from localhost (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madrid.collaboradmins.com (Postfix) with ESMTPSA id F37113782039; Wed, 3 Jul 2024 15:45:59 +0000 (UTC) Date: Wed, 3 Jul 2024 17:45:58 +0200 From: Boris Brezillon To: Steven Price Cc: =?UTF-8?B?QWRyacOhbg==?= Larumbe , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/7] Support fdinfo runtime and memory stats on Panthor Message-ID: <20240703174558.36387dc8@collabora.com> In-Reply-To: <157b20fa-078a-479c-bb40-017d16d55c21@arm.com> References: <20240606005416.1172431-1-adrian.larumbe@collabora.com> <157b20fa-078a-479c-bb40-017d16d55c21@arm.com> Organization: Collabora X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 3 Jul 2024 16:29:00 +0100 Steven Price wrote: > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index 79ffcbc41d78..42929e147107 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -2926,6 +2926,7 @@ queue_run_job(struct drm_sched_job *sched_job) > pm_runtime_get(ptdev->base.dev); > sched->pm.has_ref = true; > } > + panthor_devfreq_record_busy(sched->ptdev); Oops, we're definitely lacking a busy event if all groups were idle but still assigned a FW slot. Mind sending this as separate fix? > } > > done_fence = dma_fence_get(job->done_fence);