Re: [PATCH 2/2] fuse: Convert to new uid/gid option parsing helpers

[kernel test robot <lkp@intel.com>]

Hi Eric,

kernel test robot noticed the following build errors:

[auto build test ERROR on mszeredi-fuse/for-next]
[also build test ERROR on linus/master vfs-idmapping/for-next v6.10-rc6 next-20240703]
[cannot apply to brauner-vfs/vfs.all]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Eric-Sandeen/fuse-verify-g-u-id-mount-options-correctly/20240703-162239
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-next
patch link:    https://lore.kernel.org/r/4e1a4efa-4ca5-4358-acee-40efd07c3c44%40redhat.com
patch subject: [PATCH 2/2] fuse: Convert to new uid/gid option parsing helpers
config: mips-mtx1_defconfig (https://download.01.org/0day-ci/archive/20240704/202407040514.52Z73Et4-lkp@intel.com/config)
compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240704/202407040514.52Z73Et4-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407040514.52Z73Et4-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/fuse/inode.c:743:2: error: call to undeclared function 'fsparam_uid'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           fsparam_uid     ("user_id",             OPT_USER_ID),
           ^
   fs/fuse/inode.c:744:2: error: call to undeclared function 'fsparam_gid'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           fsparam_gid     ("group_id",            OPT_GROUP_ID),
           ^
   fs/fuse/inode.c:743:2: error: incompatible integer to pointer conversion initializing 'const char *' with an expression of type 'int' [-Wint-conversion]
           fsparam_uid     ("user_id",             OPT_USER_ID),
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   fs/fuse/inode.c:744:2: error: incompatible integer to pointer conversion initializing 'fs_param_type *' (aka 'int (*)(struct p_log *, const struct fs_parameter_spec *, struct fs_parameter *, struct fs_parse_result *)') with an expression of type 'int' [-Wint-conversion]
           fsparam_gid     ("group_id",            OPT_GROUP_ID),
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> fs/fuse/inode.c:745:2: error: designator in initializer for scalar type 'u8' (aka 'unsigned char')
           fsparam_flag    ("default_permissions", OPT_DEFAULT_PERMISSIONS),
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/fs_parser.h:116:33: note: expanded from macro 'fsparam_flag'
   #define fsparam_flag(NAME, OPT) __fsparam(NULL, NAME, OPT, 0, NULL)
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/fs_parser.h:109:3: note: expanded from macro '__fsparam'
                   .name = NAME, \
                   ^~~~~~~~~~~~
>> fs/fuse/inode.c:746:2: error: designator in initializer for scalar type 'unsigned short'
           fsparam_flag    ("allow_other",         OPT_ALLOW_OTHER),
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/fs_parser.h:116:33: note: expanded from macro 'fsparam_flag'
   #define fsparam_flag(NAME, OPT) __fsparam(NULL, NAME, OPT, 0, NULL)
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/fs_parser.h:109:3: note: expanded from macro '__fsparam'
                   .name = NAME, \
                   ^~~~~~~~~~~~
>> fs/fuse/inode.c:747:2: error: designator in initializer for scalar type 'const void *'
           fsparam_u32     ("max_read",            OPT_MAX_READ),
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/fs_parser.h:120:32: note: expanded from macro 'fsparam_u32'
   #define fsparam_u32(NAME, OPT)  __fsparam(fs_param_is_u32, NAME, OPT, 0, NULL)
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/fs_parser.h:109:3: note: expanded from macro '__fsparam'
                   .name = NAME, \
                   ^~~~~~~~~~~~
   fs/fuse/inode.c:743:2: warning: suggest braces around initialization of subobject [-Wmissing-braces]
           fsparam_uid     ("user_id",             OPT_USER_ID),
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           {
   fs/fuse/inode.c:804:17: error: no member named 'uid' in 'struct fs_parse_result'
                   kuid = result.uid;
                          ~~~~~~ ^
   fs/fuse/inode.c:816:17: error: no member named 'gid' in 'struct fs_parse_result'
                   kgid = result.gid;
                          ~~~~~~ ^
   1 warning and 9 errors generated.


vim +745 fs/fuse/inode.c

d8a5ba45457e4a Miklos Szeredi 2005-09-09  738  
d7167b149943e3 Al Viro        2019-09-07  739  static const struct fs_parameter_spec fuse_fs_parameters[] = {
c30da2e981a703 David Howells  2019-03-25  740  	fsparam_string	("source",		OPT_SOURCE),
c30da2e981a703 David Howells  2019-03-25  741  	fsparam_u32	("fd",			OPT_FD),
c30da2e981a703 David Howells  2019-03-25  742  	fsparam_u32oct	("rootmode",		OPT_ROOTMODE),
b382c6a31542e9 Eric Sandeen   2024-07-02  743  	fsparam_uid	("user_id",		OPT_USER_ID),
b382c6a31542e9 Eric Sandeen   2024-07-02  744  	fsparam_gid	("group_id",		OPT_GROUP_ID),
c30da2e981a703 David Howells  2019-03-25 @745  	fsparam_flag	("default_permissions",	OPT_DEFAULT_PERMISSIONS),
c30da2e981a703 David Howells  2019-03-25 @746  	fsparam_flag	("allow_other",		OPT_ALLOW_OTHER),
c30da2e981a703 David Howells  2019-03-25 @747  	fsparam_u32	("max_read",		OPT_MAX_READ),
c30da2e981a703 David Howells  2019-03-25  748  	fsparam_u32	("blksize",		OPT_BLKSIZE),
c7eb6869632a5d David Howells  2019-03-25  749  	fsparam_string	("subtype",		OPT_SUBTYPE),
c30da2e981a703 David Howells  2019-03-25  750  	{}
d8a5ba45457e4a Miklos Szeredi 2005-09-09  751  };
d8a5ba45457e4a Miklos Szeredi 2005-09-09  752  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki