From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, hch@lst.de, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/7] libfrog: hoist free space histogram code
Date: Thu, 4 Jul 2024 07:22:59 +0200 [thread overview]
Message-ID: <20240704052259.GC19637@lst.de> (raw)
In-Reply-To: <172004320027.3392477.14495882444654849509.stgit@frogsfrogsfrogs>
> +struct histbucket
> +{
This still use the non-standard brace placement.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-07-04 5:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 21:47 [PATCHSET v30.8] xfs_scrub: use free space histograms to reduce fstrim runtime Darrick J. Wong
2024-07-03 21:47 ` [PATCH 1/7] libfrog: hoist free space histogram code Darrick J. Wong
2024-07-04 5:22 ` Christoph Hellwig [this message]
2024-07-08 17:27 ` [PATCH v30.8.1 " Darrick J. Wong
2024-07-03 21:47 ` [PATCH 2/7] libfrog: print wider columns for free space histogram Darrick J. Wong
2024-07-03 21:47 ` [PATCH 3/7] libfrog: print cdf of free space buckets Darrick J. Wong
2024-07-03 21:47 ` [PATCH 4/7] xfs_scrub: don't close stdout when closing the progress bar Darrick J. Wong
2024-07-03 21:48 ` [PATCH 5/7] xfs_scrub: remove pointless spacemap.c arguments Darrick J. Wong
2024-07-03 21:48 ` [PATCH 6/7] xfs_scrub: collect free space histograms during phase 7 Darrick J. Wong
2024-07-03 21:48 ` [PATCH 7/7] xfs_scrub: tune fstrim minlen parameter based on free space histograms Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2024-07-30 0:19 [PATCHSET v30.9 13/23] xfs_scrub: use free space histograms to reduce fstrim runtime Darrick J. Wong
2024-07-30 1:11 ` [PATCH 1/7] libfrog: hoist free space histogram code Darrick J. Wong
2024-07-02 0:50 [PATCHSET v30.7 05/16] xfs_scrub: use free space histograms to reduce fstrim runtime Darrick J. Wong
2024-07-02 1:03 ` [PATCH 1/7] libfrog: hoist free space histogram code Darrick J. Wong
2024-07-02 5:32 ` Christoph Hellwig
2024-07-03 2:47 ` Darrick J. Wong
2024-07-03 4:30 ` Christoph Hellwig
2024-07-03 4:55 ` Darrick J. Wong
2023-12-31 19:48 [PATCHSET v29.0 33/40] xfs_scrub: use free space histograms to reduce fstrim runtime Darrick J. Wong
2023-12-31 22:50 ` [PATCH 1/7] libfrog: hoist free space histogram code Darrick J. Wong
2023-05-26 0:39 [PATCHSET v25.0 0/7] xfs_scrub: use free space histograms to reduce fstrim runtime Darrick J. Wong
2023-05-26 1:50 ` [PATCH 1/7] libfrog: hoist free space histogram code Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240704052259.GC19637@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.