From: Jakub Kicinski <kuba@kernel.org>
To: Ronald Wahl <rwahl@gmx.de>
Cc: Ronald Wahl <ronald.wahl@raritan.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ks8851: Fix deadlock with the SPI chip variant
Date: Thu, 4 Jul 2024 07:44:07 -0700 [thread overview]
Message-ID: <20240704074407.4cb4ebdf@kernel.org> (raw)
In-Reply-To: <20240703160053.9892-1-rwahl@gmx.de>
On Wed, 3 Jul 2024 18:00:53 +0200 Ronald Wahl wrote:
> + bool need_wake_queue;
>
> netif_dbg(ks, intr, ks->netdev,
> "%s: txspace %d\n", __func__, tx_space);
>
> spin_lock(&ks->statelock);
> ks->tx_space = tx_space;
> - if (netif_queue_stopped(ks->netdev))
> - netif_wake_queue(ks->netdev);
> + need_wake_queue = netif_queue_stopped(ks->netdev);
> spin_unlock(&ks->statelock);
> + if (need_wake_queue)
> + netif_wake_queue(ks->netdev);
xmit runs in BH, this is just one way you can hit this deadlock
better fix would be to make sure statelock is always taken
using spin_lock_bh()
--
pw-bot: cr
next prev parent reply other threads:[~2024-07-04 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 16:00 [PATCH] ks8851: Fix deadlock with the SPI chip variant Ronald Wahl
2024-07-04 14:44 ` Jakub Kicinski [this message]
2024-07-04 20:18 ` Ronald Wahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240704074407.4cb4ebdf@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ronald.wahl@raritan.com \
--cc=rwahl@gmx.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.