All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	linux-arm-kernel@lists.infradead.org,
	"Christophe Leroy" <christophe.leroy@csgroup.eu>,
	"Herve Codina" <herve.codina@bootlin.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Vladimir Oltean" <vladimir.oltean@nxp.com>,
	"Köry Maincent" <kory.maincent@bootlin.com>,
	"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
	"Marek Behún" <kabel@kernel.org>,
	"Piergiorgio Beruto" <piergiorgio.beruto@gmail.com>,
	"Oleksij Rempel" <o.rempel@pengutronix.de>,
	"Nicolò Veronese" <nicveronese@gmail.com>,
	"Simon Horman" <horms@kernel.org>,
	mwojtas@chromium.org, "Nathan Chancellor" <nathan@kernel.org>,
	"Antoine Tenart" <atenart@kernel.org>,
	"Marc Kleine-Budde" <mkl@pengutronix.de>,
	"Dan Carpenter" <dan.carpenter@linaro.org>
Subject: Re: [PATCH net-next v15 07/14] net: ethtool: Introduce a command to list PHYs on an interface
Date: Thu, 4 Jul 2024 10:03:02 +0200	[thread overview]
Message-ID: <20240704100302.2c9983ca@fedora-2.home> (raw)
In-Reply-To: <ZoVlnLkXuJ0J/da3@shell.armlinux.org.uk>

Hello Russell,

On Wed, 3 Jul 2024 15:52:12 +0100
"Russell King (Oracle)" <linux@armlinux.org.uk> wrote:

> So, if we want to report the ID of the PHY, then really we need to
> report the clause 22 ID, and at least all the devids of each MMD in
> a clause 45 PHY. Alternatively, we may decide it isn't worth the
> effort of reporting any of these IDs.
> 
> However, reporting just the clause 22 ID would be a design error
> IMHO.

I don't have any strong reason to keep exporting the PHY id. Reporting
the driver name is enough to get a good idea of the nature of the
device, I'll drop that field then.

Thanks for taking a look,

Maxime



  reply	other threads:[~2024-07-04  8:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03 14:07 [PATCH net-next v15 00/14] Introduce PHY listing and link_topology tracking Maxime Chevallier
2024-07-03 14:07 ` [PATCH net-next v15 01/14] net: phy: Introduce ethernet link topology representation Maxime Chevallier
2024-07-03 14:07 ` [PATCH net-next v15 02/14] net: sfp: pass the phy_device when disconnecting an sfp module's PHY Maxime Chevallier
2024-07-03 14:07 ` [PATCH net-next v15 03/14] net: phy: add helpers to handle sfp phy connect/disconnect Maxime Chevallier
2024-07-03 14:07 ` [PATCH net-next v15 04/14] net: sfp: Add helper to return the SFP bus name Maxime Chevallier
2024-07-03 15:36   ` Russell King (Oracle)
2024-07-04  8:04     ` Maxime Chevallier
2024-07-03 14:07 ` [PATCH net-next v15 05/14] net: ethtool: Allow passing a phy index for some commands Maxime Chevallier
2024-07-03 14:07 ` [PATCH net-next v15 06/14] netlink: specs: add phy-index as a header parameter Maxime Chevallier
2024-07-03 14:07 ` [PATCH net-next v15 07/14] net: ethtool: Introduce a command to list PHYs on an interface Maxime Chevallier
2024-07-03 14:52   ` Russell King (Oracle)
2024-07-04  8:03     ` Maxime Chevallier [this message]
2024-07-03 14:07 ` [PATCH net-next v15 08/14] netlink: specs: add ethnl PHY_GET command set Maxime Chevallier
2024-07-03 14:07 ` [PATCH net-next v15 09/14] net: ethtool: plca: Target the command to the requested PHY Maxime Chevallier
2024-07-03 14:08 ` [PATCH net-next v15 10/14] net: ethtool: pse-pd: " Maxime Chevallier
2024-07-03 14:08 ` [PATCH net-next v15 11/14] net: ethtool: cable-test: " Maxime Chevallier
2024-07-03 14:08 ` [PATCH net-next v15 12/14] net: ethtool: strset: Remove unnecessary check on genl_info Maxime Chevallier
2024-07-03 14:08 ` [PATCH net-next v15 13/14] net: ethtool: strset: Allow querying phy stats by index Maxime Chevallier
2024-07-03 14:08 ` [PATCH net-next v15 14/14] Documentation: networking: document phy_link_topology Maxime Chevallier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240704100302.2c9983ca@fedora-2.home \
    --to=maxime.chevallier@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=atenart@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=dan.carpenter@linaro.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=herve.codina@bootlin.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kabel@kernel.org \
    --cc=kory.maincent@bootlin.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mkl@pengutronix.de \
    --cc=mwojtas@chromium.org \
    --cc=nathan@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicveronese@gmail.com \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=piergiorgio.beruto@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.