From: Stephen Hemminger <stephen@networkplumber.org>
To: Bastian Krause <bst@pengutronix.de>
Cc: Fabian Pfitzner <f.pfitzner@pengutronix.de>,
mkubecek@suse.cz, netdev@vger.kernel.org
Subject: Re: [PATCH ethtool 1/2]: add json support for base command
Date: Thu, 4 Jul 2024 11:05:56 -0700 [thread overview]
Message-ID: <20240704110556.1ebea204@hermes.local> (raw)
In-Reply-To: <f30c683d-303f-40ff-967a-7c33ecc07202@pengutronix.de>
On Thu, 4 Jul 2024 17:21:16 +0200
Bastian Krause <bst@pengutronix.de> wrote:
> > if (pause)
> > - printf("%s\n", asym ? "Symmetric Receive-only" : "Symmetric");
> > + print_string(PRINT_ANY, label_json, "%s\n",
> > + asym ? "Symmetric Receive-only" : "Symmetric");
> > else
> > - printf("%s\n", asym ? "Transmit-only" : "No");
> > + print_string(PRINT_ANY, label_json, "%s\n", asym ? "Transmit-only" : "No");
JSON has boolean type, why is this not ysed here?
next prev parent reply other threads:[~2024-07-04 18:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 11:44 [PATCH ethtool 1/2]: add json support for base command Fabian Pfitzner
2024-06-03 11:44 ` [PATCH ethtool 2/2]: add json support for --show-eee command Fabian Pfitzner
2024-07-02 8:21 ` [PATCH ethtool 1/2]: add json support for base command Fabian Pfitzner
2024-07-02 9:00 ` Michal Kubecek
2024-07-04 15:21 ` Bastian Krause
2024-07-04 18:05 ` Stephen Hemminger [this message]
2024-07-05 8:24 ` Bastian Krause
2024-07-05 13:58 ` Bastian Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240704110556.1ebea204@hermes.local \
--to=stephen@networkplumber.org \
--cc=bst@pengutronix.de \
--cc=f.pfitzner@pengutronix.de \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.