All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Rick Wertenbroek <rick.wertenbroek@gmail.com>
Cc: abaci@linux.alibaba.com, arnd@arndb.de,
	gregkh@linuxfoundation.org, jiapeng.chong@linux.alibaba.com,
	kishon@kernel.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, manivannan.sadhasivam@linaro.org
Subject: Re: Re: [PATCH -next v2] misc: pci_endpoint_test: Remove some unused functions
Date: Thu, 4 Jul 2024 23:22:20 +0900	[thread overview]
Message-ID: <20240704142220.GB1215610@rocinante> (raw)
In-Reply-To: <20240704134953.2360738-1-rick.wertenbroek@gmail.com>

Hello,

> > > These functions are defined in the pci_endpoint_test.c file, but not
> > > called elsewhere, so delete these unused functions.
> > > 
> > > drivers/misc/pci_endpoint_test.c:144:19: warning: unused function 'pci_endpoint_test_bar_readl'.
> > > drivers/misc/pci_endpoint_test.c:150:20: warning: unused function 'pci_endpoint_test_bar_writel'.
> > 
> > Have you see my question to the first version of this patch?
[...]
> The functions were removed in this patch : https://lore.kernel.org/linux-pci/20240322164139.678228-1-cassel@kernel.org/
> So in linux-next they are indeed not used anymore.
> 
> You applied it to misc : https://lore.kernel.org/linux-pci/20240517100929.GB202520@rocinante/

Ahh, it was sometime in May...  I assumed we already got this into the
mainline, hence my confusion.  Hard to remember what went out when.

Also, I looked only at our head branch first, as I always do, before
I noticed the updated tag.

Thank you for getting back to me.  Appreciated.

I will get this applied against our pending "misc" branch, should sort
out the warnings on next.

	Krzysztof

  reply	other threads:[~2024-07-04 14:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-04  2:32 [PATCH -next v2] misc: pci_endpoint_test: Remove some unused functions Jiapeng Chong
2024-07-04  7:14 ` Krzysztof Wilczyński
2024-07-04 12:58   ` Greg KH
2024-07-04 14:00     ` Rick Wertenbroek
2024-07-04 13:49   ` Rick Wertenbroek
2024-07-04 14:22     ` Krzysztof Wilczyński [this message]
2024-07-06  3:18 ` Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240704142220.GB1215610@rocinante \
    --to=kw@linux.com \
    --cc=abaci@linux.alibaba.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=kishon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=rick.wertenbroek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.