From: Jeff Layton <jlayton@kernel.org>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>
Cc: Dave Chinner <david@fromorbit.com>,
Andi Kleen <ak@linux.intel.com>,
Christoph Hellwig <hch@infradead.org>,
kernel-team@fb.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-mm@kvack.org, linux-nfs@vger.kernel.org,
linux-doc@vger.kernel.org, Jeff Layton <jlayton@kernel.org>
Subject: [PATCH v3 3/9] fs: add percpu counters to count fine vs. coarse timestamps
Date: Fri, 05 Jul 2024 13:02:37 -0400 [thread overview]
Message-ID: <20240705-mgtime-v3-3-85b2daa9b335@kernel.org> (raw)
In-Reply-To: <20240705-mgtime-v3-0-85b2daa9b335@kernel.org>
Keep a pair of percpu counters so we can track what proportion of
timestamps is fine-grained.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/inode.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 48 insertions(+), 1 deletion(-)
diff --git a/fs/inode.c b/fs/inode.c
index 4ab7aee3558c..2e5610ebb205 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -21,6 +21,8 @@
#include <linux/list_lru.h>
#include <linux/iversion.h>
#include <linux/rw_hint.h>
+#include <linux/seq_file.h>
+#include <linux/debugfs.h>
#include <trace/events/writeback.h>
#define CREATE_TRACE_POINTS
#include <trace/events/timestamp.h>
@@ -69,6 +71,11 @@ static __cacheline_aligned_in_smp DEFINE_SPINLOCK(inode_hash_lock);
* converted to the realtime clock on an as-needed basis.
*/
static __cacheline_aligned_in_smp ktime_t ctime_floor;
+
+static struct percpu_counter mg_ctime_updates;
+static struct percpu_counter mg_floor_swaps;
+static struct percpu_counter mg_ctime_swaps;
+
/*
* Empty aops. Can be used for the cases where the user does not
* define any of the address_space operations.
@@ -2662,11 +2669,14 @@ struct timespec64 inode_set_ctime_current(struct inode *inode)
* as good, so keep it.
*/
old = cmpxchg(&ctime_floor, floor, fine);
- if (old != floor)
+ if (old == floor)
+ percpu_counter_inc(&mg_floor_swaps);
+ else
fine = old;
now = ktime_mono_to_real(fine);
}
}
+ percpu_counter_inc(&mg_ctime_updates);
now_ts = ktime_to_timespec64(now);
retry:
/* Try to swap the nsec value into place. */
@@ -2676,6 +2686,7 @@ struct timespec64 inode_set_ctime_current(struct inode *inode)
/* If swap occurred, then we're (mostly) done */
if (cur == cns) {
inode->i_ctime_sec = now_ts.tv_sec;
+ percpu_counter_inc(&mg_ctime_swaps);
} else {
/*
* Was the change due to someone marking the old ctime QUERIED?
@@ -2745,3 +2756,39 @@ umode_t mode_strip_sgid(struct mnt_idmap *idmap,
return mode & ~S_ISGID;
}
EXPORT_SYMBOL(mode_strip_sgid);
+
+static int mgts_show(struct seq_file *s, void *p)
+{
+ u64 ctime_updates = percpu_counter_sum(&mg_ctime_updates);
+ u64 floor_swaps = percpu_counter_sum(&mg_floor_swaps);
+ u64 ctime_swaps = percpu_counter_sum(&mg_ctime_swaps);
+
+ seq_printf(s, "%llu %llu %llu\n", ctime_updates, ctime_swaps, floor_swaps);
+ return 0;
+}
+
+DEFINE_SHOW_ATTRIBUTE(mgts);
+
+static int __init mg_debugfs_init(void)
+{
+ int ret = percpu_counter_init(&mg_ctime_updates, 0, GFP_KERNEL);
+
+ if (ret)
+ return ret;
+
+ ret = percpu_counter_init(&mg_floor_swaps, 0, GFP_KERNEL);
+ if (ret) {
+ percpu_counter_destroy(&mg_ctime_updates);
+ return ret;
+ }
+
+ ret = percpu_counter_init(&mg_ctime_swaps, 0, GFP_KERNEL);
+ if (ret) {
+ percpu_counter_destroy(&mg_floor_swaps);
+ percpu_counter_destroy(&mg_ctime_updates);
+ return ret;
+ }
+ debugfs_create_file("multigrain_timestamps", S_IFREG | S_IRUGO, NULL, NULL, &mgts_fops);
+ return 0;
+}
+late_initcall(mg_debugfs_init);
--
2.45.2
next prev parent reply other threads:[~2024-07-05 17:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 17:02 [PATCH v3 0/9] fs: multigrain timestamp redux Jeff Layton
2024-07-05 17:02 ` [PATCH v3 1/9] fs: add infrastructure for multigrain timestamps Jeff Layton
2024-07-08 12:30 ` Jeff Layton
2024-07-08 15:24 ` Jeff Layton
2024-07-08 15:32 ` Uros Bizjak
2024-07-05 17:02 ` [PATCH v3 2/9] fs: tracepoints around multigrain timestamp events Jeff Layton
2024-07-05 18:07 ` Steven Rostedt
2024-07-05 18:16 ` Jeff Layton
2024-07-05 17:02 ` Jeff Layton [this message]
2024-07-07 20:53 ` [PATCH v3 3/9] fs: add percpu counters to count fine vs. coarse timestamps kernel test robot
2024-07-05 17:02 ` [PATCH v3 4/9] fs: have setattr_copy handle multigrain timestamps appropriately Jeff Layton
2024-07-05 17:02 ` [PATCH v3 5/9] Documentation: add a new file documenting multigrain timestamps Jeff Layton
2024-07-05 20:59 ` Randy Dunlap
2024-07-05 17:02 ` [PATCH v3 6/9] xfs: switch to " Jeff Layton
2024-07-05 17:02 ` [PATCH v3 7/9] ext4: " Jeff Layton
2024-07-05 17:02 ` [PATCH v3 8/9] btrfs: convert " Jeff Layton
2024-07-05 17:02 ` [PATCH v3 9/9] tmpfs: add support for " Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240705-mgtime-v3-3-85b2daa9b335@kernel.org \
--to=jlayton@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=clm@fb.com \
--cc=corbet@lwn.net \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=dsterba@suse.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.