From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/2] virtio-balloon: make it spec compliant
Date: Fri, 5 Jul 2024 06:19:51 -0400 [thread overview]
Message-ID: <20240705061647-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <dc0a5a70-d691-4d54-ae00-0beb74f4c399@redhat.com>
On Fri, Jul 05, 2024 at 12:15:30PM +0200, David Hildenbrand wrote:
> On 05.07.24 12:08, Michael S. Tsirkin wrote:
> > Currently, if VIRTIO_BALLOON_F_FREE_PAGE_HINT is off but
> > VIRTIO_BALLOON_F_REPORTING is on, then the reporting vq
> > gets number 3 while spec says it's number 4.
> > It happens to work because the qemu virtio pci driver
> > is *also* out of spec.
>
> I have to ask the obvious: maybe the spec is wrong and we have to refine
> that?
Well having vq function shift depending on features is certainly
messy ...
How do we know no one implemented the spec as written though?
--
MST
next prev parent reply other threads:[~2024-07-05 10:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 10:08 [PATCH 0/2] virtio-balloon: make it spec compliant Michael S. Tsirkin
2024-07-05 10:08 ` [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU Michael S. Tsirkin
2024-07-10 3:11 ` David Hildenbrand
2024-07-10 3:23 ` Jason Wang
2024-07-10 6:16 ` Michael S. Tsirkin
2024-07-10 7:37 ` Jason Wang
2024-07-10 11:36 ` Michael S. Tsirkin
2024-07-05 10:09 ` [PATCH 2/2] virtio: fix vq # when vq skipped Michael S. Tsirkin
2024-07-10 3:11 ` David Hildenbrand
2024-07-10 3:25 ` Jason Wang
2024-07-05 10:15 ` [PATCH 0/2] virtio-balloon: make it spec compliant David Hildenbrand
2024-07-05 10:19 ` Michael S. Tsirkin [this message]
2024-07-05 11:00 ` David Hildenbrand
2024-07-05 11:38 ` Michael S. Tsirkin
2024-07-10 3:09 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240705061647-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.