From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, mst@redhat.com, jasowang@redhat.com,
xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
pbonzini@redhat.com, stefanha@redhat.com, hare@suse.de,
kbusch@kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, virtualization@lists.linux.dev
Subject: Re: [PATCH 2/5] block: Validate logical block size in blk_validate_limits()
Date: Fri, 5 Jul 2024 14:38:42 +0200 [thread overview]
Message-ID: <20240705123842.GA29995@lst.de> (raw)
In-Reply-To: <d4f02398-977f-47ef-9868-d3b08313c126@oracle.com>
On Fri, Jul 05, 2024 at 01:34:37PM +0100, John Garry wrote:
>> This should print a message. Unfortunately we don't have the device
>> name here (for that we'd need to set it at disk/queue allocation time,
>> which will require a bit of work), but even without that it will be
>> very useful.
>
> Ok, I can print a message, like:
>
> pr_warn("Invalid logical block size (%d)\n", bsize);
>
> I am wary though that userspace could trigger this message from the various
> ioctls to set the bsize.
As anything ending up here is a configuration interface, such a message
should be perfectly fine.
next prev parent reply other threads:[~2024-07-05 12:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 11:51 [PATCH 0/5] Validate logical block size in blk_validate_limits() John Garry
2024-07-05 11:51 ` [PATCH 1/5] virtio_blk: Fix default logical block size fallback John Garry
2024-07-05 12:14 ` Christoph Hellwig
2024-07-08 7:39 ` Stefan Hajnoczi
2024-07-05 11:51 ` [PATCH 2/5] block: Validate logical block size in blk_validate_limits() John Garry
2024-07-05 12:16 ` Christoph Hellwig
2024-07-05 12:34 ` John Garry
2024-07-05 12:38 ` Christoph Hellwig [this message]
2024-07-05 11:51 ` [PATCH 3/5] null_blk: Don't bother validating blocksize John Garry
2024-07-05 12:17 ` Christoph Hellwig
2024-07-05 11:51 ` [PATCH 4/5] virtio_blk: " John Garry
2024-07-05 12:17 ` Christoph Hellwig
2024-07-08 7:45 ` Stefan Hajnoczi
2024-07-05 11:51 ` [PATCH 5/5] loop: " John Garry
2024-07-05 12:18 ` Christoph Hellwig
2024-07-05 15:29 ` [PATCH 0/5] Validate logical block size in blk_validate_limits() Michael S. Tsirkin
2024-07-05 16:06 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240705123842.GA29995@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=eperezma@redhat.com \
--cc=hare@suse.de \
--cc=jasowang@redhat.com \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.