All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Dave Chinner <david@fromorbit.com>,
	willy@infradead.org, chandan.babu@oracle.com, djwong@kernel.org,
	brauner@kernel.org, akpm@linux-foundation.org,
	yang@os.amperecomputing.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, john.g.garry@oracle.com,
	linux-fsdevel@vger.kernel.org, p.raghav@samsung.com,
	mcgrof@kernel.org, gost.dev@samsung.com,
	cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de,
	Zi Yan <ziy@nvidia.com>
Subject: Re: [PATCH v9 06/10] iomap: fix iomap_dio_zero() for fs bs > system page size
Date: Fri, 5 Jul 2024 14:19:11 +0000	[thread overview]
Message-ID: <20240705141911.zamclkk7iajcvwik@quentin> (raw)
In-Reply-To: <da1d2eea-b7b1-467c-84e0-623d4ec3af55@suse.de>

> > > 
> > > There are other users of ZERO_PAGE, most notably in fs/direct-io.c and
> > > block/blk-lib.c. Any chance to make this available to them?
> > 
> > Please, no.
> > 
> > We need to stop feature creeping this patchset and bring it to a
> > close. If changing code entirely unrelated to this patchset is
> > desired, please do it as a separate independent set of patches.
> > 
> Agree; it was a suggestion only.

I was going to say the same thing that Dave said as well as we are 
almost there with this series :)

But I will add your suggestion in my TODO. It would be good to have some
common infra to avoid allocating larger zero pages all over the place.

> 
> Pankaj, you can add my:
> 
> Reviewed-by: Hannes Reinecke <hare@suse.de>

Thanks Hannes.

  reply	other threads:[~2024-07-05 14:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-04 11:23 [PATCH v9 00/10] enable bs > ps in XFS Pankaj Raghav (Samsung)
2024-07-04 11:23 ` [PATCH v9 01/10] fs: Allow fine-grained control of folio sizes Pankaj Raghav (Samsung)
2024-07-04 11:23 ` [PATCH v9 02/10] filemap: allocate mapping_min_order folios in the page cache Pankaj Raghav (Samsung)
2024-07-04 11:23 ` [PATCH v9 03/10] readahead: allocate folios with mapping_min_order in readahead Pankaj Raghav (Samsung)
2024-07-04 11:23 ` [PATCH v9 04/10] mm: split a folio in minimum folio order chunks Pankaj Raghav (Samsung)
2024-07-08 13:53   ` Zi Yan
2024-07-09 11:04     ` Pankaj Raghav (Samsung)
2024-07-09 12:49       ` Zi Yan
2024-07-04 11:23 ` [PATCH v9 05/10] filemap: cap PTE range to be created to allowed zero fill in folio_map_range() Pankaj Raghav (Samsung)
2024-07-04 11:23 ` [PATCH v9 06/10] iomap: fix iomap_dio_zero() for fs bs > system page size Pankaj Raghav (Samsung)
2024-07-04 15:37   ` Hannes Reinecke
2024-07-04 22:13     ` Dave Chinner
2024-07-05  6:14       ` Hannes Reinecke
2024-07-05 14:19         ` Pankaj Raghav (Samsung) [this message]
2024-07-08 17:56   ` Darrick J. Wong
2024-07-08 22:18   ` Dave Chinner
2024-07-04 11:23 ` [PATCH v9 07/10] xfs: use kvmalloc for xattr buffers Pankaj Raghav (Samsung)
2024-07-04 11:23 ` [PATCH v9 08/10] xfs: expose block size in stat Pankaj Raghav (Samsung)
2024-07-04 11:23 ` [PATCH v9 09/10] xfs: make the calculation generic in xfs_sb_validate_fsb_count() Pankaj Raghav (Samsung)
2024-07-04 11:23 ` [PATCH v9 10/10] xfs: enable block size larger than page size support Pankaj Raghav (Samsung)
2024-07-08 22:12 ` [PATCH v9 00/10] enable bs > ps in XFS Luis Chamberlain
2024-07-08 22:27   ` Matthew Wilcox
2024-07-08 22:40   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240705141911.zamclkk7iajcvwik@quentin \
    --to=kernel@pankajraghav.com \
    --cc=akpm@linux-foundation.org \
    --cc=brauner@kernel.org \
    --cc=chandan.babu@oracle.com \
    --cc=cl@os.amperecomputing.com \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=gost.dev@samsung.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=john.g.garry@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=p.raghav@samsung.com \
    --cc=willy@infradead.org \
    --cc=yang@os.amperecomputing.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.