From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30937C3271E for ; Fri, 5 Jul 2024 20:49:56 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WG5HQ6JlTz3fTS for ; Sat, 6 Jul 2024 06:49:54 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=lists.ozlabs.org) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4WG5H01NWSz3cWc for ; Sat, 6 Jul 2024 06:49:30 +1000 (AEST) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 465KjtGq002299; Fri, 5 Jul 2024 15:45:56 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 465KjrP6002290; Fri, 5 Jul 2024 15:45:53 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 5 Jul 2024 15:45:52 -0500 From: Segher Boessenkool To: Michael Ellerman Subject: Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29 Message-ID: <20240705204552.GD19790@gate.crashing.org> References: <3ab66fab-c3f2-4bed-a04d-a10c57dcdd9b@xenosoft.de> <86zfqzhgys.wl-maz@kernel.org> <874j95jrur.fsf@mail.lhotse> <3baff554-e8f6-42b0-b931-207175a4d8fd@xenosoft.de> <87o77ciqj8.fsf@mail.lhotse> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o77ciqj8.fsf@mail.lhotse> User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: apatel@ventanamicro.com, Rob Herring , Darren Stevens , mad skateman , DTML , Marc Zyngier , Linux Kernel Mailing List , "R.T.Dickinson" , Christian Zigotzky , Matthew Leaman , linuxppc-dev , Christian Zigotzky Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jul 05, 2024 at 11:19:39AM +1000, Michael Ellerman wrote: > + prom_printf("nemo: deleting interrupt-map properties\n"); > + rc = call_prom("interpret", 1, 1, > + " s\" /pxp@0,e0000000\" find-device" > + " s\" interrupt-map\" delete-property" > + " s\" interrupt-map-mask\" delete-property" > + " device-end"); > + prom_printf("nemo: interpret returned %d\n", rc); It's very fragile no matter what. If some scriupt does something bad, just add something better for it? You can replace anything by just adding something with the same name! Segher From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1AEB3178395; Fri, 5 Jul 2024 21:06:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=63.228.1.57 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720213614; cv=none; b=q/C8XM1QmqxuwzbIWjdPzegtUhsfm7mJcLLBM2vQzig3MY58xKVIzA5Wwbivk+obLpalX+36drYxq0F0fmxnSZDypzY4mv9ofp7hOeXU6f5zeBNPO8ErnenwHLRlviZNwp083PAeILt7lp1dL/ES75S7jhlQ2ZLgw8NvXJUcpEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720213614; c=relaxed/simple; bh=nDCY5LYEV9Y9sc1gkGZbDSb/JXXsS1WcfZlgDg7Z8W0=; h=Date:From:To:Cc:Subject:Message-ID:References:Mime-Version: Content-Type:Content-Disposition:In-Reply-To; b=bff+ggikgJBF4CsWyEXlBCxxtU2ONgI0t6pa3K7RqI+TfjmzE+xrWq2SKp15/5m0TbkVsPb68/5O2HiydXuxtRA14dwgpaNPCe35LVc543xq6Voj+2RKAJDIYlArI/co6oeQshxgNj7ABit83OdT7vUtKLiXYsLVaJaJ429gMiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org; spf=pass smtp.mailfrom=kernel.crashing.org; arc=none smtp.client-ip=63.228.1.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 465KjtGq002299; Fri, 5 Jul 2024 15:45:56 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 465KjrP6002290; Fri, 5 Jul 2024 15:45:53 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 5 Jul 2024 15:45:52 -0500 From: Segher Boessenkool To: Michael Ellerman Cc: Christian Zigotzky , Marc Zyngier , apatel@ventanamicro.com, Rob Herring , Darren Stevens , "R.T.Dickinson" , DTML , Linux Kernel Mailing List , mad skateman , Matthew Leaman , linuxppc-dev , Christian Zigotzky Subject: Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29 Message-ID: <20240705204552.GD19790@gate.crashing.org> References: <3ab66fab-c3f2-4bed-a04d-a10c57dcdd9b@xenosoft.de> <86zfqzhgys.wl-maz@kernel.org> <874j95jrur.fsf@mail.lhotse> <3baff554-e8f6-42b0-b931-207175a4d8fd@xenosoft.de> <87o77ciqj8.fsf@mail.lhotse> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o77ciqj8.fsf@mail.lhotse> User-Agent: Mutt/1.4.2.3i On Fri, Jul 05, 2024 at 11:19:39AM +1000, Michael Ellerman wrote: > + prom_printf("nemo: deleting interrupt-map properties\n"); > + rc = call_prom("interpret", 1, 1, > + " s\" /pxp@0,e0000000\" find-device" > + " s\" interrupt-map\" delete-property" > + " s\" interrupt-map-mask\" delete-property" > + " device-end"); > + prom_printf("nemo: interpret returned %d\n", rc); It's very fragile no matter what. If some scriupt does something bad, just add something better for it? You can replace anything by just adding something with the same name! Segher