From: Christoph Hellwig <hch@lst.de>
To: Kundan Kumar <kundan.kumar@samsung.com>
Cc: axboe@kernel.dk, hch@lst.de, willy@infradead.org,
kbusch@kernel.org, linux-block@vger.kernel.org,
joshi.k@samsung.com, mcgrof@kernel.org, anuj20.g@samsung.com,
nj.shetty@samsung.com, c.gameti@samsung.com,
gost.dev@samsung.com
Subject: Re: [PATCH v7 4/4] block: unpin user pages belonging to a folio at once
Date: Sat, 6 Jul 2024 10:12:55 +0200 [thread overview]
Message-ID: <20240706081255.GC15556@lst.de> (raw)
In-Reply-To: <20240706081021.GB15556@lst.de>
On Sat, Jul 06, 2024 at 10:10:21AM +0200, Christoph Hellwig wrote:
> Also this means we know the loop doesn't do anything if mark_dirty is
> false, which is another trivial check that can move into
> bio_release_pages. As this optimization already applies as-is I'll
> send a prep patch for it.
>
> so that we can avoid the npages calculation for the !BIO_PAGE_PINNED
> case. Morover having the BIO_PAGE_PINNED knowledge there means we
> can skip the entire loop for !BIO_PAGE_PINNED &&
Braino - we're obviously already skipping it for all !BIO_PAGE_PINNED
case. So discard most of this except for that fact that we should
skip the wrapper doing the extra BIO_PAGE_PINNED checks.
prev parent reply other threads:[~2024-07-06 8:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240704071118epcas5p141ef3c2cbcde0ce31d342b5743a7dcf1@epcas5p1.samsung.com>
2024-07-04 7:03 ` [PATCH v7 0/4] block: add larger order folio instead of pages Kundan Kumar
2024-07-04 7:03 ` [PATCH v7 1/4] block: Added folio-lized version of bvec_try_merge_hw_page() Kundan Kumar
2024-07-06 8:01 ` Christoph Hellwig
2024-07-04 7:03 ` [PATCH v7 2/4] block: Added folio-lized version of bio_add_hw_page() Kundan Kumar
2024-07-06 8:02 ` Christoph Hellwig
2024-07-04 7:03 ` [PATCH v7 3/4] block: introduce folio awareness and add a bigger size from folio Kundan Kumar
2024-07-06 8:03 ` Christoph Hellwig
2024-07-08 8:24 ` kernel test robot
2024-07-08 8:24 ` [LTP] " kernel test robot
2024-07-04 7:03 ` [PATCH v7 4/4] block: unpin user pages belonging to a folio at once Kundan Kumar
2024-07-06 8:10 ` Christoph Hellwig
2024-07-06 8:12 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240706081255.GC15556@lst.de \
--to=hch@lst.de \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=c.gameti@samsung.com \
--cc=gost.dev@samsung.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kundan.kumar@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nj.shetty@samsung.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.