All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v3 2/3] PCI/NPEM: Add Native PCIe Enclosure Management support
Date: Sat, 6 Jul 2024 12:11:49 +0800	[thread overview]
Message-ID: <202407061155.ONPs0ANe-lkp@intel.com> (raw)
In-Reply-To: <20240705125436.26057-3-mariusz.tkaczyk@linux.intel.com>

Hi Mariusz,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.10-rc6 next-20240703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mariusz-Tkaczyk/leds-Init-leds-class-earlier/20240706-015012
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20240705125436.26057-3-mariusz.tkaczyk%40linux.intel.com
patch subject: [PATCH v3 2/3] PCI/NPEM: Add Native PCIe Enclosure Management support
config: microblaze-allyesconfig (https://download.01.org/0day-ci/archive/20240706/202407061155.ONPs0ANe-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240706/202407061155.ONPs0ANe-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407061155.ONPs0ANe-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/pci/npem.c:143: warning: Function parameter or struct member 'active_inds_initialized' not described in 'npem'
>> drivers/pci/npem.c:143: warning: Excess struct member 'flags' description in 'npem'


vim +143 drivers/pci/npem.c

   111	
   112	/**
   113	 * struct npem - NPEM device properties
   114	 * @dev: PCIe device this driver is attached to
   115	 * @ops: Backend specific callbacks
   116	 * @lock: serialized accessing npem device from multiple LED devices
   117	 * @pos: NPEM backed only, NPEM capability offset
   118	 * @supported_indications: bit mask of supported indications
   119	 *			   non-indication and reserved bits are cleared
   120	 * @active_indications: bit mask of active indications
   121	 *			non-indication and reserved bits are cleared
   122	 * @flags: npem device control flags
   123	 * @led_cnt: Supported LEDs count
   124	 * @leds: supported LEDs
   125	 */
   126	struct npem {
   127		struct pci_dev *dev;
   128		const struct npem_ops *ops;
   129		struct mutex lock;
   130		u16 pos;
   131		u32 supported_indications;
   132		u32 active_indications;
   133	
   134		/*
   135		 * Use lazy loading for active_indications to not play with initcalls.
   136		 * It is needed to allow _DSM initialization on DELL platforms, where
   137		 * ACPI_IPMI module is needed.
   138		 */
   139		unsigned int active_inds_initialized:1;
   140	
   141		int led_cnt;
   142		struct npem_led leds[];
 > 143	};
   144	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2024-07-06  4:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05 12:54 [PATCH v3 0/3] PCIe Enclosure LED Management Mariusz Tkaczyk
2024-07-05 12:54 ` [PATCH v3 1/3] leds: Init leds class earlier Mariusz Tkaczyk
2024-07-05 12:58   ` Christoph Hellwig
2024-07-05 12:54 ` [PATCH v3 2/3] PCI/NPEM: Add Native PCIe Enclosure Management support Mariusz Tkaczyk
2024-07-05 13:02   ` Christoph Hellwig
2024-07-05 13:22     ` Mariusz Tkaczyk
2024-07-05 13:29       ` Christoph Hellwig
2024-07-06  4:11   ` kernel test robot [this message]
2024-07-08 11:33   ` Ilpo Järvinen
2024-07-08 14:24     ` Mariusz Tkaczyk
2024-07-08 16:13       ` Ilpo Järvinen
2024-07-08 14:27     ` Lukas Wunner
2024-07-05 12:54 ` [PATCH v3 3/3] PCI/NPEM: Add _DSM PCIe SSD status LED management Mariusz Tkaczyk
2024-07-05 13:04   ` Christoph Hellwig
2024-07-05 14:07     ` Lukas Wunner
2024-07-08 10:14       ` Christoph Hellwig
2024-07-08 11:39   ` Ilpo Järvinen
2024-07-05 19:11 ` [PATCH v3 0/3] PCIe Enclosure LED Management stuart hayes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202407061155.ONPs0ANe-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=mariusz.tkaczyk@linux.intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.