From: Greg KH <gregkh@linuxfoundation.org>
To: WangYuli <wangyuli@uniontech.com>
Cc: stable@vger.kernel.org, sashal@kernel.org, ast@kernel.org,
keescook@chromium.org, linux-hardening@vger.kernel.org,
christophe.leroy@csgroup.eu, catalin.marinas@arm.com,
song@kernel.org, puranjay12@gmail.com, daniel@iogearbox.net,
andrii@kernel.org, martin.lau@linux.dev, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, illusionist.neo@gmail.com,
linux@armlinux.org.uk, bpf@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, chenhuacai@kernel.org,
kernel@xen0n.name, loongarch@lists.linux.dev,
johan.almbladh@anyfinetworks.com, paulburton@kernel.org,
tsbogend@alpha.franken.de, linux-mips@vger.kernel.org,
deller@gmx.de, linux-parisc@vger.kernel.org, iii@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com,
borntraeger@linux.ibm.com, svens@linux.ibm.com,
linux-s390@vger.kernel.org, davem@davemloft.net,
sparclinux@vger.kernel.org, kuba@kernel.org, hawk@kernel.org,
netdev@vger.kernel.org, dsahern@kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, guanwentao@uniontech.com,
baimingcong@uniontech.com
Subject: Re: [PATCH] Revert "bpf: Take return from set_memory_rox() into account with bpf_jit_binary_lock_ro()" for linux-6.6.37
Date: Sat, 6 Jul 2024 11:30:00 +0200 [thread overview]
Message-ID: <2024070631-unrivaled-fever-8548@gregkh> (raw)
In-Reply-To: <5A29E00D83AB84E3+20240706031101.637601-1-wangyuli@uniontech.com>
On Sat, Jul 06, 2024 at 11:11:01AM +0800, WangYuli wrote:
> This reverts commit 08f6c05feb1db21653e98ca84ea04ca032d014c7.
>
> Upstream commit e60adf513275 ("bpf: Take return from set_memory_rox() into account with bpf_jit_binary_lock_ro()")
> depends on
> upstream commit 1dad391daef1 ("bpf, arm64: use bpf_prog_pack for memory management").
>
> It will cause a compilation warning on the arm64 if it's not merged:
> arch/arm64/net/bpf_jit_comp.c: In function ‘bpf_int_jit_compile’:
> arch/arm64/net/bpf_jit_comp.c:1651:17: warning: ignoring return value of ‘bpf_jit_binary_lock_ro’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 1651 | bpf_jit_binary_lock_ro(header);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> This will prevent the kernel with the '-Werror' compile option from
> being compiled successfully.
>
> We might as well revert this commit in linux-6.6.37 to solve the
> problem in a simple way.
This makes it sound like you are reverting this because of a build
error, which is not the case here, right? Isn't this because of the
powerpc issue reported here:
https://lore.kernel.org/r/20240705203413.wbv2nw3747vjeibk@altlinux.org
?
If not, why not just backport the single missing arm64 commit, and why
didn't this show up in testing?
confused,
greg k-h
next prev parent reply other threads:[~2024-07-06 9:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-06 3:11 [PATCH] Revert "bpf: Take return from set_memory_rox() into account with bpf_jit_binary_lock_ro()" for linux-6.6.37 WangYuli
2024-07-06 9:30 ` Greg KH [this message]
2024-07-07 7:34 ` WangYuli
2024-07-08 12:36 ` Greg KH
2024-07-08 15:12 ` LEROY Christophe
2024-07-09 9:15 ` Greg KH
2024-07-09 9:24 ` LEROY Christophe
2024-07-09 9:39 ` Greg KH
2024-07-09 10:03 ` LEROY Christophe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024070631-unrivaled-fever-8548@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=agordeev@linux.ibm.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=baimingcong@uniontech.com \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@iogearbox.net \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dsahern@kernel.org \
--cc=gor@linux.ibm.com \
--cc=guanwentao@uniontech.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=iii@linux.ibm.com \
--cc=illusionist.neo@gmail.com \
--cc=johan.almbladh@anyfinetworks.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=keescook@chromium.org \
--cc=kernel@xen0n.name \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=loongarch@lists.linux.dev \
--cc=martin.lau@linux.dev \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=puranjay12@gmail.com \
--cc=sashal@kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=wangyuli@uniontech.com \
--cc=x86@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.