From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E31FC3DA42 for ; Mon, 8 Jul 2024 12:42:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C71DF80E8D; Mon, 8 Jul 2024 12:42:36 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 5X6mUsc4N9sX; Mon, 8 Jul 2024 12:42:36 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3808480E1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1720442556; bh=SQ25DH3FAQ690I+hFpCETtsPY0NleA8C2qdDxpJrVFE=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=E6+9h1OuDR2kzu3lGxcgtrGbggDLiflV6MRSK05WduyUq+un8U0Xtt0wx1aiWZFu0 QNOBJ3ka3cdXLXEkytnCVuxW8XyntLLZAy54h2acO9rg0i5NjndGs0XRx9CScTToje gw1tMD69wZ59QB7YwWSbPOAmjVf61UyTn/aP4/vGUku85MhgKQ6QyR0FH4mtr7eALI XqidZ13vvCdsDcjL5xMqasTN3DM6Y7JdHFPRaJhXr26Q2lepfvGJDnWAzNqKMXiO5L bWaR93CRoGAPDtFVdN1Et2g+OAbGaVnoOL7hI9OLWZIcmF0+kpM2t0dS4n1OfTOyHG PorbnKk+W/+Gw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 3808480E1E; Mon, 8 Jul 2024 12:42:36 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 278E01BF390 for ; Mon, 8 Jul 2024 12:42:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 1F6A640582 for ; Mon, 8 Jul 2024 12:42:35 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WZ-K5l6QjRJr for ; Mon, 8 Jul 2024 12:42:34 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 490424012D DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 490424012D Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp2.osuosl.org (Postfix) with ESMTPS id 490424012D for ; Mon, 8 Jul 2024 12:42:34 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 91B8C60ABB; Mon, 8 Jul 2024 12:42:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5219C116B1; Mon, 8 Jul 2024 12:42:30 +0000 (UTC) Date: Mon, 8 Jul 2024 13:42:28 +0100 From: Simon Horman To: Mateusz Polchlopek Message-ID: <20240708124228.GS1481495@kernel.org> References: <20240703125922.5625-1-mateusz.polchlopek@intel.com> <20240703125922.5625-7-mateusz.polchlopek@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240703125922.5625-7-mateusz.polchlopek@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720442553; bh=fKVbR/FP1XbnZ96DUlSQR8n5Q2rNwrc61LpUImOtSho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SnNZEtumS7GE5Px0dl+3NAB+RGTzHl29tMBpqYz5C6Htkku4F+SD7EgR3/38X981g OwNQIYVU9Pc/8+Xipk+k/WpoeP/d6ckv2nOXQQO2yTwtCCQMHi+ZOsjM8chs5O6e+Q FTic87tgopObdlFRgyjrV0DCwmbQit6URpiac6gE+vI2a+CQ6/BFt7flbTRqmKvKDW 6dtNMUfmRCnnRfKJk5Bph9nE8mmDzPUFPte+uFOfo9kOFuYIPVCpykd9JS4ucLBQx6 uJnovnz1DVHYEtkWk+5ptoJSoN29nTdEeHXKg8p68YnwOwYIy64AwET9kkApgHLbOE plNfkwWW3kUdQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=SnNZEtum Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 6/6] ice: devlink health: dump also skb on Tx hang X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: willemb@google.com, Wojciech Drewek , dwaipayanray1@gmail.com, linux-kernel@vger.kernel.org, joe@perches.com, edumazet@google.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, apw@canonical.com, lukas.bulwahn@gmail.com, akpm@linux-foundation.org, Przemek Kitszel Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Jul 03, 2024 at 08:59:22AM -0400, Mateusz Polchlopek wrote: > From: Przemek Kitszel > > Extend Tx hang devlink health reporter dump by skb content. > > This commit includes much code copy-pasted from: > - net/core/skbuff.c (function skb_dump() - modified to dump into buffer) > - lib/hexdump.c (function print_hex_dump()) > > Signed-off-by: Przemek Kitszel > Reviewed-by: Wojciech Drewek > Signed-off-by: Mateusz Polchlopek Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD3A47E0F1; Mon, 8 Jul 2024 12:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720442553; cv=none; b=FajU6vvm4sTa6qTNk/4YXQ/w3w3uqx2JvsfO4PyQJgnBrtzlK8s+vjvlrbHCJyiloLv7Rc/vQ8pWLGMt9RfDg7qgmbvuCRjab7WoKnQKwfRDnD6UAP5BIsrimX6btlMvARHgxiJzGIhTGAM8wRFK2X0lJxFq42WgaUr1cwGFXzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720442553; c=relaxed/simple; bh=fKVbR/FP1XbnZ96DUlSQR8n5Q2rNwrc61LpUImOtSho=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GVBWX8KesYfrpLbgIz7/gZ/0QoYE3rBtYV7xU2oPmc3q1zCB7NyltjhV+J3JcnXBUKpJ2A68ELKKAhx2KHcsz99UyUwVJYk+5uoy5WpZkzS847sK0GePhKCuVzng94kfZCzMpN/pycN/EobjpJXcUoMAJTrW8egiYPF9k9JKsEI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SnNZEtum; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SnNZEtum" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5219C116B1; Mon, 8 Jul 2024 12:42:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720442553; bh=fKVbR/FP1XbnZ96DUlSQR8n5Q2rNwrc61LpUImOtSho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SnNZEtumS7GE5Px0dl+3NAB+RGTzHl29tMBpqYz5C6Htkku4F+SD7EgR3/38X981g OwNQIYVU9Pc/8+Xipk+k/WpoeP/d6ckv2nOXQQO2yTwtCCQMHi+ZOsjM8chs5O6e+Q FTic87tgopObdlFRgyjrV0DCwmbQit6URpiac6gE+vI2a+CQ6/BFt7flbTRqmKvKDW 6dtNMUfmRCnnRfKJk5Bph9nE8mmDzPUFPte+uFOfo9kOFuYIPVCpykd9JS4ucLBQx6 uJnovnz1DVHYEtkWk+5ptoJSoN29nTdEeHXKg8p68YnwOwYIy64AwET9kkApgHLbOE plNfkwWW3kUdQ== Date: Mon, 8 Jul 2024 13:42:28 +0100 From: Simon Horman To: Mateusz Polchlopek Cc: intel-wired-lan@lists.osuosl.org, apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, akpm@linux-foundation.org, willemb@google.com, edumazet@google.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Przemek Kitszel , Wojciech Drewek Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 6/6] ice: devlink health: dump also skb on Tx hang Message-ID: <20240708124228.GS1481495@kernel.org> References: <20240703125922.5625-1-mateusz.polchlopek@intel.com> <20240703125922.5625-7-mateusz.polchlopek@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240703125922.5625-7-mateusz.polchlopek@intel.com> On Wed, Jul 03, 2024 at 08:59:22AM -0400, Mateusz Polchlopek wrote: > From: Przemek Kitszel > > Extend Tx hang devlink health reporter dump by skb content. > > This commit includes much code copy-pasted from: > - net/core/skbuff.c (function skb_dump() - modified to dump into buffer) > - lib/hexdump.c (function print_hex_dump()) > > Signed-off-by: Przemek Kitszel > Reviewed-by: Wojciech Drewek > Signed-off-by: Mateusz Polchlopek Reviewed-by: Simon Horman