From: Jakub Kicinski <kuba@kernel.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: David Ahern <dsahern@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v2 1/4] ipv4: fix source address selection with route leak
Date: Mon, 8 Jul 2024 13:32:33 -0700 [thread overview]
Message-ID: <20240708133233.732e2f0c@kernel.org> (raw)
In-Reply-To: <cc29ed8c-f0b2-4e6d-8347-21bb13d0bbbc@6wind.com>
On Mon, 8 Jul 2024 20:13:56 +0200 Nicolas Dichtel wrote:
> > long line length. separate setting the value:
> >
> > struct net_device *l3mdev;
> >
> > l3mdev = dev_get_by_index_rcu(net, fl4->flowi4_l3mdev);
> The checkpatch limit is 100-column.
> If the 80-column limit needs to be enforced in net/, maybe a special case should
> be added in checkpatch.
That'd be great. I'm pretty unsuccessful to at getting my patches
accepted to checkpatch and get_maintainers so I gave up.
But I never tried with the line length limit.
next prev parent reply other threads:[~2024-07-08 20:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 14:52 [PATCH net v2 0/4] vrf: fix source address selection with route leak Nicolas Dichtel
2024-07-05 14:52 ` [PATCH net v2 1/4] ipv4: " Nicolas Dichtel
2024-07-07 16:58 ` David Ahern
2024-07-08 18:13 ` Nicolas Dichtel
2024-07-08 20:32 ` Jakub Kicinski [this message]
2024-07-08 21:27 ` Nicolas Dichtel
2024-07-05 14:52 ` [PATCH net v2 2/4] ipv6: " Nicolas Dichtel
2024-07-07 16:58 ` David Ahern
2024-07-08 18:15 ` Nicolas Dichtel
2024-07-08 18:44 ` David Ahern
2024-07-08 21:24 ` Nicolas Dichtel
2024-07-05 14:52 ` [PATCH net v2 3/4] ipv6: take care of scope when choosing the src addr Nicolas Dichtel
2024-07-07 17:00 ` David Ahern
2024-07-05 14:52 ` [PATCH net v2 4/4] selftests: vrf_route_leaking: add local ping test Nicolas Dichtel
2024-07-07 17:01 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708133233.732e2f0c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.