From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Mario Limonciello <superm1@kernel.org>
Cc: "Bartosz Golaszewski" <brgl@bgdev.pl>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Bert Karwatzki" <spasswolf@web.de>,
caleb.connolly@linaro.org, bhelgaas@google.com,
amit.pundir@linaro.org, neil.armstrong@linaro.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
"Praveenkumar Patil" <PraveenKumar.Patil@amd.com>
Subject: Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
Date: Mon, 8 Jul 2024 21:28:56 +0530 [thread overview]
Message-ID: <20240708155856.GE5745@thinkpad> (raw)
In-Reply-To: <8838b5c3-0c51-42f6-9842-186139822be7@kernel.org>
On Mon, Jul 08, 2024 at 10:53:18AM -0500, Mario Limonciello wrote:
> On 7/8/2024 10:49, Bartosz Golaszewski wrote:
>
> >
> > If you have CONFIG_OF enabled then of_platform_populate() will go the
> > normal path and actually try to populate sub-nodes of the host bridge
> > node. If there are no OF nodes (not a device-tree system) then it will
> > fail.
> >
> > Bart
>
> So how about keep both patches then?
Why would anyone running non OF system have CONFIG_OF enabled? If that's the
case, they have to see the error because there would be no DT nodes.
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-07-08 15:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-07 18:38 [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled Bert Karwatzki
2024-07-07 18:47 ` Lukas Wunner
2024-07-08 0:37 ` Krzysztof Wilczyński
2024-07-08 6:52 ` Bartosz Golaszewski
2024-07-08 8:33 ` Krzysztof Wilczyński
2024-07-08 15:29 ` Mario Limonciello
2024-07-08 15:34 ` Bartosz Golaszewski
2024-07-08 15:44 ` Manivannan Sadhasivam
2024-07-08 15:46 ` Mario Limonciello
2024-07-08 15:49 ` Bartosz Golaszewski
2024-07-08 15:53 ` Mario Limonciello
2024-07-08 15:58 ` Bartosz Golaszewski
2024-07-08 16:01 ` Mario Limonciello
2024-07-08 15:58 ` Manivannan Sadhasivam [this message]
2024-07-08 7:22 ` Manivannan Sadhasivam
2024-07-08 9:54 ` Bartosz Golaszewski
2024-07-08 9:55 ` Bartosz Golaszewski
2024-07-08 19:13 ` Bjorn Helgaas
2024-07-08 19:16 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708155856.GE5745@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=PraveenKumar.Patil@amd.com \
--cc=amit.pundir@linaro.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=caleb.connolly@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=neil.armstrong@linaro.org \
--cc=spasswolf@web.de \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.