All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: "Borislav Petkov" <bp@alien8.de>,
	"Tony Luck" <tony.luck@intel.com>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"James Morse" <james.morse@arm.com>,
	"Len Brown" <lenb@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Shiju Jose" <shiju.jose@huawei.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Alison Schofield" <alison.schofield@intel.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Dave Jiang" <dave.jiang@intel.com>,
	"Ira Weiny" <ira.weiny@intel.com>,
	"Shuai Xue" <xueshuai@linux.alibaba.com>,
	linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] efi/cper: align ARM CPER type with UEFI 2.9A/2.10 specs
Date: Mon, 8 Jul 2024 16:50:56 +0100	[thread overview]
Message-ID: <20240708165056.000012d9@Huawei.com> (raw)
In-Reply-To: <ecdee36a787c1ec2c3982e376db3d09576e07a27.1720436039.git.mchehab+huawei@kernel.org>

On Mon,  8 Jul 2024 13:18:14 +0200
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:

> Up to UEFI spec, the type byte of CPER struct for ARM processor was

Up to UEFI spec XXX?

> defined simply as:
> 
> Type at byte offset 4:
> 
> 	- Cache error
> 	- TLB Error
> 	- Bus Error
> 	- Micro-architectural Error
> 	All other values are reserved
> 
> Yet, there was no information about how this would be encoded.
> 
> Spec 2.9A errata corrected it by defining:
> 
> 	- Bit 1 - Cache Error
> 	- Bit 2 - TLB Error
> 	- Bit 3 - Bus Error
> 	- Bit 4 - Micro-architectural Error
> 	All other values are reserved
> 
> That actually aligns with the values already defined on older
> versions at N.2.4.1. Generic Processor Error Section.
> 
> Spec 2.10 also preserve the same encoding as 2.9A
> 
> Adjust CPER and GHES handling code for both generic and ARM
> processors to properly handle UEFI 2.9A and 2.10 encoding.
> 
> Link: https://uefi.org/specs/UEFI/2.10/Apx_N_Common_Platform_Error_Record.html#arm-processor-error-information
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

With above tidied up.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>


  reply	other threads:[~2024-07-08 15:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08 11:18 [PATCH 0/6] Fix issues with ARM Processor CPER records Mauro Carvalho Chehab
2024-07-08 11:18 ` [PATCH 1/6] RAS: ACPI: APEI: add conditional compilation to ARM error report functions Mauro Carvalho Chehab
2024-07-08 11:32   ` Borislav Petkov
2024-07-08 12:10     ` Mauro Carvalho Chehab
2024-07-08 14:43       ` Borislav Petkov
2024-07-11  5:26         ` Mauro Carvalho Chehab
2024-07-08 14:55       ` Jonathan Cameron
2024-07-08 11:18 ` [PATCH 2/6] RAS: Report all ARM processor CPER information to userspace Mauro Carvalho Chehab
2024-07-08 15:34   ` Jonathan Cameron
2024-07-08 11:18 ` [PATCH 3/6] efi/cper: Adjust infopfx size to accept an extra space Mauro Carvalho Chehab
2024-07-08 11:18 ` [PATCH 4/6] efi/cper: Add a new helper function to print bitmasks Mauro Carvalho Chehab
2024-07-08 15:45   ` Jonathan Cameron
2024-07-08 11:18 ` [PATCH 5/6] efi/cper: align ARM CPER type with UEFI 2.9A/2.10 specs Mauro Carvalho Chehab
2024-07-08 15:50   ` Jonathan Cameron [this message]
2024-07-08 11:18 ` [PATCH 6/6] docs: efi: add CPER functions to driver-api Mauro Carvalho Chehab
2024-07-08 15:47   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240708165056.000012d9@Huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=alison.schofield@intel.com \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=james.morse@arm.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=rafael@kernel.org \
    --cc=shiju.jose@huawei.com \
    --cc=tony.luck@intel.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=xueshuai@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.