All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fiona Klute via buildroot <buildroot@buildroot.org>
Cc: Fiona Klute <fiona.klute@gmx.de>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH v4 0/3] Refactor OpenSSH init.d script
Date: Mon, 8 Jul 2024 23:53:39 +0200	[thread overview]
Message-ID: <20240708235339.5dbf3da4@windsurf> (raw)
In-Reply-To: <20240704101631.1860647-1-fiona.klute@gmx.de>

Hello Fiona,

On Thu,  4 Jul 2024 12:16:28 +0200
Fiona Klute via buildroot <buildroot@buildroot.org> wrote:

> Fiona Klute (WIWA) (3):
>   package/openssh: manage sshd using start-stop-daemon
>   package/openssh: fix init script indentation
>   package/openssh: implement "reload" using SIGHUP

Thanks, I have applied your series, but I have reworked quite a bit
PATCH 1/3 and 3/3 to follow the canonical example of init script we
give in the Buildroot documentation, see:

  https://buildroot.org/downloads/manual/manual.html#adding-packages-start-script

And review the final commits:

  https://gitlab.com/buildroot.org/buildroot/-/commit/8900311b7e5450082cace986533a093d37900efa
  https://gitlab.com/buildroot.org/buildroot/-/commit/df605de1349251687640519fcc2d2147cf146af9
  https://gitlab.com/buildroot.org/buildroot/-/commit/2c14a55c6cf28ada9f1d3d17d3b11370829372ca

Hopefully I didn't mess up :/

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2024-07-08 21:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-04 10:16 [Buildroot] [PATCH v4 0/3] Refactor OpenSSH init.d script Fiona Klute via buildroot
2024-07-04 10:16 ` [Buildroot] [PATCH v4 1/3] package/openssh: manage sshd using start-stop-daemon Fiona Klute via buildroot
2024-07-04 10:16 ` [Buildroot] [PATCH v4 2/3] package/openssh: fix init script indentation Fiona Klute via buildroot
2024-07-04 10:16 ` [Buildroot] [PATCH v4 3/3] package/openssh: implement "reload" using SIGHUP Fiona Klute via buildroot
2024-07-08 21:53 ` Thomas Petazzoni via buildroot [this message]
2024-07-09  9:55   ` [Buildroot] [PATCH v4 0/3] Refactor OpenSSH init.d script Fiona Klute via buildroot
2024-07-09 10:06     ` Thomas Petazzoni via buildroot
2024-07-09 11:31       ` Fiona Klute via buildroot
2024-07-09 11:44         ` yann.morin
2024-07-10 17:39           ` Fiona Klute via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240708235339.5dbf3da4@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fiona.klute@gmx.de \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.