All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Cindy Lu <lulu@redhat.com>
Cc: <dtatulea@nvidia.com>, <mst@redhat.com>, <jasowang@redhat.com>,
	<parav@nvidia.com>, <sgarzare@redhat.com>,
	<netdev@vger.kernel.org>,
	<virtualization@lists.linux-foundation.org>,
	<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>
Subject: Re: [PATCH] vdpa/mlx5: Add the support of set mac address
Date: Tue, 9 Jul 2024 10:26:09 +0530	[thread overview]
Message-ID: <20240709045609.GA3082655@maili.marvell.com> (raw)

On 2024-07-08 at 12:25:49, Cindy Lu (lulu@redhat.com) wrote:
> +static int mlx5_vdpa_set_attr_mac(struct vdpa_mgmt_dev *v_mdev,
> +				  struct vdpa_device *dev,
> +				  const struct vdpa_dev_set_config *add_config)
> +{
> +	struct mlx5_vdpa_dev *mvdev = to_mvdev(dev);
> +	struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);
> +	struct mlx5_core_dev *mdev = mvdev->mdev;
> +	struct virtio_net_config *config = &ndev->config;
> +	int err;
> +	struct mlx5_core_dev *pfmdev;
nit: reverse xmas tree; may be, split assigment and definition.

>

             reply	other threads:[~2024-07-09  4:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-09  4:56 Ratheesh Kannoth [this message]
2024-07-09  7:35 ` [PATCH] vdpa/mlx5: Add the support of set mac address Cindy Lu
  -- strict thread matches above, loose matches on Subject: below --
2024-07-08  6:55 Cindy Lu
2024-07-08  7:03 ` Jason Wang
2024-07-09  7:33   ` Cindy Lu
2024-07-08  7:27 ` Dragos Tatulea
2024-07-09  7:36   ` Cindy Lu
2024-07-08 11:26 ` Michael S. Tsirkin
2024-07-09  7:34   ` Cindy Lu
2024-07-08 19:00 ` Andrew Lunn
2024-07-09  4:03   ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240709045609.GA3082655@maili.marvell.com \
    --to=rkannoth@marvell.com \
    --cc=dtatulea@nvidia.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=parav@nvidia.com \
    --cc=sgarzare@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.