Re: [PATCH 0/1] A new virtio-blk error code for host-side ENOSPC

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Jul 09, 2024 at 02:14:47PM +0200, Stefan Hajnoczi wrote:
> On Wed, Jul 03, 2024 at 06:55:38PM -0400, Michael S. Tsirkin wrote:
> > On Wed, Jun 19, 2024 at 10:00:24AM -0400, Stefan Hajnoczi wrote:
> > > On Tue, Jun 18, 2024 at 05:18:57PM +0900, Keiichi Watanabe wrote:
> > > > This patch proposes a new error code VIRTIO_BLK_S_NOSPC to report
> > > > the device's ENOSPC error to the driver so the driver can treat it
> > > > in a different way from other IO errors.
> > > > More motivation is explained in fs-devel mail [1].
> > > > 
> > > > [2] is a prototype implementation in crosvm and [3] is in virtio-blk
> > > > driver. Idealy, the error should be propagated to the guest file system
> > > > and handled smartly, but the part is still under discussion.
> > > > 
> > > > [1]: https://lore.kernel.org/linux-fsdevel/CAD90VcZybb0ZOVrhE-MqDPwEya8878uzA1RBwd68U7x4CufkTQ@mail.gmail.com/T/#u
> > > 
> > > I have replied on linux-fsdevel so we can discuss a bit more about the
> > > context and get input from storage and file systems people.
> > > 
> > > Thanks,
> > > Stefan
> > 
> > Stefan could you also comment on whether we are likely to add many more
> > errno values soonish?
> 
> I'm not aware of other in-flight or upcoming work that will add new
> virtio-blk error codes.
> 
> Stefan

I'd guess the original approach is ok then, if it's going to just be
this error for the next X years, we are better off with a simple
change.

-- 
MST