All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@lists.linux.dev
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH 07/11] qmi: gprs-context: Treat IP family TLV as mandatory
Date: Tue,  9 Jul 2024 17:50:26 -0500	[thread overview]
Message-ID: <20240709225047.1427626-7-denkenz@gmail.com> (raw)
In-Reply-To: <20240709225047.1427626-1-denkenz@gmail.com>

Also, while here, coalesce two debugging statements into one.
---
 drivers/qmimodem/gprs-context.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/qmimodem/gprs-context.c b/drivers/qmimodem/gprs-context.c
index f29f10720710..203a320a42af 100644
--- a/drivers/qmimodem/gprs-context.c
+++ b/drivers/qmimodem/gprs-context.c
@@ -46,10 +46,10 @@ static void pkt_status_notify(struct qmi_result *result, void *user_data)
 	if (!status)
 		return;
 
-	DBG("conn status %d", status->status);
+	if (!qmi_result_get_uint8(result, RESULT_IP_FAMILY, &ip_family))
+		return;
 
-	if (qmi_result_get_uint8(result, RESULT_IP_FAMILY, &ip_family))
-		DBG("ip family %d", ip_family);
+	DBG("conn status %d ip family %d", status->status, ip_family);
 
 	switch (status->status) {
 	case QMI_WDS_CONNECTION_STATUS_DISCONNECTED:
-- 
2.45.2


  parent reply	other threads:[~2024-07-09 22:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-09 22:50 [PATCH 01/11] gobi: Limit number of premultiplexed contexts to 4 Denis Kenzior
2024-07-09 22:50 ` [PATCH 02/11] gobi: Request dedicated WDS services for contexts Denis Kenzior
2024-07-09 22:50 ` [PATCH 03/11] qmi: Enable _auto_ use for some classes Denis Kenzior
2024-07-09 22:50 ` [PATCH 04/11] qmi: gprs-context: Declare qmi_service objects using _auto_ Denis Kenzior
2024-07-09 22:50 ` [PATCH 05/11] qmi: Pass two dedicated WDS services to gprs-context Denis Kenzior
2024-07-09 22:50 ` [PATCH 06/11] qmi: gprs-context: Remove parsing of unused TLVs Denis Kenzior
2024-07-09 22:50 ` Denis Kenzior [this message]
2024-07-09 22:50 ` [PATCH 08/11] qmi: gprs-context: Set up WDS service for IPv6 Denis Kenzior
2024-07-09 22:50 ` [PATCH 09/11] qmi: gprs-context: refactor detach_shutdown path Denis Kenzior
2024-07-09 22:50 ` [PATCH 10/11] qmi: gprs-context: refactor deactivate_primary Denis Kenzior
2024-07-09 22:50 ` [PATCH 11/11] qmi: gprs-context: Dual-Stack context activation support Denis Kenzior
2024-07-11 17:53 ` [PATCH 01/11] gobi: Limit number of premultiplexed contexts to 4 patchwork-bot+ofono

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240709225047.1427626-7-denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.